Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F fluidsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • fluiddyn
  • fluidsim
  • Merge requests
  • !89

Merged
Created Feb 25, 2019 by Bitbucket Importer@bitbucket_importerMaintainer

Fix memory leak allreduce in increments

  • Overview 1
  • Commits 2
  • Changes 10

Created originally on Bitbucket by paugier (Pierre Augier)

Was already merged in Bitbucket before import, marked as merged by the import user

Fixes issue #29 (closed) (for CPython 3.7.0 and 3.7.1).

Note that other uses of allreduce are for integers and it seems that there is no memory leak in this case (or very small). Anyway, this problem has been solved in CPython 3.7.2, so I don’t think it’s worth it to do much more on this problem.

The main memory leak was for increments and it should be solved with this PR. We know that there should be another similar case in fluidfft, which could be fixed the same way, but another strategy would be to use CPython == 3.6 or >= 3.7.2.

  • Fix memory leak allreduce + simul_ns2dstrat_quasi1d.py
  • Improve strat/outputs
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bitbucket/merged-pr-89