Skip to content

Compatibility with existing Twine story spec

Bitbucket Importer requested to merge bitbucket/declined-pr-3 into branch/default

Created originally on Bitbucket by klembot (Chris Klimas)

Changesets for this Pull Request have not been imported, because it had been already declined on Bitbucket. Marked as closed by the import user.

I went to integrate your latest changes and ran into trouble -- it looks like your code was expecting a element to contain the story data, with slightly different attribute names. I modified this to allow for either or

as the enclosing element (as the Twine editor currently outputs), and changes the attribute names back to what the Twine editor currently outputs.

We should have a discussion about this... I consider this commit as a stopgap at best. I don't have an objection to using custom tags so long as there isn't an impact on browser compatibility, which I haven't looked into. I worry a little bit too that the W3C spec on this is still in flux.

Merge request reports