Commit 9cf363d2 authored by Georges Racinet on's avatar Georges Racinet on
Browse files

Reverse calls: explicit IP addresses

It can happen that WSGIServer (itself based on socketserver.BaseServer)
binds by default using IPv4 while the `localhost` default call address
that will be stored on the Rails side for reverse calls will resolve to
`::1`. Since some of the contexts for these tests only have IPv4 (Docker
containters), we're binding explicitely to the all IPv4 addresses

On many Linux systems, the kernel is configured so that :: serves all
IPv6 and IPv4 address (through representation of the IPv4 address
space in IPv6). We'' switch to that if we turn out to need IPv6 and it works
in our Docker CI contexts. For now, let's spare us another round of testing.
parent fde737b00f53
Pipeline #24217 passed with stage
in 22 minutes and 57 seconds
......@@ -655,7 +655,7 @@ class OmnibusHeptapod(Heptapod):
gitlab_ctl_command = ('sudo', 'gitlab-ctl')
reverse_call_host = 'localhost'
reverse_call_host = ''
ssh_url = 'ssh://git@localhost'
......@@ -813,7 +813,7 @@ class SourceHeptapod(Heptapod):
shell_access = True
reverse_call_host = 'localhost'
reverse_call_host = ''
def ssh_url(self):
......@@ -868,7 +868,7 @@ class GdkHeptapod(SourceHeptapod):
shell_access = True
reverse_call_host = 'localhost'
reverse_call_host = ''
RAILS_SERVICES = ('rails-web', 'rails-background-jobs')
......@@ -32,7 +32,7 @@ def http_server(queue):
if isinstance(v, str)}))
return ''
with make_server('', 0, app) as httpd:
with make_server('', 0, app) as httpd:
port = httpd.server_address[1]
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment