Read about our upcoming Code of Conduct on this issue

project_spec.rb 62.1 KB
Newer Older
gitlabhq's avatar
gitlabhq committed
1
2
require 'spec_helper'

Douwe Maan's avatar
Douwe Maan committed
3
describe Project, models: true do
4
  describe 'associations' do
5
6
7
8
    it { is_expected.to belong_to(:group) }
    it { is_expected.to belong_to(:namespace) }
    it { is_expected.to belong_to(:creator).class_name('User') }
    it { is_expected.to have_many(:users) }
ubudzisz's avatar
ubudzisz committed
9
    it { is_expected.to have_many(:services) }
10
11
12
13
14
    it { is_expected.to have_many(:events).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:issues).dependent(:destroy) }
    it { is_expected.to have_many(:milestones).dependent(:destroy) }
    it { is_expected.to have_many(:project_members).dependent(:destroy) }
15
16
    it { is_expected.to have_many(:users).through(:project_members) }
    it { is_expected.to have_many(:requesters).dependent(:destroy) }
17
18
19
20
21
22
23
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:snippets).class_name('ProjectSnippet').dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys_projects).dependent(:destroy) }
    it { is_expected.to have_many(:deploy_keys) }
    it { is_expected.to have_many(:hooks).dependent(:destroy) }
    it { is_expected.to have_many(:protected_branches).dependent(:destroy) }
    it { is_expected.to have_one(:forked_project_link).dependent(:destroy) }
24
    it { is_expected.to have_one(:slack_service).dependent(:destroy) }
Tiago Botelho's avatar
Tiago Botelho committed
25
    it { is_expected.to have_one(:microsoft_teams_service).dependent(:destroy) }
26
    it { is_expected.to have_one(:mattermost_service).dependent(:destroy) }
27
28
    it { is_expected.to have_one(:pushover_service).dependent(:destroy) }
    it { is_expected.to have_one(:asana_service).dependent(:destroy) }
29
    it { is_expected.to have_many(:boards).dependent(:destroy) }
ubudzisz's avatar
ubudzisz committed
30
31
32
    it { is_expected.to have_one(:campfire_service).dependent(:destroy) }
    it { is_expected.to have_one(:drone_ci_service).dependent(:destroy) }
    it { is_expected.to have_one(:emails_on_push_service).dependent(:destroy) }
Kamil Trzciński's avatar
Kamil Trzciński committed
33
    it { is_expected.to have_one(:pipelines_email_service).dependent(:destroy) }
ubudzisz's avatar
ubudzisz committed
34
35
36
37
38
    it { is_expected.to have_one(:irker_service).dependent(:destroy) }
    it { is_expected.to have_one(:pivotaltracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:hipchat_service).dependent(:destroy) }
    it { is_expected.to have_one(:flowdock_service).dependent(:destroy) }
    it { is_expected.to have_one(:assembla_service).dependent(:destroy) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
39
    it { is_expected.to have_one(:slack_slash_commands_service).dependent(:destroy) }
40
    it { is_expected.to have_one(:mattermost_slash_commands_service).dependent(:destroy) }
ubudzisz's avatar
ubudzisz committed
41
42
43
44
45
46
47
48
49
50
51
    it { is_expected.to have_one(:gemnasium_service).dependent(:destroy) }
    it { is_expected.to have_one(:buildkite_service).dependent(:destroy) }
    it { is_expected.to have_one(:bamboo_service).dependent(:destroy) }
    it { is_expected.to have_one(:teamcity_service).dependent(:destroy) }
    it { is_expected.to have_one(:jira_service).dependent(:destroy) }
    it { is_expected.to have_one(:redmine_service).dependent(:destroy) }
    it { is_expected.to have_one(:custom_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:bugzilla_service).dependent(:destroy) }
    it { is_expected.to have_one(:gitlab_issue_tracker_service).dependent(:destroy) }
    it { is_expected.to have_one(:external_wiki_service).dependent(:destroy) }
    it { is_expected.to have_one(:project_feature).dependent(:destroy) }
Markus Koller's avatar
Markus Koller committed
52
    it { is_expected.to have_one(:statistics).class_name('ProjectStatistics').dependent(:delete) }
ubudzisz's avatar
ubudzisz committed
53
54
55
    it { is_expected.to have_one(:import_data).class_name('ProjectImportData').dependent(:destroy) }
    it { is_expected.to have_one(:last_event).class_name('Event') }
    it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
56
    it { is_expected.to have_many(:commit_statuses) }
57
    it { is_expected.to have_many(:pipelines) }
58
59
60
    it { is_expected.to have_many(:builds) }
    it { is_expected.to have_many(:runner_projects) }
    it { is_expected.to have_many(:runners) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
61
    it { is_expected.to have_many(:active_runners) }
62
63
    it { is_expected.to have_many(:variables) }
    it { is_expected.to have_many(:triggers) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
64
    it { is_expected.to have_many(:pages_domains) }
65
    it { is_expected.to have_many(:labels).class_name('ProjectLabel').dependent(:destroy) }
ubudzisz's avatar
ubudzisz committed
66
    it { is_expected.to have_many(:users_star_projects).dependent(:destroy) }
67
68
    it { is_expected.to have_many(:environments).dependent(:destroy) }
    it { is_expected.to have_many(:deployments).dependent(:destroy) }
69
    it { is_expected.to have_many(:todos).dependent(:destroy) }
ubudzisz's avatar
ubudzisz committed
70
71
72
73
74
    it { is_expected.to have_many(:releases).dependent(:destroy) }
    it { is_expected.to have_many(:lfs_objects_projects).dependent(:destroy) }
    it { is_expected.to have_many(:project_group_links).dependent(:destroy) }
    it { is_expected.to have_many(:notification_settings).dependent(:destroy) }
    it { is_expected.to have_many(:forks).through(:forked_project_links) }
75
    it { is_expected.to have_many(:uploads).dependent(:destroy) }
76
    it { is_expected.to have_many(:pipeline_schedules).dependent(:destroy) }
77

78
79
    context 'after initialized' do
      it "has a project_feature" do
80
        expect(Project.new.project_feature).to be_present
81
82
83
      end
    end

84
    describe '#members & #requesters' do
85
      let(:project) { create(:empty_project, :public, :access_requestable) }
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
      let(:requester) { create(:user) }
      let(:developer) { create(:user) }
      before do
        project.request_access(requester)
        project.team << [developer, :developer]
      end

      describe '#members' do
        it 'includes members and exclude requesters' do
          member_user_ids = project.members.pluck(:user_id)

          expect(member_user_ids).to include(developer.id)
          expect(member_user_ids).not_to include(requester.id)
        end
      end

      describe '#requesters' do
        it 'does not include requesters' do
          requester_user_ids = project.requesters.pluck(:user_id)

          expect(requester_user_ids).to include(requester.id)
          expect(requester_user_ids).not_to include(developer.id)
        end
      end
    end
111
112
113
114
115

    describe '#boards' do
      it 'raises an error when attempting to add more than one board to the project' do
        subject.boards.build

116
        expect { subject.boards.build }.to raise_error(Project::BoardLimitExceeded, 'Number of permitted boards exceeded')
117
118
119
        expect(subject.boards.size).to eq 1
      end
    end
gitlabhq's avatar
gitlabhq committed
120
121
  end

122
123
124
125
126
127
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Gitlab::ShellAdapter) }
    it { is_expected.to include_module(Gitlab::VisibilityLevel) }
128
    it { is_expected.to include_module(Gitlab::CurrentSettings) }
129
130
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
131
132
  end

133
  describe 'validation' do
134
    let!(:project) { create(:empty_project) }
135

136
137
    it { is_expected.to validate_presence_of(:name) }
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:namespace_id) }
138
    it { is_expected.to validate_length_of(:name).is_at_most(255) }
139

140
141
    it { is_expected.to validate_presence_of(:path) }
    it { is_expected.to validate_uniqueness_of(:path).scoped_to(:namespace_id) }
142
143
144
145
    it { is_expected.to validate_length_of(:path).is_at_most(255) }

    it { is_expected.to validate_length_of(:description).is_at_most(2000) }

146
    it { is_expected.to validate_presence_of(:creator) }
147

148
    it { is_expected.to validate_presence_of(:namespace) }
149

150
    it { is_expected.to validate_presence_of(:repository_storage) }
151

152
    it 'does not allow new projects beyond user limits' do
153
      project2 = build(:empty_project)
154
155
      allow(project2).to receive(:creator).and_return(double(can_create_project?: false, projects_limit: 0).as_null_object)
      expect(project2).not_to be_valid
Phil Hughes's avatar
Phil Hughes committed
156
      expect(project2.errors[:limit_reached].first).to match(/Personal project creation is not allowed/)
157
    end
158
159
160

    describe 'wiki path conflict' do
      context "when the new path has been used by the wiki of other Project" do
161
        it 'has an error on the name attribute' do
162
          new_project = build_stubbed(:empty_project, namespace_id: project.namespace_id, path: "#{project.path}.wiki")
163
164
165
166
167
168
169

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end

      context "when the new wiki path has been used by the path of other Project" do
170
        it 'has an error on the name attribute' do
171
172
          project_with_wiki_suffix = create(:empty_project, path: 'foo.wiki')
          new_project = build_stubbed(:empty_project, namespace_id: project_with_wiki_suffix.namespace_id, path: 'foo')
173
174
175
176
177
178

          expect(new_project).not_to be_valid
          expect(new_project.errors[:name].first).to eq('has already been taken')
        end
      end
    end
179
180

    context 'repository storages inclussion' do
181
      let(:project2) { build(:empty_project, repository_storage: 'missing') }
182
183

      before do
184
        storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
185
186
187
        allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      end

188
      it "does not allow repository storages that don't match a label in the configuration" do
189
190
191
192
        expect(project2).not_to be_valid
        expect(project2.errors[:repository_storage].first).to match(/is not included in the list/)
      end
    end
193

194
    it 'does not allow an invalid URI as import_url' do
195
      project2 = build(:empty_project, import_url: 'invalid://')
James Lopez's avatar
James Lopez committed
196
197
198
199

      expect(project2).not_to be_valid
    end

200
    it 'does allow a valid URI as import_url' do
201
      project2 = build(:empty_project, import_url: 'ssh://test@gitlab.com/project.git')
James Lopez's avatar
James Lopez committed
202

203
204
      expect(project2).to be_valid
    end
205

206
    it 'allows an empty URI' do
207
      project2 = build(:empty_project, import_url: '')
208

209
      expect(project2).to be_valid
210
211
212
    end

    it 'does not produce import data on an empty URI' do
213
      project2 = build(:empty_project, import_url: '')
214
215
216
217
218

      expect(project2.import_data).to be_nil
    end

    it 'does not produce import data on an invalid URI' do
219
      project2 = build(:empty_project, import_url: 'test://')
220
221
222

      expect(project2.import_data).to be_nil
    end
223

224
225
226
227
228
229
230
231
232
233
234
235
236
237
    it "does not allow blocked import_url localhost" do
      project2 = build(:empty_project, import_url: 'http://localhost:9000/t.git')

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

    it "does not allow blocked import_url port" do
      project2 = build(:empty_project, import_url: 'http://github.com:25/t.git')

      expect(project2).to be_invalid
      expect(project2.errors[:import_url]).to include('imports are not allowed from that URL')
    end

238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
    describe 'project pending deletion' do
      let!(:project_pending_deletion) do
        create(:empty_project,
               pending_delete: true)
      end
      let(:new_project) do
        build(:empty_project,
              name: project_pending_deletion.name,
              namespace: project_pending_deletion.namespace)
      end

      before do
        new_project.validate
      end

      it 'contains errors related to the project being deleted' do
        expect(new_project.errors.full_messages.first).to eq('The project is still being deleted. Please try again later.')
      end
    end
257
258
259
260
261
262
263
264
265
266
267
268
269

    describe 'path validation' do
      it 'allows paths reserved on the root namespace' do
        project = build(:project, path: 'api')

        expect(project).to be_valid
      end

      it 'rejects paths reserved on another level' do
        project = build(:project, path: 'tree')

        expect(project).not_to be_valid
      end
270
271
272
273
274
275
276

      it 'rejects nested paths' do
        parent = create(:group, :nested, path: 'environments')
        project = build(:project, path: 'folders', namespace: parent)

        expect(project).not_to be_valid
      end
277
278
279
280
281
282
283

      it 'allows a reserved group name' do
        parent = create(:group)
        project = build(:project, path: 'avatar', namespace: parent)

        expect(project).to be_valid
      end
284
    end
gitlabhq's avatar
gitlabhq committed
285
  end
286

287
288
289
290
291
292
293
294
295
  describe 'default_scope' do
    it 'excludes projects pending deletion from the results' do
      project = create(:empty_project)
      create(:empty_project, pending_delete: true)

      expect(Project.all).to eq [project]
    end
  end

296
  describe 'project token' do
297
    it 'sets an random token if none provided' do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
298
299
      project = FactoryGirl.create :empty_project, runners_token: ''
      expect(project.runners_token).not_to eq('')
300
301
    end

ubudzisz's avatar
ubudzisz committed
302
    it 'does not set an random token if one provided' do
Kamil Trzcinski's avatar
Kamil Trzcinski committed
303
304
      project = FactoryGirl.create :empty_project, runners_token: 'my-token'
      expect(project.runners_token).to eq('my-token')
305
306
    end
  end
gitlabhq's avatar
gitlabhq committed
307

308
  describe 'Respond to' do
309
310
311
312
313
    it { is_expected.to respond_to(:url_to_repo) }
    it { is_expected.to respond_to(:repo_exists?) }
    it { is_expected.to respond_to(:execute_hooks) }
    it { is_expected.to respond_to(:owner) }
    it { is_expected.to respond_to(:path_with_namespace) }
gitlabhq's avatar
gitlabhq committed
314
315
  end

316
317
318
319
320
321
322
  describe 'delegation' do
    it { is_expected.to delegate_method(:add_guest).to(:team) }
    it { is_expected.to delegate_method(:add_reporter).to(:team) }
    it { is_expected.to delegate_method(:add_developer).to(:team) }
    it { is_expected.to delegate_method(:add_master).to(:team) }
  end

323
  describe '#to_reference' do
324
    let(:owner)     { create(:user, name: 'Gitlab') }
325
    let(:namespace) { create(:namespace, path: 'sample-namespace', owner: owner) }
326
327
    let(:project)   { create(:empty_project, path: 'sample-project', namespace: namespace) }
    let(:group)     { create(:group, name: 'Group', path: 'sample-group', owner: owner) }
328

329
    context 'when nil argument' do
330
331
332
333
334
      it 'returns nil' do
        expect(project.to_reference).to be_nil
      end
    end

335
    context 'when full is true' do
336
      it 'returns complete path to the project' do
337
338
339
        expect(project.to_reference(full: true)).to          eq 'sample-namespace/sample-project'
        expect(project.to_reference(project, full: true)).to eq 'sample-namespace/sample-project'
        expect(project.to_reference(group, full: true)).to   eq 'sample-namespace/sample-project'
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
      let(:another_namespace_project) { create(:empty_project, name: 'another-project') }

      it 'returns complete path to the project' do
        expect(project.to_reference(another_namespace_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when same namespace / cross-project argument' do
      let(:another_project) { create(:empty_project, namespace: namespace) }

360
      it 'returns path to the project' do
361
362
363
        expect(project.to_reference(another_project)).to eq 'sample-project'
      end
    end
364

365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
    context 'when different namespace / cross-project argument' do
      let(:another_namespace) { create(:namespace, path: 'another-namespace', owner: owner) }
      let(:another_project)   { create(:empty_project, path: 'another-project', namespace: another_namespace) }

      it 'returns full path to the project' do
        expect(project.to_reference(another_project)).to eq 'sample-namespace/sample-project'
      end
    end

    context 'when argument is a namespace' do
      context 'with same project path' do
        it 'returns path to the project' do
          expect(project.to_reference(namespace)).to eq 'sample-project'
        end
      end

      context 'with different project path' do
        it 'returns full path to the project' do
          expect(project.to_reference(group)).to eq 'sample-namespace/sample-project'
        end
385
386
      end
    end
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
  end

  describe '#to_human_reference' do
    let(:owner) { create(:user, name: 'Gitlab') }
    let(:namespace) { create(:namespace, name: 'Sample namespace', owner: owner) }
    let(:project) { create(:empty_project, name: 'Sample project', namespace: namespace) }

    context 'when nil argument' do
      it 'returns nil' do
        expect(project.to_human_reference).to be_nil
      end
    end

    context 'when same project argument' do
      it 'returns nil' do
        expect(project.to_human_reference(project)).to be_nil
      end
    end

    context 'when cross namespace project argument' do
      let(:another_namespace_project) { create(:empty_project, name: 'another-project') }

      it 'returns complete name with namespace of the project' do
        expect(project.to_human_reference(another_namespace_project)).to eq 'Gitlab / Sample project'
      end
    end

    context 'when same namespace / cross-project argument' do
      let(:another_project) { create(:empty_project, namespace: namespace) }

      it 'returns name of the project' do
        expect(project.to_human_reference(another_project)).to eq 'Sample project'
      end
420
421
422
    end
  end

423
  describe '#repository_storage_path' do
424
    let(:project) { create(:empty_project, repository_storage: 'custom') }
425
426
427

    before do
      FileUtils.mkdir('tmp/tests/custom_repositories')
428
      storages = { 'custom' => { 'path' => 'tmp/tests/custom_repositories' } }
429
430
431
432
433
434
435
436
437
438
439
440
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

    after do
      FileUtils.rm_rf('tmp/tests/custom_repositories')
    end

    it 'returns the repository storage path' do
      expect(project.repository_storage_path).to eq('tmp/tests/custom_repositories')
    end
  end

441
  it 'returns valid url to repo' do
442
    project = Project.new(path: 'somewhere')
443
    expect(project.url_to_repo).to eq(Gitlab.config.gitlab_shell.ssh_path_prefix + 'somewhere.git')
gitlabhq's avatar
gitlabhq committed
444
445
  end

Douwe Maan's avatar
Douwe Maan committed
446
447
448
449
  describe "#web_url" do
    let(:project) { create(:empty_project, path: "somewhere") }

    it 'returns the full web URL for this repo' do
450
      expect(project.web_url).to eq("#{Gitlab.config.gitlab.url}/#{project.namespace.full_path}/somewhere")
Douwe Maan's avatar
Douwe Maan committed
451
    end
452
453
  end

454
  describe "#new_issue_address" do
455
456
457
    let(:project) { create(:empty_project, path: "somewhere") }
    let(:user) { create(:user) }

458
459
460
461
462
463
    context 'incoming email enabled' do
      before do
        stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
      end

      it 'returns the address to create a new issue' do
464
        address = "p+#{project.path_with_namespace}+#{user.incoming_email_token}@gl.ab"
465
466
467
468
469
470
471
472
473

        expect(project.new_issue_address(user)).to eq(address)
      end
    end

    context 'incoming email disabled' do
      before do
        stub_incoming_email_setting(enabled: false)
      end
474

475
476
477
      it 'returns nil' do
        expect(project.new_issue_address(user)).to be_nil
      end
478
479
480
    end
  end

481
  describe 'last_activity methods' do
482
483
    let(:timestamp) { 2.hours.ago }
    # last_activity_at gets set to created_at upon creation
484
    let(:project) { create(:empty_project, created_at: timestamp, updated_at: timestamp) }
gitlabhq's avatar
gitlabhq committed
485

486
    describe 'last_activity' do
487
      it 'alias last_activity to last_event' do
488
489
        last_event = create(:event, project: project)

490
        expect(project.last_activity).to eq(last_event)
491
      end
gitlabhq's avatar
gitlabhq committed
492
493
    end

494
495
    describe 'last_activity_date' do
      it 'returns the creation date of the project\'s last event if present' do
496
497
        new_event = create(:event, project: project, created_at: Time.now)

498
        project.reload
499
        expect(project.last_activity_at.to_i).to eq(new_event.created_at.to_i)
500
      end
501

502
      it 'returns the project\'s last update date if it has no events' do
503
        expect(project.last_activity_date).to eq(project.updated_at)
504
      end
505
506
    end
  end
507

508
509
  describe '#get_issue' do
    let(:project) { create(:empty_project) }
Stan Hu's avatar
Stan Hu committed
510
    let!(:issue)  { create(:issue, project: project) }
511
512
513
514
515
    let(:user)    { create(:user) }

    before do
      project.team << [user, :developer]
    end
516
517
518

    context 'with default issues tracker' do
      it 'returns an issue' do
519
        expect(project.get_issue(issue.iid, user)).to eq issue
520
521
      end

Stan Hu's avatar
Stan Hu committed
522
523
524
525
      it 'returns count of open issues' do
        expect(project.open_issues_count).to eq(1)
      end

526
      it 'returns nil when no issue found' do
527
528
529
530
531
532
        expect(project.get_issue(999, user)).to be_nil
      end

      it "returns nil when user doesn't have access" do
        user = create(:user)
        expect(project.get_issue(issue.iid, user)).to eq nil
533
534
535
536
537
538
539
540
541
      end
    end

    context 'with external issues tracker' do
      before do
        allow(project).to receive(:default_issues_tracker?).and_return(false)
      end

      it 'returns an ExternalIssue' do
542
        issue = project.get_issue('FOO-1234', user)
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
        expect(issue).to be_kind_of(ExternalIssue)
        expect(issue.iid).to eq 'FOO-1234'
        expect(issue.project).to eq project
      end
    end
  end

  describe '#issue_exists?' do
    let(:project) { create(:empty_project) }

    it 'is truthy when issue exists' do
      expect(project).to receive(:get_issue).and_return(double)
      expect(project.issue_exists?(1)).to be_truthy
    end

    it 'is falsey when issue does not exist' do
      expect(project).to receive(:get_issue).and_return(nil)
      expect(project.issue_exists?(1)).to be_falsey
    end
  end

564
  describe '#to_param' do
565
566
567
    context 'with namespace' do
      before do
        @group = create :group, name: 'gitlab'
568
        @project = create(:empty_project, name: 'gitlabhq', namespace: @group)
569
570
      end

Vinnie Okada's avatar
Vinnie Okada committed
571
      it { expect(@project.to_param).to eq('gitlabhq') }
572
    end
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590

    context 'with invalid path' do
      it 'returns previous path to keep project suitable for use in URLs when persisted' do
        project = create(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'gitlab'
      end

      it 'returns current path when new record' do
        project = build(:empty_project, path: 'gitlab')
        project.path = 'foo&bar'

        expect(project).not_to be_valid
        expect(project.to_param).to eq 'foo&bar'
      end
    end
591
  end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
592

593
  describe '#repository' do
594
    let(:project) { create(:project, :repository) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
595

596
    it 'returns valid repo' do
597
      expect(project.repository).to be_kind_of(Repository)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
598
599
    end
  end
600

601
  describe '#default_issues_tracker?' do
602
    it "is true if used internal tracker" do
603
604
      project = build(:empty_project)

605
      expect(project.default_issues_tracker?).to be_truthy
606
607
    end

608
    it "is false if used other tracker" do
609
610
611
612
      # NOTE: The current nature of this factory requires persistence
      project = create(:redmine_project)

      expect(project.default_issues_tracker?).to be_falsey
613
614
615
    end
  end

616
  describe '#external_issue_tracker' do
617
    let(:project) { create(:empty_project) }
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
    let(:ext_project) { create(:redmine_project) }

    context 'on existing projects with no value for has_external_issue_tracker' do
      before(:each) do
        project.update_column(:has_external_issue_tracker, nil)
        ext_project.update_column(:has_external_issue_tracker, nil)
      end

      it 'updates the has_external_issue_tracker boolean' do
        expect do
          project.external_issue_tracker
        end.to change { project.reload.has_external_issue_tracker }.to(false)

        expect do
          ext_project.external_issue_tracker
        end.to change { ext_project.reload.has_external_issue_tracker }.to(true)
      end
    end

    it 'returns nil and does not query services when there is no external issue tracker' do
      expect(project).not_to receive(:services)

      expect(project.external_issue_tracker).to eq(nil)
    end

    it 'retrieves external_issue_tracker querying services and cache it when there is external issue tracker' do
      ext_project.reload # Factory returns a project with changed attributes
      expect(ext_project).to receive(:services).once.and_call_original

      2.times { expect(ext_project.external_issue_tracker).to be_a_kind_of(RedmineService) }
    end
  end

651
  describe '#cache_has_external_issue_tracker' do
652
    let(:project) { create(:empty_project, has_external_issue_tracker: nil) }
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672

    it 'stores true if there is any external_issue_tracker' do
      services = double(:service, external_issue_trackers: [RedmineService.new])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(true)
    end

    it 'stores false if there is no external_issue_tracker' do
      services = double(:service, external_issue_trackers: [])
      expect(project).to receive(:services).and_return(services)

      expect do
        project.cache_has_external_issue_tracker
      end.to change { project.has_external_issue_tracker}.to(false)
    end
  end

673
  describe '#has_wiki?' do
674
    let(:no_wiki_project)       { create(:empty_project, :wiki_disabled, has_external_wiki: false) }
675
676
    let(:wiki_enabled_project)  { create(:empty_project) }
    let(:external_wiki_project) { create(:empty_project, has_external_wiki: true) }
677
678
679
680
681
682
683
684

    it 'returns true if project is wiki enabled or has external wiki' do
      expect(wiki_enabled_project).to have_wiki
      expect(external_wiki_project).to have_wiki
      expect(no_wiki_project).not_to have_wiki
    end
  end

685
  describe '#external_wiki' do
686
    let(:project) { create(:empty_project) }
687

688
689
690
691
692
    context 'with an active external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: true)
        project.external_wiki
      end
693

694
695
696
      it 'sets :has_external_wiki as true' do
        expect(project.has_external_wiki).to be(true)
      end
697

698
699
      it 'sets :has_external_wiki as false if an external wiki service is destroyed later' do
        expect(project.has_external_wiki).to be(true)
700

701
702
703
704
        project.services.external_wikis.first.destroy

        expect(project.has_external_wiki).to be(false)
      end
705
706
    end

707
708
709
710
    context 'with an inactive external wiki' do
      before do
        create(:service, project: project, type: 'ExternalWikiService', active: false)
      end
711

712
713
714
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end
715
716
    end

717
718
719
720
    context 'with no external wiki' do
      before do
        project.external_wiki
      end
721

722
723
724
725
726
727
728
729
730
731
732
      it 'sets :has_external_wiki as false' do
        expect(project.has_external_wiki).to be(false)
      end

      it 'sets :has_external_wiki as true if an external wiki service is created later' do
        expect(project.has_external_wiki).to be(false)

        create(:service, project: project, type: 'ExternalWikiService', active: true)

        expect(project.has_external_wiki).to be(true)
      end
733
734
735
    end
  end

736
737
  describe '#star_count' do
    it 'counts stars from multiple users' do
Ciro Santilli's avatar
Ciro Santilli committed
738
739
      user1 = create :user
      user2 = create :user
740
      project = create(:empty_project, :public)
Ciro Santilli's avatar
Ciro Santilli committed
741
742

      expect(project.star_count).to eq(0)
743

Ciro Santilli's avatar
Ciro Santilli committed
744
      user1.toggle_star(project)
745
746
      expect(project.reload.star_count).to eq(1)

Ciro Santilli's avatar
Ciro Santilli committed
747
      user2.toggle_star(project)
748
749
750
      project.reload
      expect(project.reload.star_count).to eq(2)

Ciro Santilli's avatar
Ciro Santilli committed
751
      user1.toggle_star(project)
752
753
754
      project.reload
      expect(project.reload.star_count).to eq(1)

Ciro Santilli's avatar
Ciro Santilli committed
755
      user2.toggle_star(project)
756
757
758
759
      project.reload
      expect(project.reload.star_count).to eq(0)
    end

760
    it 'counts stars on the right project' do
761
      user = create :user
762
763
      project1 = create(:empty_project, :public)
      project2 = create(:empty_project, :public)
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790

      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(1)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project1)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(1)

      user.toggle_star(project2)
      project1.reload
      project2.reload
      expect(project1.star_count).to eq(0)
      expect(project2.star_count).to eq(0)
Ciro Santilli's avatar
Ciro Santilli committed
791
792
    end
  end
793

794
  describe '#avatar_type' do
795
    let(:project) { create(:empty_project) }
796

797
    it 'is true if avatar is image' do
798
      project.update_attribute(:avatar, 'uploads/avatar.png')
799
      expect(project.avatar_type).to be_truthy
800
801
    end

802
    it 'is false if avatar is html page' do
803
      project.update_attribute(:avatar, 'uploads/avatar.html')
804
      expect(project.avatar_type).to eq(['only images allowed'])
805
806
    end
  end
sue445's avatar
sue445 committed
807

808
  describe '#avatar_url' do
sue445's avatar
sue445 committed
809
810
    subject { project.avatar_url }

811
    let(:project) { create(:empty_project) }
sue445's avatar
sue445 committed
812

813
814
    context 'when avatar file is uploaded' do
      let(:project) { create(:empty_project, :with_avatar) }
815
      let(:avatar_path) { "/uploads/project/avatar/#{project.id}/dk.png" }
816
      let(:gitlab_host) { "http://#{Gitlab.config.gitlab.host}" }
sue445's avatar
sue445 committed
817

818
819
820
821
822
823
824
825
      it 'shows correct url' do
        expect(project.avatar_url).to eq(avatar_path)
        expect(project.avatar_url(only_path: false)).to eq([gitlab_host, avatar_path].join)

        allow(ActionController::Base).to receive(:asset_host).and_return(gitlab_host)

        expect(project.avatar_url).to eq([gitlab_host, avatar_path].join)
      end
sue445's avatar
sue445 committed
826
827
828
829
830
831
832
    end

    context 'When avatar file in git' do
      before do
        allow(project).to receive(:avatar_in_git) { true }
      end

833
      let(:avatar_path) { "/#{project.full_path}/avatar" }
sue445's avatar
sue445 committed
834

835
      it { should eq "http://#{Gitlab.config.gitlab.host}#{avatar_path}" }
sue445's avatar
sue445 committed
836
    end
837
838
839
840
841
842

    context 'when git repo is empty' do
      let(:project) { create(:empty_project) }

      it { should eq nil }
    end
sue445's avatar
sue445 committed
843
  end
844

845
  describe '#pipeline_for' do
846
    let(:project) { create(:project, :repository) }
847
    let!(:pipeline) { create_pipeline }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
848

849
850
    shared_examples 'giving the correct pipeline' do
      it { is_expected.to eq(pipeline) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
851

852
853
      context 'return latest' do
        let!(:pipeline2) { create_pipeline }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
854

855
        it { is_expected.to eq(pipeline2) }
Kamil Trzcinski's avatar
Kamil Trzcinski committed
856
      end
857
858
859
860
861
862
863
864
865
866
867
868
869
    end

    context 'with explicit sha' do
      subject { project.pipeline_for('master', pipeline.sha) }

      it_behaves_like 'giving the correct pipeline'
    end

    context 'with implicit sha' do
      subject { project.pipeline_for('master') }

      it_behaves_like 'giving the correct pipeline'
    end
Kamil Trzcinski's avatar
Kamil Trzcinski committed
870

871
872
873
874
875
    def create_pipeline
      create(:ci_pipeline,
             project: project,
             ref: 'master',
             sha: project.commit('master').sha)
Kamil Trzcinski's avatar
Kamil Trzcinski committed
876
    end
877
  end
878

879
  describe '#builds_enabled' do
880
    let(:project) { create(:empty_project) }
881

882
883
884
    subject { project.builds_enabled }

    it { expect(project.builds_enabled?).to be_truthy }
885
  end
886

887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
  describe '.with_shared_runners' do
    subject { Project.with_shared_runners }

    context 'when shared runners are enabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: true) }

      it "returns a project" do
        is_expected.to eq([project])
      end
    end

    context 'when shared runners are disabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: false) }

      it "returns an empty array" do
        is_expected.to be_empty
      end
    end
  end

907
908
909
910
911
912
913
914
915
916
917
918
919
920
  describe '.cached_count', caching: true do
    let(:group)     { create(:group, :public) }
    let!(:project1) { create(:empty_project, :public, group: group) }
    let!(:project2) { create(:empty_project, :public, group: group) }

    it 'returns total project count' do
      expect(Project).to receive(:count).once.and_call_original

      3.times do
        expect(Project.cached_count).to eq(2)
      end
    end
  end

921
  describe '.trending' do
Felipe Artur's avatar
Felipe Artur committed
922
    let(:group)    { create(:group, :public) }
923
924
925
926
927
928
929
930
931
932
    let(:project1) { create(:empty_project, :public, group: group) }
    let(:project2) { create(:empty_project, :public, group: group) }

    before do
      2.times do
        create(:note_on_commit, project: project1)
      end

      create(:note_on_commit, project: project2)

933
      TrendingProject.refresh!
934
935
    end

936
    subject { described_class.trending.to_a }
937

938
939
    it 'sorts projects by the amount of notes in descending order' do
      expect(subject).to eq([project1, project2])
940
    end
941
942
943
944
945
946
947
948

    it 'does not take system notes into account' do
      10.times do
        create(:note_on_commit, project: project2, system: true)
      end

      expect(described_class.trending.to_a).to eq([project1, project2])
    end
949
  end
Yorick Peterse's avatar
Yorick Peterse committed
950
951

  describe '.visible_to_user' do
952
    let!(:project) { create(:empty_project, :private) }
Yorick Peterse's avatar
Yorick Peterse committed
953
954
955
956
957
958
    let!(:user)    { create(:user) }

    subject { described_class.visible_to_user(user) }

    describe 'when a user has access to a project' do
      before do
959
        project.add_user(user, Gitlab::Access::MASTER)
Yorick Peterse's avatar
Yorick Peterse committed
960
961
962
963
964
965
966
967
968
      end

      it { is_expected.to eq([project]) }
    end

    describe 'when a user does not have access to any projects' do
      it { is_expected.to eq([]) }
    end
  end
969

970
971
972
973
  context 'repository storage by default' do
    let(:project) { create(:empty_project) }

    before do
974
      storages = {
975
976
        'default' => { 'path' => 'tmp/tests/repositories' },
        'picked'  => { 'path' => 'tmp/tests/repositories' },
977
      }
978
979
980
      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
    end

981
982
983
984
985
    it 'picks storage from ApplicationSetting' do
      expect_any_instance_of(ApplicationSetting).to receive(:pick_repository_storage).and_return('picked')

      expect(project.repository_storage).to eq('picked')
    end
986
987
  end

988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
  context 'shared runners by default' do
    let(:project) { create(:empty_project) }

    subject { project.shared_runners_enabled }

    context 'are enabled' do
      before { stub_application_setting(shared_runners_enabled: true) }

      it { is_expected.to be_truthy }
    end

    context 'are disabled' do
      before { stub_application_setting(shared_runners_enabled: false) }

      it { is_expected.to be_falsey }
    end
  end

1006
  describe '#any_runners' do
1007
    let(:project) { create(:empty_project, shared_runners_enabled: shared_runners_enabled) }
1008
1009
    let(:specific_runner) { create(:ci_runner) }
    let(:shared_runner) { create(:ci_runner, :shared) }
1010
1011
1012

    context 'for shared runners disabled' do
      let(:shared_runners_enabled) { false }
1013

1014
      it 'has no runners available' do
1015
1016
        expect(project.any_runners?).to be_falsey
      end
1017

1018
      it 'has a specific runner' do
1019
        project.runners << specific_runner
1020
1021
        expect(project.any_runners?).to be_truthy
      end
1022

1023
      it 'has a shared runner, but they are prohibited to use' do
1024
1025
1026
        shared_runner
        expect(project.any_runners?).to be_falsey
      end
1027

1028
      it 'checks the presence of specific runner' do
1029
        project.runners << specific_runner
1030
1031
1032
        expect(project.any_runners? { |runner| runner == specific_runner }).to be_truthy
      end
    end
1033

1034
1035
    context 'for shared runners enabled' do
      let(:shared_runners_enabled) { true }
1036

1037
      it 'has a shared runner' do
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
        shared_runner
        expect(project.any_runners?).to be_truthy
      end

      it 'checks the presence of shared runner' do
        shared_runner
        expect(project.any_runners? { |runner| runner == shared_runner }).to be_truthy
      end
    end
  end
1048

1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
  describe '#shared_runners' do
    let!(:runner) { create(:ci_runner, :shared) }

    subject { project.shared_runners }

    context 'when shared runners are enabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: true) }

      it "returns a list of shared runners" do
        is_expected.to eq([runner])
      end
    end

    context 'when shared runners are disabled for project' do
      let!(:project) { create(:empty_project, shared_runners_enabled: false) }

      it "returns a empty list" do
        is_expected.to be_empty
      end
    end
  end

1071
  describe '#visibility_level_allowed?' do
1072
    let(:project) { create(:empty_project, :internal) }
1073
1074
1075
1076
1077
1078
1079
1080

    context 'when checking on non-forked project' do
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_truthy }
    end

    context 'when checking on forked project' do
1081
1082
      let(:project)        { create(:empty_project, :internal) }
      let(:forked_project) { create(:empty_project, forked_from_project: project) }
1083
1084
1085
1086
1087

      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PRIVATE)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::INTERNAL)).to be_truthy }
      it { expect(forked_project.visibility_level_allowed?(Gitlab::VisibilityLevel::PUBLIC)).to be_falsey }
    end
1088
  end
1089

1090
1091
1092
1093
1094
1095
  describe '#pages_deployed?' do
    let(:project) { create :empty_project }

    subject { project.pages_deployed? }

    context 'if public folder does exist' do
1096
      before { allow(Dir).to receive(:exist?).with(project.public_pages_path).and_return(true) }
1097
1098
1099
1100
1101
1102
1103
1104
1105

      it { is_expected.to be_truthy }
    end

    context "if public folder doesn't exist" do
      it { is_expected.to be_falsey }
    end
  end

1106
  describe '.search' do
1107
    let(:project) { create(:empty_project, description: 'kitten mittens') }
1108

1109
1110
1111
    it 'returns projects with a matching name' do
      expect(described_class.search(project.name)).to eq([project])
    end
1112

1113
1114
1115
    it 'returns projects with a partially matching name' do
      expect(described_class.search(project.name[0..2])).to eq([project])
    end
1116

1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
    it 'returns projects with a matching name regardless of the casing' do
      expect(described_class.search(project.name.upcase)).to eq([project])
    end

    it 'returns projects with a matching description' do
      expect(described_class.search(project.description)).to eq([project])
    end

    it 'returns projects with a partially matching description' do
      expect(described_class.search('kitten')).to eq([project])
    end

    it 'returns projects with a matching description regardless of the casing' do
      expect(described_class.search('KITTEN')).to eq([project])
    end

    it 'returns projects with a matching path' do
      expect(described_class.search(project.path)).to eq([project])
    end

    it 'returns projects with a partially matching path' do
      expect(described_class.search(project.path[0..2])).to eq([project])
    end

    it 'returns projects with a matching path regardless of the casing' do
      expect(described_class.search(project.path.upcase)).to eq([project])
    end

    it 'returns projects with a matching namespace name' do
      expect(described_class.search(project.namespace.name)).to eq([project])
    end

    it 'returns projects with a partially matching namespace name' do
      expect(described_class.search(project.namespace.name[0..2])).to eq([project])
    end

    it 'returns projects with a matching namespace name regardless of the casing' do
      expect(described_class.search(project.namespace.name.upcase)).to eq([project])
    end
Yorick Peterse's avatar