Skip to content
  • Nick Thomas's avatar
    Look at notes created just before merge when deciding if an MR can be reverted · d5a7ab226edf
    Nick Thomas authored
    On MySQL, at least, `Note#created_at` doesn't seem to store fractional seconds,
    while `MergeRequest::Metrics#merged_at` does. This breaks the optimization
    assumption that we only need to search for notes created *after* the MR has
    been merged.
    
    Unsynchronized system clocks also make this a dangerous assumption to make.
    
    Adding a minute of leeway still optimizes away most notes, but allows both
    cases to be handled more gracefully. If the system clocks are more than a
    minute out, we'll still be broken, of course.
    d5a7ab226edf