Skip to content
  • Yorick Peterse's avatar
    Fix setting share_with_group_lock · c5f0e09eb838
    Yorick Peterse authored
    Prior to this commit running
    Namespace#force_share_with_group_lock_on_descendants would result in
    updating _all_ namespaces in the namespaces table, not just the
    descendants. This is the result of ActiveRecord::Relation#update_all not
    taking into account the CTE. To work around this we use the CTE query as
    a sub-query instead of directly calling #update_all.
    
    To prevent this from happening the relations returned by
    Gitlab::GroupHierarchy are now marked as read-only, resulting in an
    error being raised when methods such as #update_all are used.
    
    Fortunately on GitLab.com our statement timeouts appear to have
    prevented this query from actually doing any damage other than causing
    a very large amount of dead tuples.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916
    c5f0e09eb838