Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
b2e83180cf3d
Commit
b2e83180
authored
Apr 28, 2016
by
Sean McGivern
Browse files
Don't auto-set MR title for confidential issues
parent
40275318e6c6
Changes
2
Hide whitespace changes
Inline
Side-by-side
app/services/merge_requests/build_service.rb
View file @
b2e83180
...
...
@@ -68,7 +68,7 @@
commit
=
commits
.
first
merge_request
.
title
=
commit
.
title
merge_request
.
description
||=
commit
.
description
.
try
(
:strip
)
elsif
iid
&&
(
issue
=
merge_request
.
target_project
.
get_issue
(
iid
))
elsif
iid
&&
(
issue
=
merge_request
.
target_project
.
get_issue
(
iid
))
&&
!
issue
.
try
(
:confidential?
)
case
issue
when
Issue
merge_request
.
title
=
"Resolve
\"
#{
issue
.
title
}
\"
"
...
...
spec/services/merge_requests/build_service_spec.rb
View file @
b2e83180
...
...
@@ -5,7 +5,8 @@
let
(
:project
)
{
create
(
:project
)
}
let
(
:user
)
{
create
(
:user
)
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
,
title:
'A bug'
)
}
let
(
:issue_confidential
)
{
false
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
,
title:
'A bug'
,
confidential:
issue_confidential
)
}
let
(
:description
)
{
nil
}
let
(
:source_branch
)
{
'feature-branch'
}
let
(
:target_branch
)
{
'master'
}
...
...
@@ -156,6 +157,14 @@
expect
(
merge_request
.
title
).
to
eq
(
"
#{
issue
.
iid
.
succ
}
fix issue"
)
end
end
context
'issue is confidential'
do
let
(
:issue_confidential
)
{
true
}
it
'uses the title of the branch as the merge request title'
do
expect
(
merge_request
.
title
).
to
eq
(
"
#{
issue
.
iid
}
fix issue"
)
end
end
end
context
'branch starts with external issue IID followed by a hyphen'
do
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment