Read about our upcoming Code of Conduct on this issue

Commit 19c7133d authored by George Tsiolis's avatar George Tsiolis
Browse files

Fix typos in comments and specs

parent 0360938132ae
......@@ -24,7 +24,7 @@ def trace(ab_position)
# head of `feature` was commit B, resulting in the original diff A->B.
# Since creation, `master` was updated to C.
# Now `feature` is being updated to D, and the newly generated MR diff is C->D.
# It is possible that C and D are direct decendants of A and B respectively,
# It is possible that C and D are direct descendants of A and B respectively,
# but this isn't necessarily the case as rebases and merges come into play.
#
# Suppose we have a diff note on the original diff A->B. Now that the MR
......
......@@ -349,7 +349,7 @@ def gitaly_fetch_stream_to_file(save_path, rpc_name, request_class, timeout)
f.write(message.data)
end
end
# If the file is empty means that we recieved an empty stream, we delete the file
# If the file is empty means that we received an empty stream, we delete the file
FileUtils.rm(save_path) if File.zero?(save_path)
end
......
......@@ -154,7 +154,7 @@ def create_sub_relations(relation, tree_hash, save: true)
Project.transaction do
process_sub_relation(relation, relation_item)
# For every subrelation that hangs from Project, save the associated records alltogether
# For every subrelation that hangs from Project, save the associated records altogether
# This effectively batches all records per subrelation item, only keeping those in memory
# We have to keep in mind that more batch granularity << Memory, but >> Slowness
if save
......
......@@ -236,7 +236,7 @@ def git_reference_regex
def single_line_regexp(regex)
# Turns a multiline extended regexp into a single line one,
# beacuse `rake routes` breaks on multiline regexes.
# because `rake routes` breaks on multiline regexes.
Regexp.new(regex.source.gsub(/\(\?#.+?\)/, '').gsub(/\s*/, ''), regex.options ^ Regexp::EXTENDED).freeze
end
end
......
......@@ -4,7 +4,7 @@
# of the global setting allow_local_requests_from_hooks_and_services this adapter
# will allow/block connection to internal IPs and/or urls.
#
# This functionality can be overriden by providing the setting the option
# This functionality can be overridden by providing the setting the option
# allow_local_requests = true in the request. For example:
# Gitlab::HTTP.get('http://www.gitlab.com', allow_local_requests: true)
#
......
......@@ -3,7 +3,7 @@ module SlashCommands
class IssueNew < IssueCommand
def self.match(text)
# we can not match \n with the dot by passing the m modifier as than
# the title and description are not seperated
# the title and description are not separated
/\Aissue\s+(new|create)\s+(?<title>[^\n]*)\n*(?<description>(.|\n)*)/.match(text)
end
......
# frozen_string_literal: true
# This class extracts all users found in a piece of text by the username or the
# email adress
# email address
module Gitlab
class UserExtractor
......
......@@ -16,7 +16,7 @@ def authorize_url
client.auth_code.authorize_url(
redirect_uri: redirect_uri,
scope: scope,
state: state # This is used for arbitary redirection
state: state # This is used for arbitrary redirection
)
end
......
......@@ -32,32 +32,32 @@ module Trigger
private
# Must be overriden
# Must be overridden
def downstream_project_path
raise NotImplementedError
end
# Must be overriden
# Must be overridden
def ref
raise NotImplementedError
end
# Must be overriden
# Must be overridden
def trigger_token
raise NotImplementedError
end
# Must be overriden
# Must be overridden
def access_token
raise NotImplementedError
end
# Can be overriden
# Can be overridden
def extra_variables
{}
end
# Can be overriden
# Can be overridden
def version_param_value(version_file)
File.read(version_file).strip
end
......
......@@ -63,7 +63,7 @@
let(:group_milestone) { create(:milestone, group: group) }
context 'when there is a title parameter' do
it 'searchs for a legacy group milestone' do
it 'searches for a legacy group milestone' do
expect(GlobalMilestone).to receive(:build)
expect(Milestone).not_to receive(:find_by_iid)
......@@ -72,7 +72,7 @@
end
context 'when there is not a title parameter' do
it 'searchs for a group milestone' do
it 'searches for a group milestone' do
expect(GlobalMilestone).not_to receive(:build)
expect(Milestone).to receive(:find_by_iid)
......
......@@ -529,7 +529,7 @@ def group_moved_message(redirect_route, group)
sign_in(user)
end
context 'when transfering to a subgroup goes right' do
context 'when transferring to a subgroup goes right' do
let(:new_parent_group) { create(:group, :public) }
let!(:group_member) { create(:group_member, :owner, group: group, user: user) }
let!(:new_parent_group_member) { create(:group_member, :owner, group: new_parent_group, user: user) }
......
......@@ -4,7 +4,7 @@
let(:user) { create(:user) }
describe "#get_keys" do
describe "non existant user" do
describe "non existent user" do
it "does not generally work" do
get :get_keys, username: 'not-existent'
......
......@@ -216,7 +216,7 @@
expect(response).to have_gitlab_http_status(200)
end
it 'loads the terminals for the enviroment' do
it 'loads the terminals for the environment' do
expect_any_instance_of(Environment).to receive(:terminals)
get :terminal, environment_params
......
......@@ -786,7 +786,7 @@ def post_assign_issues
merge_request.mark_as_merged!
end
it 'returns the enviroment on the source project' do
it 'returns the environment on the source project' do
get_ci_environments_status(environment_target: 'merge_commit')
expect(response).to have_gitlab_http_status(:ok)
......
......@@ -33,7 +33,7 @@
expect(page).not_to have_content(project.name)
end
it 'searchs archived projects', :js do
it 'searches archived projects', :js do
click_button 'Last updated'
click_link 'Show archived projects'
......
......@@ -22,7 +22,7 @@
expect(page).to have_content('https://android-review.googlesource.com/platform/build/blueprint')
end
it 'imports succesfully imports a project' do
it 'imports successfully imports a project' do
visit new_import_manifest_path
attach_file('manifest', Rails.root.join('spec/fixtures/aosp_manifest.xml'))
......
......@@ -15,7 +15,7 @@
wait_for_requests
end
it 'updates issue descripton with GFM reference' do
it 'updates issue description with GFM reference' do
find('.js-issuable-edit').click
simulate_input('#issue-description', "@#{user.name[0...3]}")
......
......@@ -19,7 +19,7 @@
let!(:pipeline) { create(:ci_empty_pipeline, project: project, ref: ref, sha: project.commit(ref).sha) }
let!(:job) { create(:ci_build, pipeline: pipeline) }
context 'when the pipeline was successfull' do
context 'when the pipeline was successful' do
it 'displays so on the badge' do
job.success
......
......@@ -40,7 +40,7 @@
expect(page).to have_selector('.js-project-feature-toggle')
end
context 'with sucessfull request' do
context 'with successful request' do
it 'user sees updated cluster' do
expect do
page.find('.js-project-feature-toggle').click
......
......@@ -16,7 +16,7 @@
sign_in(user)
end
context 'without commiting a new file' do
context 'without committing a new file' do
context 'when an user has write access' do
before do
visit(project_tree_path_root_ref)
......@@ -49,7 +49,7 @@
end
end
context 'with commiting a new file' do
context 'with committing a new file' do
context 'when an user has write access' do
before do
visit(project_tree_path_root_ref)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment