Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
9cfd12191dae
Unverified
Commit
2f0f62e5
authored
Nov 02, 2017
by
Nick Thomas
Browse files
Remove an exception from the git user default SSH config check
parent
f19c31f2f021
Changes
2
Hide whitespace changes
Inline
Side-by-side
lib/system_check/app/git_user_default_ssh_config_check.rb
View file @
9cfd1219
...
...
@@ -11,10 +11,10 @@ class GitUserDefaultSSHConfigCheck < SystemCheck::BaseCheck
]
.
freeze
set_name
'Git user has default SSH configuration?'
set_skip_reason
'skipped (
GitLab read-only, or
git user is not present / configured)'
set_skip_reason
'skipped (git user is not present / configured)'
def
skip?
Gitlab
::
Database
.
read_only?
||
!
home_dir
||
!
File
.
directory?
(
home_dir
)
!
home_dir
||
!
File
.
directory?
(
home_dir
)
end
def
check?
...
...
spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb
View file @
9cfd1219
...
...
@@ -39,14 +39,6 @@
it
{
is_expected
.
to
eq
(
expected_result
)
}
end
it
'skips GitLab read-only instances'
do
stub_user
stub_home_dir
allow
(
Gitlab
::
Database
).
to
receive
(
:read_only?
).
and_return
(
true
)
is_expected
.
to
be_truthy
end
end
describe
'#check?'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment