Read about our upcoming Code of Conduct on this issue

Commit 2f9380d5 authored by Sergey Sinev's avatar Sergey Sinev Committed by Stan Hu
Browse files

Fix error when deleting an empty list of refs

Closes #45743
parent db2fb87f70a0
---
title: Fix error when deleting an empty list of refs
merge_request:
author:
type: fixed
......@@ -2346,7 +2346,7 @@ def git_delete_refs(*ref_names)
end
def gitaly_delete_refs(*ref_names)
gitaly_ref_client.delete_refs(refs: ref_names)
gitaly_ref_client.delete_refs(refs: ref_names) if ref_names.any?
end
def rugged_remove_remote(remote_name)
......
......@@ -600,6 +600,10 @@ def submodule_url(path)
end
end
it 'does not fail when deleting an empty list of refs' do
expect { repo.delete_refs(*[]) }.not_to raise_error
end
it 'raises an error if it failed' do
expect { repo.delete_refs('refs\heads\fix') }.to raise_error(Gitlab::Git::Repository::GitError)
end
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment