Read about our upcoming Code of Conduct on this issue

Commit 45824aab authored by Robert Speicher's avatar Robert Speicher
Browse files

Allow non-admin users to see version information

We want users to know what features they have available (and to pressure
their admins to upgrade).
parent 0c6bfeaf68bb
......@@ -2,7 +2,7 @@
%h1
GitLab
Community Edition
- if current_user && current_user.admin?
- if user_signed_in?
%span= Gitlab::VERSION
%small= Gitlab::REVISION
= version_status_badge
......
......@@ -3,18 +3,7 @@
describe 'help/index' do
describe 'version information' do
it 'is hidden from guests' do
stub_user
stub_version('8.0.2', 'abcdefg')
stub_helpers
render
expect(rendered).not_to match '8.0.2'
expect(rendered).not_to match 'abcdefg'
end
it 'is hidden from users' do
stub_user(admin?: false)
stub_user(nil)
stub_version('8.0.2', 'abcdefg')
stub_helpers
......@@ -24,8 +13,8 @@
expect(rendered).not_to match 'abcdefg'
end
it 'is shown to admins' do
stub_user(admin?: true)
it 'is shown to users' do
stub_user
stub_version('8.0.2', 'abcdefg')
stub_helpers
......@@ -36,10 +25,8 @@
end
end
def stub_user(messages = {})
user = messages.empty? ? nil : double(messages)
allow(view).to receive(:current_user).and_return(user)
def stub_user(user = double)
allow(view).to receive(:user_signed_in?).and_return(user)
end
def stub_version(version, revision)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment