Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
ed2d3d13bb2f
Commit
528f90b4
authored
Sep 13, 2017
by
Brandon Everett
Committed by
Rémy Coutable
Sep 13, 2017
Browse files
escape characters in git user name
parent
bddce755c5f6
Changes
3
Hide whitespace changes
Inline
Side-by-side
app/helpers/projects_helper.rb
View file @
ed2d3d13
...
...
@@ -320,7 +320,7 @@ def project_lfs_status(project)
def
git_user_name
if
current_user
current_user
.
name
current_user
.
name
.
gsub
(
'"'
,
'\"'
)
else
_
(
"Your name"
)
end
...
...
changelogs/unreleased/18308-escape-characters.yml
0 → 100644
View file @
ed2d3d13
---
title
:
Escape quotes in git username
merge_request
:
14020
author
:
Brandon Everett
type
:
fixed
spec/helpers/projects_helper_spec.rb
View file @
ed2d3d13
...
...
@@ -469,4 +469,15 @@
expect
(
recorder
.
count
).
to
eq
(
1
)
end
end
describe
'#git_user_name'
do
let
(
:user
)
{
double
(
:user
,
name:
'John "A" Doe53'
)
}
before
do
allow
(
helper
).
to
receive
(
:current_user
).
and_return
(
user
)
end
it
'parses quotes in name'
do
expect
(
helper
.
send
(
:git_user_name
)).
to
eq
(
'John \"A\" Doe53'
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment