Commit 528f90b4 authored by Brandon Everett's avatar Brandon Everett Committed by Rémy Coutable
Browse files

escape characters in git user name

parent bddce755c5f6
......@@ -320,7 +320,7 @@ def project_lfs_status(project)
def git_user_name
if current_user
current_user.name
current_user.name.gsub('"', '\"')
else
_("Your name")
end
......
---
title: Escape quotes in git username
merge_request: 14020
author: Brandon Everett
type: fixed
......@@ -469,4 +469,15 @@
expect(recorder.count).to eq(1)
end
end
describe '#git_user_name' do
let(:user) { double(:user, name: 'John "A" Doe53') }
before do
allow(helper).to receive(:current_user).and_return(user)
end
it 'parses quotes in name' do
expect(helper.send(:git_user_name)).to eq('John \"A\" Doe53')
end
end
end
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment