Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
93020d7cd9c2
Commit
562d78a6
authored
Jul 12, 2015
by
Nikita Verkhovin
Browse files
Add error message for SSH key linebreaks
parent
e9ba57c6777c
Changes
3
Hide whitespace changes
Inline
Side-by-side
CHANGELOG
View file @
93020d7c
...
...
@@ -43,6 +43,7 @@ v 7.13.0 (unreleased)
- Redesign project page. Show README as default instead of activity. Move project activity to separate page
- Make left menu more hierarchical and less contextual by adding back item at top
- A fork can’t have a visibility level that is greater than the original project.
- Add error message for SSH key linebreaks
v 7.12.2
- Correctly show anonymous authorized applications under Profile > Applications.
...
...
app/models/key.rb
View file @
93020d7c
...
...
@@ -24,6 +24,7 @@ class Key < ActiveRecord::Base
validates
:title
,
presence:
true
,
length:
{
within:
0
..
255
}
validates
:key
,
presence:
true
,
length:
{
within:
0
..
5000
},
format:
{
with:
/\A(ssh|ecdsa)-.*\Z/
},
uniqueness:
true
validates
:key
,
format:
{
without:
/\n|\r/
,
message:
'should be a single line'
}
validates
:fingerprint
,
uniqueness:
true
,
presence:
{
message:
'cannot be generated'
}
delegate
:name
,
:email
,
to: :user
,
prefix:
true
...
...
spec/models/key_spec.rb
View file @
93020d7c
...
...
@@ -63,7 +63,7 @@
key
=
build
(
:key
)
# Not always the middle, but close enough
key
.
key
=
key
.
key
[
0
..
100
]
+
' '
+
key
.
key
[
10
0
..-
1
]
key
.
key
=
key
.
key
[
0
..
100
]
+
' '
+
key
.
key
[
10
1
..-
1
]
expect
(
key
).
not_to
be_valid
end
...
...
@@ -71,6 +71,12 @@
it
'rejects the unfingerprintable key (not a key)'
do
expect
(
build
(
:key
,
key:
'ssh-rsa an-invalid-key=='
)).
not_to
be_valid
end
it
'rejects the multiple line key'
do
key
=
build
(
:key
)
key
.
key
.
gsub!
(
' '
,
"
\n
"
)
expect
(
key
).
not_to
be_valid
end
end
context
'callbacks'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment