Commit 5bf22606 authored by Douwe Maan's avatar Douwe Maan
Browse files

Fix XSS issue by not using URI.join

parent 7708db6a2cf5
......@@ -185,8 +185,7 @@ def external_url_for(path, commit_sha)
public_path = project.public_path_for_source_path(path, commit_sha)
return unless public_path
# TODO: Verify this can't be used for XSS
URI.join(external_url, public_path).to_s
[external_url, public_path].join('/')
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment