Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
242487277e20
Commit
24248727
authored
Oct 20, 2017
by
Clement Ho
Browse files
Use title as placeholder instead of issue title for reusability
parent
bf9016995ece
Changes
4
Hide whitespace changes
Inline
Side-by-side
app/assets/javascripts/issue_show/components/fields/title.vue
View file @
24248727
...
...
@@ -16,7 +16,7 @@
<fieldset>
<label
class=
"sr-only"
for=
"issue-title"
>
for=
"issu
abl
e-title"
>
Title
</label>
<input
...
...
@@ -20,6 +20,6 @@
Title
</label>
<input
id=
"issue-title"
id=
"issu
abl
e-title"
class=
"form-control"
type=
"text"
...
...
@@ -24,7 +24,7 @@
class=
"form-control"
type=
"text"
placeholder=
"
Issue t
itle"
aria-label=
"
Issue t
itle"
placeholder=
"
T
itle"
aria-label=
"
T
itle"
v-model=
"formState.title"
@
keydown.meta.enter=
"updateIssuable"
@
keydown.ctrl.enter=
"updateIssuable"
/>
...
...
changelogs/unreleased/use-title.yml
0 → 100644
View file @
24248727
---
title
:
Use title as placeholder instead of issue title for reusability
merge_request
:
author
:
type
:
other
spec/features/issues/issue_detail_spec.rb
View file @
24248727
...
...
@@ -25,7 +25,7 @@
wait_for_requests
click_link
'Edit'
fill_in
'issue-title'
,
with:
'issue title'
fill_in
'issu
abl
e-title'
,
with:
'issue title'
click_button
'Save'
Users
::
DestroyService
.
new
(
user
).
execute
(
user
)
...
...
spec/features/projects/issuable_templates_spec.rb
View file @
24248727
...
...
@@ -35,7 +35,7 @@
page
.
within
(
'.content .issuable-actions'
)
do
click_on
'Edit'
end
fill_in
:'issue-title'
,
with:
'test issue title'
fill_in
:'issu
abl
e-title'
,
with:
'test issue title'
end
scenario
'user selects "bug" template'
do
...
...
@@ -80,7 +80,7 @@
page
.
within
(
'.content .issuable-actions'
)
do
click_on
'Edit'
end
fill_in
:'issue-title'
,
with:
'test issue title'
fill_in
:'issu
abl
e-title'
,
with:
'test issue title'
fill_in
:'issue-description'
,
with:
prior_description
end
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment