Commit 65081a57 authored by Reuben Pereira's avatar Reuben Pereira
Browse files

Remove the restriction preventing project references with text adjacent to the > character

parent 6a84b2a4e5c8
...@@ -465,14 +465,12 @@ def reference_postfix_escaped ...@@ -465,14 +465,12 @@ def reference_postfix_escaped
end end
# Pattern used to extract `namespace/project>` project references from text. # Pattern used to extract `namespace/project>` project references from text.
# (?!\w) matches any non-word character.
# '>' or its escaped form ('>') are checked for because '>' is sometimes escaped # '>' or its escaped form ('>') are checked for because '>' is sometimes escaped
# when the reference comes from an external source. # when the reference comes from an external source.
def markdown_reference_pattern def markdown_reference_pattern
%r{ %r{
#{reference_pattern} #{reference_pattern}
(#{reference_postfix}|#{reference_postfix_escaped}) (#{reference_postfix}|#{reference_postfix_escaped})
(?!\w)
}x }x
end end
......
...@@ -24,9 +24,9 @@ def get_reference(project) ...@@ -24,9 +24,9 @@ def get_reference(project)
expect(reference_filter(act).to_html).to eq(CGI.escapeHTML(exp)) expect(reference_filter(act).to_html).to eq(CGI.escapeHTML(exp))
end end
it 'ignores references with text after the > sign' do it 'allows references with text after the > character' do
exp = act = "Hey #{reference}foo" doc = reference_filter("Hey #{reference}foo")
expect(reference_filter(act).to_html).to eq CGI.escapeHTML(exp) expect(doc.css('a').first.attr('href')).to eq urls.project_url(subject)
end end
%w(pre code a style).each do |elem| %w(pre code a style).each do |elem|
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment