Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
0f91fcfe4df7
Commit
65989141
authored
Jun 20, 2012
by
Robb Kidd
Browse files
Protect IssueObserver#send_reassigned_email method.
parent
1180c79ef944
Changes
2
Hide whitespace changes
Inline
Side-by-side
app/models/issue_observer.rb
View file @
0f91fcfe
...
...
@@ -11,6 +11,8 @@ def after_update(issue)
Note
.
create_status_change_note
(
issue
,
current_user
,
'reopened'
)
if
issue
.
is_being_reopened?
end
protected
def
send_reassigned_email
(
issue
)
recipient_ids
=
[
issue
.
assignee_id
,
issue
.
assignee_id_was
].
keep_if
{
|
id
|
id
!=
current_user
.
id
}
...
...
spec/models/issue_observer_spec.rb
View file @
0f91fcfe
...
...
@@ -121,7 +121,7 @@ def it_does_not_send_a_reassigned_email_to(recipient)
it_sends_a_reassigned_email_to
assignee
.
id
it_sends_a_reassigned_email_to
previous_assignee
.
id
subject
.
send_reassigned_email
(
issue
)
subject
.
send
(
:send
_reassigned_email
,
issue
)
end
context
'does not send an email to the user who made the reassignment'
do
...
...
@@ -130,14 +130,14 @@ def it_does_not_send_a_reassigned_email_to(recipient)
it_sends_a_reassigned_email_to
previous_assignee
.
id
it_does_not_send_a_reassigned_email_to
assignee
.
id
subject
.
send_reassigned_email
(
issue
)
subject
.
send
(
:send
_reassigned_email
,
issue
)
end
it
'if the user is the previous assignee'
do
subject
.
stub
(
:current_user
).
and_return
(
previous_assignee
)
it_sends_a_reassigned_email_to
assignee
.
id
it_does_not_send_a_reassigned_email_to
previous_assignee
.
id
subject
.
send_reassigned_email
(
issue
)
subject
.
send
(
:send
_reassigned_email
,
issue
)
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment