Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
465bd454593e
Commit
694f31dd
authored
May 08, 2017
by
Grzegorz Bizon
Browse files
Fix skipped manual actions issue in pipeline processing
parent
254d43626ad3
Changes
3
Hide whitespace changes
Inline
Side-by-side
app/services/ci/process_pipeline_service.rb
View file @
465bd454
...
...
@@ -50,7 +50,7 @@ def valid_statuses_for_when(value)
when
'always'
%w[success failed skipped]
when
'manual'
%w[success]
%w[success
skipped
]
else
[]
end
...
...
changelogs/unreleased/fix-gb-fix-skipped-manual-actions.yml
0 → 100644
View file @
465bd454
---
title
:
Fix skipped manual actions problem when processing the pipeline
merge_request
:
11164
author
:
spec/services/ci/process_pipeline_service_spec.rb
View file @
465bd454
...
...
@@ -268,6 +268,24 @@
end
end
context
'when there are only manual actions in stages'
do
before
do
create_build
(
'image'
,
stage_idx:
0
,
when:
'manual'
,
allow_failure:
true
)
create_build
(
'build'
,
stage_idx:
1
,
when:
'manual'
,
allow_failure:
true
)
create_build
(
'deploy'
,
stage_idx:
2
,
when:
'manual'
)
create_build
(
'check'
,
stage_idx:
3
)
process_pipeline
end
it
'processes all jobs until blocking actions encountered'
do
expect
(
all_builds_statuses
).
to
eq
(
%w[manual manual manual created]
)
expect
(
all_builds_names
).
to
eq
(
%w[image build deploy check]
)
expect
(
pipeline
.
reload
).
to
be_blocked
end
end
context
'when blocking manual actions are defined'
do
before
do
create_build
(
'code:test'
,
stage_idx:
0
)
...
...
@@ -441,6 +459,10 @@ def builds_names
builds
.
pluck
(
:name
)
end
def
all_builds_names
all_builds
.
pluck
(
:name
)
end
def
builds_statuses
builds
.
pluck
(
:status
)
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment