Commit 89225375 authored by Mike Greiling's avatar Mike Greiling
Browse files

migrate notebook_viewer to dynamic import

parent 1dfa0fffc9ac
import renderNotebook from './notebook'; import renderNotebook from './notebook';
document.addEventListener('DOMContentLoaded', renderNotebook); export default renderNotebook;
...@@ -32,6 +32,9 @@ export default class BlobViewer { ...@@ -32,6 +32,9 @@ export default class BlobViewer {
case 'balsamiq': case 'balsamiq':
initViewer(import(/* webpackChunkName: 'balsamiq_viewer' */ '../balsamiq_viewer')); initViewer(import(/* webpackChunkName: 'balsamiq_viewer' */ '../balsamiq_viewer'));
break; break;
case 'notebook':
initViewer(import(/* webpackChunkName: 'notebook_viewer' */ '../notebook_viewer'));
break;
default: default:
break; break;
} }
......
- content_for :page_specific_javascripts do
= webpack_bundle_tag('common_vue')
= webpack_bundle_tag('notebook_viewer')
.file-content#js-notebook-viewer{ data: { endpoint: blob_raw_path } } .file-content#js-notebook-viewer{ data: { endpoint: blob_raw_path } }
...@@ -45,7 +45,6 @@ function generateEntries() { ...@@ -45,7 +45,6 @@ function generateEntries() {
const manualEntries = { const manualEntries = {
monitoring: './monitoring/monitoring_bundle.js', monitoring: './monitoring/monitoring_bundle.js',
mr_notes: './mr_notes/index.js', mr_notes: './mr_notes/index.js',
notebook_viewer: './blob/notebook_viewer.js',
pdf_viewer: './blob/pdf_viewer.js', pdf_viewer: './blob/pdf_viewer.js',
protected_branches: './protected_branches', protected_branches: './protected_branches',
registry_list: './registry/index.js', registry_list: './registry/index.js',
...@@ -225,7 +224,6 @@ const config = { ...@@ -225,7 +224,6 @@ const config = {
chunks: [ chunks: [
'monitoring', 'monitoring',
'mr_notes', 'mr_notes',
'notebook_viewer',
'pdf_viewer', 'pdf_viewer',
'registry_list', 'registry_list',
'ide', 'ide',
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment