Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
b995baa3133a
Commit
89225375
authored
Mar 01, 2018
by
Mike Greiling
Browse files
migrate notebook_viewer to dynamic import
parent
1dfa0fffc9ac
Changes
4
Show whitespace changes
Inline
Side-by-side
app/assets/javascripts/blob/notebook_viewer.js
View file @
b995baa3
import
renderNotebook
from
'
./notebook
'
;
document
.
addEventListener
(
'
DOMContentLoaded
'
,
renderNotebook
)
;
export
default
renderNotebook
;
app/assets/javascripts/blob/viewer/index.js
View file @
b995baa3
...
...
@@ -32,6 +32,9 @@ export default class BlobViewer {
case
'
balsamiq
'
:
initViewer
(
import
(
/* webpackChunkName: 'balsamiq_viewer' */
'
../balsamiq_viewer
'
));
break
;
case
'
notebook
'
:
initViewer
(
import
(
/* webpackChunkName: 'notebook_viewer' */
'
../notebook_viewer
'
));
break
;
default
:
break
;
}
...
...
app/views/projects/blob/viewers/_notebook.html.haml
View file @
b995baa3
-
content_for
:page_specific_javascripts
do
=
webpack_bundle_tag
(
'common_vue'
)
=
webpack_bundle_tag
(
'notebook_viewer'
)
.file-content
#js-notebook-viewer
{
data:
{
endpoint:
blob_raw_path
}
}
config/webpack.config.js
View file @
b995baa3
...
...
@@ -45,7 +45,6 @@ function generateEntries() {
const
manualEntries
=
{
monitoring
:
'
./monitoring/monitoring_bundle.js
'
,
mr_notes
:
'
./mr_notes/index.js
'
,
notebook_viewer
:
'
./blob/notebook_viewer.js
'
,
pdf_viewer
:
'
./blob/pdf_viewer.js
'
,
protected_branches
:
'
./protected_branches
'
,
registry_list
:
'
./registry/index.js
'
,
...
...
@@ -225,7 +224,6 @@ const config = {
chunks
:
[
'
monitoring
'
,
'
mr_notes
'
,
'
notebook_viewer
'
,
'
pdf_viewer
'
,
'
registry_list
'
,
'
ide
'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment