Commit a37427f6 authored by Bob Van Landuyt's avatar Bob Van Landuyt
Browse files

Adjust openid_connect_spec to use `raise_error`

Using the `raise_error`-matcher instead of `throw_symbol` makes sure
our after blocks get called in the test suite.
parent fcebae93c37f
...@@ -107,6 +107,15 @@ def hashed_subject ...@@ -107,6 +107,15 @@ def hashed_subject
end end
end end
# These 2 calls shouldn't actually throw, they should be handled as an
# unauthorized request, so we should be able to check the response.
#
# This was not possible due to an issue with Warden:
# https://github.com/hassox/warden/pull/162
#
# When the patch gets merged and we update Warden, these specs will need to
# updated to check the response instead of a raised exception.
# https://gitlab.com/gitlab-org/gitlab-ce/issues/40218
context 'when user is blocked' do context 'when user is blocked' do
it 'returns authentication error' do it 'returns authentication error' do
access_grant access_grant
...@@ -114,7 +123,7 @@ def hashed_subject ...@@ -114,7 +123,7 @@ def hashed_subject
expect do expect do
request_access_token request_access_token
end.to throw_symbol :warden end.to raise_error UncaughtThrowError
end end
end end
...@@ -125,7 +134,7 @@ def hashed_subject ...@@ -125,7 +134,7 @@ def hashed_subject
expect do expect do
request_access_token request_access_token
end.to throw_symbol :warden end.to raise_error UncaughtThrowError
end end
end end
end end
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment