Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
21ea3b244097
Commit
b4dbc306
authored
Sep 07, 2017
by
Pawel Chojnacki
Browse files
Guard metrics creation with a mutex
parent
69833f00029e
Changes
1
Hide whitespace changes
Inline
Side-by-side
lib/gitlab/metrics/prometheus.rb
View file @
21ea3b24
...
...
@@ -5,6 +5,9 @@ module Metrics
module
Prometheus
include
Gitlab
::
CurrentSettings
REGISTRY_MUTEX
=
Mutex
.
new
PROVIDER_MUTEX
=
Mutex
.
new
def
metrics_folder_present?
multiprocess_files_dir
=
::
Prometheus
::
Client
.
configuration
.
multiprocess_files_dir
...
...
@@ -20,23 +23,38 @@ def prometheus_metrics_enabled?
end
def
registry
@registry
||=
::
Prometheus
::
Client
.
registry
return
@registry
if
@registry
REGISTRY_MUTEX
.
synchronize
do
@registry
||=
::
Prometheus
::
Client
.
registry
end
end
def
counter
(
name
,
docstring
,
base_labels
=
{})
provide_metric
(
name
)
||
registry
.
counter
(
name
,
docstring
,
base_labels
)
safe_
provide_metric
(
:
counter
,
name
,
docstring
,
base_labels
)
end
def
summary
(
name
,
docstring
,
base_labels
=
{})
provide_metric
(
name
)
||
registry
.
summary
(
name
,
docstring
,
base_labels
)
safe_
provide_metric
(
:
summary
,
name
,
docstring
,
base_labels
)
end
def
gauge
(
name
,
docstring
,
base_labels
=
{},
multiprocess_mode
=
:all
)
provide_metric
(
name
)
||
registry
.
gauge
(
name
,
docstring
,
base_labels
,
multiprocess_mode
)
safe_
provide_metric
(
:
gauge
,
name
,
docstring
,
base_labels
,
multiprocess_mode
)
end
def
histogram
(
name
,
docstring
,
base_labels
=
{},
buckets
=
::
Prometheus
::
Client
::
Histogram
::
DEFAULT_BUCKETS
)
provide_metric
(
name
)
||
registry
.
histogram
(
name
,
docstring
,
base_labels
,
buckets
)
safe_provide_metric
(
:histogram
,
name
,
docstring
,
base_labels
,
buckets
)
end
private
def
safe_provide_metric
(
method
,
name
,
*
args
)
metric
=
provide_metric
(
name
)
return
metric
if
metric
PROVIDER_MUTEX
.
synchronize
do
provide_metric
(
name
)
||
registry
.
send
(
method
,
*
args
)
end
end
def
provide_metric
(
name
)
...
...
@@ -47,8 +65,6 @@ def provide_metric(name)
end
end
private
def
prometheus_metrics_enabled_unmemoized
metrics_folder_present?
&&
current_application_settings
[
:prometheus_metrics_enabled
]
||
false
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment