Read about our upcoming Code of Conduct on this issue

This instance will be upgraded to Heptapod 0.28.0 on 2022-01-18 at 14:00 UTC+1 (a few minutes of down time)

Commit c7c4d657 authored by Stan Hu's avatar Stan Hu
Browse files

Clean up Bitbucket connection based on review comments

parent 6391cde28f41
module Bitbucket
class Client
def initialize(options = {})
@connection = options.fetch(:connection, Connection.new(options))
@connection = Connection.new(options)
end
def issues(repo)
......
......@@ -7,12 +7,12 @@ class Connection
def initialize(options = {})
@api_version = options.fetch(:api_version, DEFAULT_API_VERSION)
@base_uri = options.fetch(:base_uri, DEFAULT_BASE_URI)
@query = options.fetch(:query, DEFAULT_QUERY)
@default_query = options.fetch(:query, DEFAULT_QUERY)
@token = options.fetch(:token)
@expires_at = options.fetch(:expires_at)
@expires_in = options.fetch(:expires_in)
@refresh_token = options.fetch(:refresh_token)
@token = options[:token]
@expires_at = options[:expires_at]
@expires_in = options[:expires_in]
@refresh_token = options[:refresh_token]
end
def client
......@@ -24,13 +24,13 @@ def connection
end
def query(params = {})
@query.merge!(params)
@default_query.merge!(params)
end
def get(path, query = {})
def get(path, extra_query = {})
refresh! if expired?
response = connection.get(build_url(path), params: @query.merge(query))
response = connection.get(build_url(path), params: @default_query.merge(extra_query))
response.parsed
end
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment