Read about our upcoming Code of Conduct on this issue

Commit df97e21c authored by George Andrinopoulos's avatar George Andrinopoulos Committed by Rémy Coutable
Browse files

Rebase to master for avoiding failing tests

parent 1a19db07ae9f
title: Add all available statuses to scope filter for project builds endpoint
author: George Andrinopoulos
......@@ -11,7 +11,7 @@ class Builds < Grape::API
helpers do
params :optional_scope do
optional :scope, types: [String, Array[String]], desc: 'The scope of builds to show',
values: ['pending', 'running', 'failed', 'success', 'canceled'],
values: ::CommitStatus::AVAILABLE_STATUSES,
coerce_with: ->(scope) {
if scope.is_a?(String)
......@@ -16,6 +16,8 @@
let(:query) { '' }
before do
create(:ci_build, :skipped, pipeline: pipeline)
get api("/projects/#{}/builds?#{query}", api_user)
......@@ -49,6 +51,18 @@
context 'filter project with scope skipped' do
let(:query) { 'scope=skipped' }
let(:json_build) { json_response.first }
it 'return builds with status skipped' do
expect(response).to have_http_status 200
expect(json_response).to be_an Array
expect(json_response.length).to eq 1
expect(json_build['status']).to eq 'skipped'
context 'filter project with array of scope elements' do
let(:query) { 'scope[0]=pending&scope[1]=running' }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment