Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
heptapod
heptapod
Commits
5626bdcd1274
Commit
e6bf8b88
authored
Nov 28, 2018
by
George Tsiolis
Committed by
Clement Ho
Nov 28, 2018
Browse files
Include new and edit links in breadcrumb for project milestones, group milestones, and labels
parent
c26b6d6a35a7
Changes
14
Hide whitespace changes
Inline
Side-by-side
app/views/groups/labels/edit.html.haml
View file @
5626bdcd
-
page_title
'Edit'
,
@label
.
name
,
'Labels'
-
add_to_breadcrumbs
_
(
"Labels"
),
group_labels_path
(
@group
)
-
breadcrumb_title
_
(
"Edit"
)
-
page_title
"Edit"
,
@label
.
name
,
_
(
"Labels"
)
%h3
.page-title
Edit Label
...
...
app/views/groups/labels/new.html.haml
View file @
5626bdcd
-
breadcrumb_title
"Labels"
-
page_title
'New Label'
-
add_to_breadcrumbs
_
(
"Labels"
),
group_labels_path
(
@group
)
-
breadcrumb_title
_
(
"New"
)
-
page_title
_
(
"New Label"
)
%h3
.page-title
New Label
...
...
app/views/groups/milestones/edit.html.haml
View file @
5626bdcd
-
page_title
"Milestones"
-
breadcrumb_title
_
(
"Edit"
)
-
page_title
_
(
"Milestones"
)
-
render
"header_title"
%h3
.page-title
Edit Milestone
%hr
=
render
"form"
app/views/groups/milestones/new.html.haml
View file @
5626bdcd
-
breadcrumb_title
"Milestones"
-
page_title
"Milestones"
-
@no_container
=
true
-
add_to_breadcrumbs
_
(
"Milestones"
),
group_milestones_path
(
@group
)
-
breadcrumb_title
_
(
"New"
)
-
page_title
_
(
"Milestones"
),
@milestone
.
name
,
_
(
"Milestones"
)
%h3
.page-title
New Milestone
%div
{
class:
container_class
}
%h3
.page-title
New Milestone
=
render
"form"
%hr
=
render
"form"
app/views/projects/labels/edit.html.haml
View file @
5626bdcd
-
@no_container
=
true
-
add_to_breadcrumbs
"Labels"
,
project_labels_path
(
@project
)
-
breadcrumb_title
"Edit"
-
page_title
"Edit"
,
@label
.
name
,
"Labels"
%div
{
class:
container_class
}
...
...
app/views/projects/labels/new.html.haml
View file @
5626bdcd
-
@no_container
=
true
-
breadcrumb_title
"Labels"
-
add_to_breadcrumbs
"Labels"
,
project_labels_path
(
@project
)
-
breadcrumb_title
"New"
-
page_title
"New Label"
%div
{
class:
container_class
}
...
...
app/views/projects/milestones/edit.html.haml
View file @
5626bdcd
-
@no_container
=
true
-
breadcrumb_title
"Edit"
-
add_to_breadcrumbs
"Milestones"
,
project_milestones_path
(
@project
)
-
page_title
"Edit"
,
@milestone
.
title
,
"Milestones"
%div
{
class:
container_class
}
%h3
.page-title
...
...
app/views/projects/milestones/new.html.haml
View file @
5626bdcd
-
@no_container
=
true
-
breadcrumb_title
"Milestones"
-
add_to_breadcrumbs
"Milestones"
,
project_milestones_path
(
@project
)
-
breadcrumb_title
"New"
-
page_title
"New Milestone"
%div
{
class:
container_class
}
...
...
app/views/projects/wikis/edit.html.haml
View file @
5626bdcd
-
@content_class
=
"limit-container-width"
unless
fluid_layout
-
page_title
_
(
"Edit"
),
@page
.
title
.
capitalize
,
_
(
"Wiki"
)
-
add_to_breadcrumbs
_
(
"Wiki"
),
project_wiki_path
(
@project
,
@page
)
-
breadcrumb_title
@page
.
persisted?
?
_
(
"Edit"
)
:
_
(
"New"
)
-
page_title
@page
.
persisted?
?
_
(
"Edit"
)
:
_
(
"New"
),
@page
.
title
.
capitalize
,
_
(
"Wiki"
)
=
wiki_page_errors
(
@error
)
...
...
changelogs/unreleased/include-new-link-in-breadcrumb.yml
0 → 100644
View file @
5626bdcd
---
title
:
Include new link in breadcrumb for issues, merge requests, milestones, and labels
merge_request
:
18515
author
:
George Tsiolis
type
:
changed
spec/features/issues/user_sees_breadcrumb_links_spec.rb
View file @
5626bdcd
require
'rails_helper'
describe
'New issue breadcrumb
s
'
do
describe
'New issue breadcrumb'
do
let
(
:project
)
{
create
(
:project
)
}
let
(
:user
)
{
project
.
creator
}
let
(
:user
)
{
project
.
creator
}
before
do
sign_in
(
user
)
visit
new_project_issue_path
(
project
)
visit
(
new_project_issue_path
(
project
)
)
end
it
'display
a
link to project issues and new issue
pages
'
do
it
'display
s
link to project issues and new issue'
do
page
.
within
'.breadcrumbs'
do
expect
(
find_link
(
'Issues'
)[
:href
]).
to
end_with
(
project_issues_path
(
project
))
expect
(
find_link
(
'New'
)[
:href
]).
to
end_with
(
new_project_issue_path
(
project
))
...
...
spec/features/merge_request/user_sees_breadcrumb_links_spec.rb
View file @
5626bdcd
require
'rails_helper'
describe
'New merge request breadcrumb
s
'
do
describe
'New merge request breadcrumb'
do
let
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:user
)
{
project
.
creator
}
let
(
:user
)
{
project
.
creator
}
before
do
sign_in
(
user
)
visit
project_new_merge_request_path
(
project
)
visit
(
project_new_merge_request_path
(
project
)
)
end
it
'display
a
link to project merge requests and new merge request
pages
'
do
it
'display
s
link to project merge requests and new merge request'
do
page
.
within
'.breadcrumbs'
do
expect
(
find_link
(
'Merge Requests'
)[
:href
]).
to
end_with
(
project_merge_requests_path
(
project
))
expect
(
find_link
(
'New'
)[
:href
]).
to
end_with
(
project_new_merge_request_path
(
project
))
...
...
spec/features/milestones/user_sees_breadcrumb_links_spec.rb
0 → 100644
View file @
5626bdcd
require
'rails_helper'
describe
'New project milestone breadcrumb'
do
let
(
:project
)
{
create
(
:project
)
}
let
(
:milestone
)
{
create
(
:milestone
,
project:
project
)
}
let
(
:user
)
{
project
.
creator
}
before
do
sign_in
(
user
)
visit
(
new_project_milestone_path
(
project
))
end
it
'displays link to project milestones and new project milestone'
do
page
.
within
'.breadcrumbs'
do
expect
(
find_link
(
'Milestones'
)[
:href
]).
to
end_with
(
project_milestones_path
(
project
))
expect
(
find_link
(
'New'
)[
:href
]).
to
end_with
(
new_project_milestone_path
(
project
))
end
end
end
spec/features/projects/labels/user_sees_breadcrumb_links_spec.rb
0 → 100644
View file @
5626bdcd
require
'rails_helper'
describe
'New project label breadcrumb'
do
let
(
:project
)
{
create
(
:project
)
}
let
(
:user
)
{
project
.
creator
}
before
do
sign_in
(
user
)
visit
(
project_labels_path
(
project
))
end
it
'displays link to project labels and new project label'
do
page
.
within
'.breadcrumbs'
do
expect
(
find_link
(
'Labels'
)[
:href
]).
to
end_with
(
project_labels_path
(
project
))
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment