1. 21 Jun, 2017 1 commit
  2. 14 Jun, 2017 2 commits
  3. 09 Jun, 2017 1 commit
  4. 08 Jun, 2017 3 commits
    • DJ Mountney's avatar
      Merge branch '25934-project-snippet-vis' into 'security-9-2' · 6ea581c749cc
      DJ Mountney authored
      Fix visibility when referencing snippets
      
      See merge request !2101
      6ea581c749cc
    • DJ Mountney's avatar
      Bring in security changes from the 9.2.5 release · a5d6048d960f
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
      a5d6048d960f
    • DJ Mountney's avatar
      Bring in security changes from the 9.2.5 release · 67d8f2be7b6e
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
      67d8f2be7b6e
  5. 31 May, 2017 1 commit
  6. 30 May, 2017 1 commit
    • Sean McGivern's avatar
      Fix /unsubscribe slash command creating extra todos · 6325e414319c
      Sean McGivern authored
      The /unsubscribe slash command means that we check if the current user is
      subscribed to the issuable without having an explicit subscription. That means
      that we use the UserParser to find references to them in the notes.
      
      The UserParser (and all parsers inheriting from BaseParser) use RequestStore to
      cache ActiveRecord objects, so that we don't need to load the User object each
      time, if we're parsing references a bunch of times in the same request.
      
      However, it was always returning _all_ of the previously cached items, not just
      the ones matching the IDs passed. This would mean that we did two runs through
      with UserParser if you were mentioned in a comment, and then mentioned someone
      else in your comment while using /unsubscribe:
      
      1. Because /unsubscribe was used, we see if you were mentioned in any comments.
      2. Because you mentioned someone, we find them - but we would also get back your
         user, even if you didn't mention yourself. This would have the effect of
         creating a mention or directly addressed todo for yourself incorrectly.
      
      The fix is simple: only return values from the cache matching the IDs passed.
      6325e414319c
  7. 24 May, 2017 1 commit
  8. 18 May, 2017 1 commit
  9. 10 May, 2017 1 commit
  10. 04 May, 2017 1 commit
  11. 01 May, 2017 1 commit
  12. 25 Apr, 2017 3 commits
  13. 21 Apr, 2017 3 commits
  14. 19 Apr, 2017 3 commits
  15. 15 Apr, 2017 1 commit
  16. 13 Apr, 2017 1 commit
  17. 07 Apr, 2017 1 commit
    • Adam Buckland's avatar
      Add indication for closed or merged issuables in GFM · 0793a8e93c94
      Adam Buckland authored
      Example: for issues that are closed, the links will now show '[closed]'
      following the issue number. This is done as post-process after the markdown has
      been loaded from the cache as the status of the issue may change between
      the cache being populated and the content being displayed.
      
      In order to avoid N+1 queries problem when rendering notes ObjectRenderer
      populates the cache of referenced issuables for all notes at once,
      before the post processing phase.
      
      As a part of this change, the Banzai BaseParser#grouped_objects_for_nodes
      method has been refactored to return a Hash utilising the node itself as the
      key, since this was a common pattern of usage for this method.
      0793a8e93c94
  18. 06 Apr, 2017 1 commit
  19. 28 Mar, 2017 2 commits
  20. 14 Mar, 2017 1 commit
  21. 06 Mar, 2017 3 commits
  22. 01 Mar, 2017 1 commit
  23. 23 Feb, 2017 6 commits