- 22 Aug, 2018 2 commits
-
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
Previous code would not work with `disabled?` because that method would send two parameters (second always `nil`) which we are not mocking. Instead of mock yet another state, I decide to fix it where it belongs.
-
- 20 Aug, 2018 2 commits
-
-
Gilbert Roulot authored
-
Yorick Peterse authored
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder".
-
- 16 Aug, 2018 1 commit
-
-
Dylan Griffith authored
-
- 06 Aug, 2018 1 commit
-
-
Mike Greiling authored
-
- 03 Aug, 2018 1 commit
-
-
Valery Sizov authored
Resolve "Hashed storage: extend "Enable hashed storage for all new projects" to "for all new and renamed projects""
-
- 01 Aug, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
Our friends at GitHub show the programming languages for a long time, and inspired by that this commit means to create about the same functionality. Language detection is done through Linguist, as before, where the difference is that we cache the result in the database. Also, Gitaly can incrementaly scan a repository. This is done through a shell out, which creates overhead of about 3s each run. For now this won't be improved. Scans are triggered by pushed to the default branch, usually `master`. However, one exception to this rule the charts page. If we're requesting this expensive data anyway, we just cache it in the database. Edge cases where there is no repository, or its empty are caught in the Repository model. This makes use of Redis caching, which is probably already loaded. The added model is called RepositoryLanguage, which will make it harder if/when GitLab supports multiple repositories per project. However, for now I think this shouldn't be a concern. Also, Language could be confused with the i18n languages and felt like the current name was suiteable too. Design of the Project#Show page is done with help from @dimitrieh. This change is not visible to the end user unless detections are done.
-
- 30 Jul, 2018 1 commit
-
-
Francisco Javier López authored
-
- 25 Jul, 2018 1 commit
-
-
Yorick Peterse authored
This adds a database migration that creates routes for any projects and namespaces that don't already have one. We also remove the runtime code for dynamically creating routes, as this is no longer necessary.
-
- 24 Jul, 2018 1 commit
-
-
Gabriel Mazetto authored
-
- 14 Jul, 2018 1 commit
-
-
Kukovskii Vladimir authored
-
- 12 Jul, 2018 1 commit
-
-
Grzegorz Bizon authored
-
- 11 Jul, 2018 1 commit
-
-
Mark Chao authored
-
- 09 Jul, 2018 1 commit
-
-
Lin Jen-Shin authored
-
- 06 Jul, 2018 1 commit
-
-
James Lopez authored
-
- 04 Jul, 2018 2 commits
-
-
Reuben Pereira authored
Add back the Project#to_reference_with_postfix function since it can be used in the ProjectReferenceFilter#link_to_project function
-
Tiago Botelho authored
-
- 03 Jul, 2018 1 commit
-
-
Reuben Pereira authored
Remove the Project#to_reference_with_postfix method since it is only used in the project_reference_filter_spec
-
- 30 Jun, 2018 1 commit
-
-
Reuben Pereira authored
A working implementation of a project reference filter which links project references to project profile.
-
- 27 Jun, 2018 1 commit
-
-
Jasper Maes authored
-
- 18 Jun, 2018 1 commit
-
-
Stan Hu authored
This significantly improves performance when a user pushes many references. project.path_locks.any? doesn't cache the output and runs `SELECT 1 AS one FROM "path_locks" WHERE project_id = N` each time. When there are thousands of refs being pushed, this can time out the unicorn worker. CE port for https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6159.
-
- 14 Jun, 2018 1 commit
-
-
Jacob Vosmaer (GitLab) authored
-
- 11 Jun, 2018 6 commits
-
-
Stan Hu authored
Multiple Sidekiq workers can run in the spec, causing `Project.find` to be run in different places. Instead of setting a fixed number of calls, just use `allow`.
-
Stan Hu authored
-
Stan Hu authored
-
Bob Van Landuyt authored
Before the push git would make a call to `/:namespace/:project/git-receive-pack`. This would perform an access check without a ref. So the `Project#branch_allows_maintainer_push?` would return false. This adjusts `Project#branch_allows_maintainer_push?` to return true when passing no branch name if there are merge requests open that would allow the user to push. The actual check then happens when a call to `/api/v4/internal/allowed` is made from a git hook.
-
Stan Hu authored
The cache state for Wikis that were imported via GitHub or Bitbucket does not appear to have been flushed after a successful import. Closes #47546
-
Francisco Javier López authored
-
- 06 Jun, 2018 1 commit
-
-
Tiago Botelho authored
-
- 05 Jun, 2018 1 commit
-
-
Alexis Reigel authored
-
- 01 Jun, 2018 1 commit
-
-
Mark Chao authored
"Maintainer" will be freed to be used for #42751
-
- 31 May, 2018 2 commits
-
-
Kamil Trzciński authored
-
Dylan Griffith authored
-
- 22 May, 2018 1 commit
-
-
Imre Farkas authored
-
- 16 May, 2018 1 commit
-
-
Jan Provaznik authored
ObjectStore uploader requires presence of associated `uploads` record when deleting the upload file (through the carrierwave's after_commit hook) because we keep info whether file is LOCAL or REMOTE in `upload` object. For this reason we can not destroy uploads as "dependent: :destroy" hook because these would be deleted too soon. Instead we rely on carrierwave's hook to destroy `uploads` in after_commit hook. But in before_destroy hook we still have to delete not-mounted uploads (which don't use carrierwave's destroy hook). This has to be done in before_Destroy instead of after_commit because `FileUpload` requires existence of model's object on destroy action. This is not ideal state of things, in a next step we should investigate how to unify model dependencies so we can use same workflow for all uploads. Related to #45425
-
- 08 May, 2018 2 commits
-
-
Dylan Griffith authored
-
Tiago Botelho authored
-
- 07 May, 2018 2 commits
-
-
Tiago Botelho authored
-
Tiago Botelho authored
-