1. 20 Aug, 2018 1 commit
    • Yorick Peterse's avatar
      Refactor AutocompleteController · c8cc17675ba4
      Yorick Peterse authored
      This refactors the AutocompleteController according to the guidelines
      and boundaries discussed in
      https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically,
      ActiveRecord logic is moved to different finders, which are then used in
      the controller. View logic in turn is moved to presenters, instead of
      directly using ActiveRecord's "to_json" method.
      The finder MoveToProjectFinder is also adjusted according to the
      abstraction guidelines and boundaries, resulting in a much more simple
      By using finders (and other abstractions) more actively, we can push a
      lot of logic out of the controller. We also remove the need for various
      "before_action" hooks, though this could be achieved without using
      finders as well.
      The various finders related to AutcompleteController have also been
      moved into a namespace. This removes the need for calling everything
      "AutocompleteSmurfFinder", instead you can use
  2. 26 Jul, 2018 1 commit
  3. 18 Aug, 2017 1 commit
  4. 17 Aug, 2017 1 commit
  5. 21 Jul, 2017 1 commit
  6. 21 Jun, 2017 1 commit
  7. 07 Jun, 2017 1 commit
  8. 06 Apr, 2017 1 commit
    • Timothy Andrew's avatar
      Move a user's award emoji to the ghost user · b96d1ae5df67
      Timothy Andrew authored
      ... when the user is destroyed.
      1. Normally, for a given awardable and award emoji name, a user is only allowed
         to create a single award emoji.
      2. This validation needs to be removed for ghost users, since:
         - User A and User B have created award emoji - with the same name and against
           the same awardable
         - User A is deleted. Their award emoji is moved to the ghost user
         - User B is deleted. Their award emoji needs to be moved to the ghost user.
           However, this breaks the uniqueness validation, since the ghost user is
           only allowed to have one award emoji of a given name for a given awardable
  9. 23 Feb, 2017 2 commits
  10. 09 Feb, 2017 1 commit
  11. 29 Jun, 2016 1 commit
  12. 18 May, 2016 1 commit
  13. 06 May, 2016 1 commit