- 20 Aug, 2018 1 commit
-
-
Yorick Peterse authored
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder".
-
- 26 Jul, 2018 1 commit
-
-
gfyoung authored
Partially addresses #47424.
-
- 18 Aug, 2017 1 commit
-
-
Douwe Maan authored
-
- 17 Aug, 2017 1 commit
-
-
Douwe Maan authored
-
- 21 Jul, 2017 1 commit
-
-
Sean McGivern authored
-
- 21 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 07 Jun, 2017 1 commit
-
-
Yorick Peterse authored
One should really use a separate table instead of using polymorphic associations. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11168 for more information.
-
- 06 Apr, 2017 1 commit
-
-
Timothy Andrew authored
... when the user is destroyed. 1. Normally, for a given awardable and award emoji name, a user is only allowed to create a single award emoji. 2. This validation needs to be removed for ghost users, since: - User A and User B have created award emoji - with the same name and against the same awardable - User A is deleted. Their award emoji is moved to the ghost user - User B is deleted. Their award emoji needs to be moved to the ghost user. However, this breaks the uniqueness validation, since the ghost user is only allowed to have one award emoji of a given name for a given awardable
-
- 23 Feb, 2017 2 commits
-
-
Douwe Maan authored
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
-
Douwe Maan authored
-
- 09 Feb, 2017 1 commit
-
-
Felipe Artur authored
-
- 29 Jun, 2016 1 commit
-
-
Connor Shea authored
No reason to split it into a separate gem when the gem barely did anything. We can use gemojione directly, making updating gemojione that much easier. Also fix the Rake task and update gemojione to 2.6.1. This adds the EmojiOne Spring update. Changelog: https://github.com/jonathanwiesel/gemojione/blob/master/CHANGELOG.md
-
- 18 May, 2016 1 commit
-
-
ZJ van de Weg authored
-
- 06 May, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-