- 01 Nov, 2018 1 commit
-
-
George Tsiolis authored
-
- 02 Oct, 2018 1 commit
-
-
Stan Hu authored
When a user cannot be renamed due to existing container registry tags, log the namespace and an example project that has tags.
-
- 24 Sep, 2018 1 commit
-
-
Michael Kozono authored
Even if it doesn’t save lines of code, since people will tend to use code they’ve seen. And `SafeRequestStore` is safer since you don’t have to remember to check `RequestStore.active?`.
-
- 17 Sep, 2018 1 commit
-
-
Yorick Peterse authored
This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
-
- 06 Sep, 2018 1 commit
-
-
James Lopez authored
Updated docs, refactor import/export code Fix AvatarUploader path issue Fix project export upload webhook error
-
- 15 Aug, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 01 Aug, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
Our friends at GitHub show the programming languages for a long time, and inspired by that this commit means to create about the same functionality. Language detection is done through Linguist, as before, where the difference is that we cache the result in the database. Also, Gitaly can incrementaly scan a repository. This is done through a shell out, which creates overhead of about 3s each run. For now this won't be improved. Scans are triggered by pushed to the default branch, usually `master`. However, one exception to this rule the charts page. If we're requesting this expensive data anyway, we just cache it in the database. Edge cases where there is no repository, or its empty are caught in the Repository model. This makes use of Redis caching, which is probably already loaded. The added model is called RepositoryLanguage, which will make it harder if/when GitLab supports multiple repositories per project. However, for now I think this shouldn't be a concern. Also, Language could be confused with the i18n languages and felt like the current name was suiteable too. Design of the Project#Show page is done with help from @dimitrieh. This change is not visible to the end user unless detections are done.
-
- 26 Jul, 2018 1 commit
-
-
gfyoung authored
Partially addresses #47424.
-
- 25 Jul, 2018 1 commit
-
-
Yorick Peterse authored
This adds a database migration that creates routes for any projects and namespaces that don't already have one. We also remove the runtime code for dynamically creating routes, as this is no longer necessary.
-
- 26 Jun, 2018 1 commit
-
-
Lin Jen-Shin authored
-
- 31 May, 2018 1 commit
-
-
Kamil Trzciński authored
-
- 04 May, 2018 1 commit
-
-
Mario de la Ossa authored
-
- 02 May, 2018 1 commit
-
-
Dylan Griffith authored
-
- 09 Apr, 2018 1 commit
-
-
Dylan Griffith authored
-
- 06 Apr, 2018 1 commit
-
-
Francisco Javier López authored
-
- 06 Mar, 2018 1 commit
-
-
Felipe Artur authored
-
- 03 Mar, 2018 1 commit
-
-
Felipe Artur authored
-
- 07 Feb, 2018 1 commit
-
-
Dylan Griffith authored
-
- 06 Feb, 2018 3 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Mayra Cabrera authored
-
- 05 Feb, 2018 1 commit
-
-
Nick Thomas authored
-
- 02 Feb, 2018 1 commit
-
-
Mario de la Ossa authored
-
- 08 Jan, 2018 1 commit
-
-
Yorick Peterse authored
This removes all usage of soft removals except for the "pending delete" system implemented for projects. This in turn simplifies all the query plans of the models that used soft removals. Since we don't really use soft removals for anything useful there's no point in keeping it around. This _does_ mean that hard removals of issues (which only admins can do if I'm not mistaken) can influence the "iid" values, but that code is broken to begin with. More on this (and how to fix it) can be found in https://gitlab.com/gitlab-org/gitlab-ce/issues/31114. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
-
- 03 Jan, 2018 3 commits
-
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
- 08 Dec, 2017 1 commit
-
-
Mayra Cabrera authored
-
- 04 Dec, 2017 1 commit
-
-
Bob Van Landuyt authored
On the `show` of a project that is part of a fork network. We check if the user already created a fork of this project in their personal namespace. We do this in several places, so caching the result of this query in the request store prevents us from repeating it.
-
- 27 Nov, 2017 1 commit
-
-
Douwe Maan authored
-
- 24 Nov, 2017 1 commit
-
-
Douwe Maan authored
-
- 06 Nov, 2017 1 commit
-
-
Douwe Maan authored
-
- 10 Oct, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 07 Oct, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 15 Sep, 2017 1 commit
-
-
Yorick Peterse authored
Prior to this commit running Namespace#force_share_with_group_lock_on_descendants would result in updating _all_ namespaces in the namespaces table, not just the descendants. This is the result of ActiveRecord::Relation#update_all not taking into account the CTE. To work around this we use the CTE query as a sub-query instead of directly calling #update_all. To prevent this from happening the relations returned by Gitlab::GroupHierarchy are now marked as read-only, resulting in an error being raised when methods such as #update_all are used. Fortunately on GitLab.com our statement timeouts appear to have prevented this query from actually doing any damage other than causing a very large amount of dead tuples. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916
-
- 06 Sep, 2017 2 commits
-
-
Michael Kozono authored
-
Michael Kozono authored
…when needed
-
- 31 Aug, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
In this instance its subgroups, and given we can't deploy it, we shouldn't allow it to be shown. Fixes gitlab-org/gitlab-ce#34864
-
- 14 Aug, 2017 1 commit
-
-
Nick Thomas authored
-
- 01 Aug, 2017 1 commit
-
-
Gabriel Mazetto authored
-