Read about our upcoming Code of Conduct on this issue

  1. 22 Mar, 2018 1 commit
  2. 05 Mar, 2018 1 commit
  3. 23 Feb, 2018 1 commit
  4. 22 Feb, 2018 1 commit
  5. 20 Feb, 2018 1 commit
  6. 16 Feb, 2018 1 commit
  7. 14 Feb, 2018 1 commit
  8. 13 Feb, 2018 1 commit
  9. 02 Feb, 2018 1 commit
  10. 22 Jan, 2018 1 commit
  11. 19 Jan, 2018 1 commit
  12. 04 Jan, 2018 1 commit
  13. 23 Nov, 2017 1 commit
  14. 03 Nov, 2017 1 commit
  15. 21 Oct, 2017 1 commit
  16. 20 Oct, 2017 1 commit
  17. 03 Oct, 2017 1 commit
  18. 28 Sep, 2017 1 commit
  19. 22 Sep, 2017 1 commit
  20. 13 Sep, 2017 1 commit
  21. 07 Sep, 2017 6 commits
    • Yorick Peterse's avatar
      Rework how recent push events are retrieved · 9ec66da20412
      Yorick Peterse authored
      Whenever you push to a branch GitLab will show a button to create a
      merge request (should one not exist already). The underlying code to
      display this data was quite inefficient. For example, it involved
      multiple slow queries just to figure out what the most recent push event
      was.
      
      This commit changes the way this data is retrieved so it's much faster.
      This is achieved by caching the ID of the last push event on every push,
      which is then retrieved when loading certain pages. Database queries are
      only executed if necessary and the cached data is removed automatically
      once a merge request has been created, or 2 hours after being stored.
      
      A trade-off of this approach is that we _only_ track the last event.
      Previously if you were to push to branch A and B then create a merge
      request for branch B we'd still show the widget for branch A. As of this
      commit this is no longer the case, instead we will only show the widget
      for the branch you pushed to most recently. Once a merge request exists
      the widget is no longer displayed. Alternative solutions are either too
      complex and/or too slow, hence the decision was made to settle for this
      trade-off.
      
      Performance Impact
      ------------------
      
      In the best case scenario (= a user didn't push anything for more than 2
      hours) we perform a single Redis GET per page. Should there be cached
      data we will run a single (and lightweight) SQL query to get the
      event data from the database. If a merge request already exists we will
      run an additional DEL to remove the cache key.
      
      The difference in response timings can vary a bit per project. On
      GitLab.com the 99th percentile of time spent in User#recent_push hovers
      between 100 milliseconds and 1 second, while the mean hovers around 50
      milliseconds. With the changes in this MR the expected time spent in
      User#recent_push is expected to be reduced down to just a few
      milliseconds.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
      9ec66da20412
    • Mike Greiling's avatar
    • Maxim Rydkin's avatar
    • Maxim Rydkin's avatar
      fix project_helper.rb and add couple specs to it · 719d6007dc10
      Maxim Rydkin authored
      719d6007dc10
    • Maxim Rydkin's avatar
      fix helper and spec · 7a5d0c050e1c
      Maxim Rydkin authored
      7a5d0c050e1c
    • Maxim Rydkin's avatar
      refactor `app/helpers/projects_helper.rb:21:3` · c3338188adb5
      Maxim Rydkin authored
      c3338188adb5
  22. 06 Sep, 2017 3 commits
  23. 05 Sep, 2017 2 commits
  24. 31 Aug, 2017 1 commit
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · e1c28a485974
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      e1c28a485974
  25. 29 Aug, 2017 1 commit
  26. 18 Aug, 2017 5 commits
  27. 15 Aug, 2017 1 commit
  28. 14 Aug, 2017 1 commit