Read about our upcoming Code of Conduct on this issue

  1. 27 Nov, 2018 1 commit
  2. 23 Jul, 2018 1 commit
  3. 20 Jul, 2018 1 commit
  4. 27 Jun, 2018 1 commit
  5. 21 Jun, 2018 1 commit
    • Yorick Peterse's avatar
      Don't expose project names in various counters · 76e4045a747c
      Yorick Peterse authored
      Various counters would expose either project names, or full project
      paths (e.g. "gitlab-org/gitlab-ce"). This commit changes various places
      where we use "add_event" so we no longer expose (potentially) private
      information.
      76e4045a747c
  6. 26 Jan, 2018 2 commits
  7. 15 Dec, 2017 1 commit
  8. 05 Dec, 2017 1 commit
  9. 07 Nov, 2017 1 commit
    • Yorick Peterse's avatar
      Rewrite the GitHub importer from scratch · 86c05c535691
      Yorick Peterse authored
      Prior to this MR there were two GitHub related importers:
      
      * Github::Import: the main importer used for GitHub projects
      * Gitlab::GithubImport: importer that's somewhat confusingly used for
        importing Gitea projects (apparently they have a compatible API)
      
      This MR renames the Gitea importer to Gitlab::LegacyGithubImport and
      introduces a new GitHub importer in the Gitlab::GithubImport namespace.
      This new GitHub importer uses Sidekiq for importing multiple resources
      in parallel, though it also has the ability to import data sequentially
      should this be necessary.
      
      The new code is spread across the following directories:
      
      * lib/gitlab/github_import: this directory contains most of the importer
        code such as the classes used for importing resources.
      * app/workers/gitlab/github_import: this directory contains the Sidekiq
        workers, most of which simply use the code from the directory above.
      * app/workers/concerns/gitlab/github_import: this directory provides a
        few modules that are included in every GitHub importer worker.
      
      == Stages
      
      The import work is divided into separate stages, with each stage
      importing a specific set of data. Stages will schedule the work that
      needs to be performed, followed by scheduling a job for the
      "AdvanceStageWorker" worker. This worker will periodically check if all
      work is completed and schedule the next stage if this is the case. If
      work is not yet completed this worker will reschedule itself.
      
      Using this approach we don't have to block threads by calling `sleep()`,
      as doing so for large projects could block the thread from doing any
      work for many hours.
      
      == Retrying Work
      
      Workers will reschedule themselves whenever necessary. For example,
      hitting the GitHub API's rate limit will result in jobs rescheduling
      themselves. These jobs are not processed until the rate limit has been
      reset.
      
      == User Lookups
      
      Part of the importing process involves looking up user details in the
      GitHub API so we can map them to GitLab users. The old importer used
      an in-memory cache, but this obviously doesn't work when the work is
      spread across different threads.
      
      The new importer uses a Redis cache and makes sure we only perform
      API/database calls if absolutely necessary.  Frequently used keys are
      refreshed, and lookup misses are also cached; removing the need for
      performing API/database calls if we know we don't have the data we're
      looking for.
      
      == Performance & Models
      
      The new importer in various places uses raw INSERT statements (as
      generated by `Gitlab::Database.bulk_insert`) instead of using Rails
      models. This allows us to bypass any validations and callbacks,
      drastically reducing the number of SQL queries and Gitaly RPC calls
      necessary to import projects.
      
      To ensure the code produces valid data the corresponding tests check if
      the produced rows are valid according to the model validation rules.
      86c05c535691
  10. 10 Oct, 2017 1 commit
  11. 25 Aug, 2017 2 commits
  12. 24 Aug, 2017 1 commit
    • Stan Hu's avatar
      Enable 5 lines of Sidekiq backtrace lines to aid in debugging · 74179ab3e9a5
      Stan Hu authored
      Customers often have Sidekiq jobs that failed without much context. Without
      Sentry, there's no way to tell where these exceptions were hit. Adding
      in additional lines adds a bit more Redis storage overhead. This commit
      adds in backtrace logging for workers that delete groups/projects and
      import/export projects.
      
      Closes #27626
      74179ab3e9a5
  13. 17 Aug, 2017 1 commit
  14. 01 Aug, 2017 1 commit
  15. 05 Jun, 2017 1 commit
  16. 05 Apr, 2017 1 commit
  17. 03 Apr, 2017 1 commit
  18. 21 Oct, 2016 1 commit
    • Yorick Peterse's avatar
      Re-organize queues to use for Sidekiq · 02c0ae5ed1f6
      Yorick Peterse authored
      Dumping too many jobs in the same queue (e.g. the "default" queue) is a
      dangerous setup. Jobs that take a long time to process can effectively
      block any other work from being performed given there are enough of
      these jobs.
      
      Furthermore it becomes harder to monitor the jobs as a single queue
      could contain jobs for different workers. In such a setup the only
      reliable way of getting counts per job is to iterate over all jobs in a
      queue, which is a rather time consuming process.
      
      By using separate queues for various workers we have better control over
      throughput, we can add weight to queues, and we can monitor queues
      better. Some workers still use the same queue whenever their work is
      related. For example, the various CI pipeline workers use the same
      "pipeline" queue.
      
      This commit includes a Rails migration that moves Sidekiq jobs from the
      old queues to the new ones. This migration also takes care of doing the
      inverse if ever needed. This does require downtime as otherwise new jobs
      could be scheduled in the old queues after this migration completes.
      
      This commit also includes an RSpec test that blacklists the use of the
      "default" queue and ensures cron workers use the "cronjob" queue.
      
      Fixes gitlab-org/gitlab-ce#23370
      02c0ae5ed1f6
  19. 24 Aug, 2016 1 commit
  20. 17 Aug, 2016 1 commit
    • Yorick Peterse's avatar
      Tracking of custom events · 8f655bf7dfb2
      Yorick Peterse authored
      GitLab Performance Monitoring is now able to track custom events not
      directly related to application performance. These events include the
      number of tags pushed, repositories created, builds registered, etc.
      
      The use of these events is to get a better overview of how a GitLab
      instance is used and how that may affect performance. For example, a
      large number of Git pushes may have a negative impact on the underlying
      storage engine.
      
      Events are stored in the "events" measurement and are not prefixed with
      "rails_" or "sidekiq_", this makes it easier to query events with the
      same name triggered from different parts of the application. All events
      being stored in the same measurement also makes it easier to downsample
      data.
      
      Currently the following events are tracked:
      
      * Creating repositories
      * Removing repositories
      * Changing the default branch of a repository
      * Pushing a new tag
      * Removing an existing tag
      * Pushing a commit (along with the branch being pushed to)
      * Pushing a new branch
      * Removing an existing branch
      * Importing a repository (along with the URL we're importing)
      * Forking a repository (along with the source/target path)
      * CI builds registered (and when no build could be found)
      * CI builds being updated
      * Rails and Sidekiq exceptions
      
      Fixes gitlab-org/gitlab-ce#13720
      8f655bf7dfb2
  21. 03 Jun, 2016 4 commits
  22. 19 May, 2016 1 commit
  23. 23 Feb, 2016 1 commit
  24. 17 Feb, 2016 1 commit
  25. 26 Jan, 2016 1 commit
  26. 20 Nov, 2015 1 commit
  27. 18 Nov, 2015 2 commits
  28. 09 Sep, 2015 1 commit
  29. 23 Aug, 2015 1 commit
    • Stan Hu's avatar
      Remove user OAuth tokens stored in database for Bitbucket, GitHub, and GitLab · 1f548c79b42a
      Stan Hu authored
      and request them each session. Pass these tokens to the project import data.
      
      This prevents the need to encrypt these tokens and clear them in case they
      expire or get revoked.
      
      For example, if you deleted and re-created OAuth2 keys for Bitbucket, you would get
      an Error 500 with no way to recover:
      
      ```
      Started GET "/import/bitbucket/status" for x.x.x.x at 2015-08-07 05:24:10 +0000
      Processing by Import::BitbucketController#status as HTML
      Completed 500 Internal Server Error in 607ms (ActiveRecord: 2.3ms)
      
      NameError (uninitialized constant Import::BitbucketController::Unauthorized):
        app/controllers/import/bitbucket_controller.rb:77:in `rescue in go_to_bitbucket_for_permissions'
        app/controllers/import/bitbucket_controller.rb:74:in `go_to_bitbucket_for_permissions'
        app/controllers/import/bitbucket_controller.rb:86:in `bitbucket_unauthorized'
      ```
      
      Closes #1871
      1f548c79b42a
  30. 11 Aug, 2015 2 commits
  31. 17 Jul, 2015 1 commit
  32. 15 Jul, 2015 1 commit
  33. 03 Apr, 2015 1 commit