- 12 Apr, 2019 2 commits
-
-
Martin Wortschack authored
- Update PO file
-
Peter Leitzen authored
It's not needed anymore as we've replaced boolean `support_bot` with enum `bot_type`.
-
- 11 Apr, 2019 2 commits
-
-
Patrick Bajao authored
This reverts commit 6c75bd015cba181f028bc87c396c3d8e43b5dc3e, reversing changes made to 1be7f5aaa38aba79843eae8835be6c99c025e982.
-
Thong Kuah authored
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement. Make use of the options attribute of the parent class ActiveModel::EachValidator. Add more options: allow_nil, allow_blank, message. Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
-
- 10 Apr, 2019 3 commits
-
-
Rémy Coutable authored
It could happen that there's a cached (in Redis) ApplicationSetting record, and calling `Gitlab::CurrentSettings.current_application_settings` only returns it instead of creating a new DB record, which makes the `ApplicationSetting.current_without_cache.update!` call fail. Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Sean McGivern authored
This reverts commit a5378665a1dc0b9c8dc3a4fa279a0eb78aac5aac.
-
Stan Hu authored
This reverts merge request !26481
-
- 09 Apr, 2019 4 commits
-
-
Imre Farkas authored
Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE
-
Zeger-Jan van de Weg authored
To make sure all known issues are linked to the correct epic, I've gone through the code base, and updated the comments where required.
-
Agustin Henze authored
Used to get the variables via the API endpoint `/projects/:id/pipelines/:pipeline_id/variables` Signed-off-by:
Agustin Henze <tin@redhat.com>
-
Jason Goodman authored
Also set the release sha and author
-
- 08 Apr, 2019 2 commits
-
-
Oswaldo Ferreira authored
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161 (code out of ee/ folder).
-
Sean McGivern authored
-
- 06 Apr, 2019 1 commit
-
-
Chris Baumbauer authored
-
- 05 Apr, 2019 5 commits
-
-
Gosia Ksionek authored
Add columns to store project creation settings Add project creation level column in groups and default project creation column in application settings Remove obsolete line from schema Update migration with project_creation_level column existence check Rename migrations to avoid conflicts Update migration methods Update migration method
-
Nick Thomas authored
-
Andreas Brandl authored
This reverts merge request !26823
-
Imre Farkas authored
Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE
-
Brandon Labuschagne authored
Truncate existing users names which exceed 128 characters Include test for truncating users names
-
- 04 Apr, 2019 10 commits
-
-
Thong Kuah authored
As we get error with Kernel.const_get(..., false) ``` uninitialized constant Kernel::Gitlab ``` Kernel is included into Object. I guess top level constants are loaded into Object and not the Kernel module.
-
Francisco Javier López authored
We're moving from using terminology related to terminals when we refer to Websockets connections in Workhorse. It's more appropiate a concept like channel.
-
Reuben Pereira authored
Add support for defining a reactive_cache_worker_finder function that will be used by the reactive_caching_worker to generate/initialize the calling object. This allows reactive caching to work with Services where the object cannot be obtained from DB but a new object can be initialized.
-
Igor authored
- Add controls for sorting by title and date - Execute Gitaly call which now accepts sorting params for wikis
-
Gosia Ksionek authored
Chnage method used in model to make it more efficient database-wise Add additional spec
-
Sean McGivern authored
When we use the `search` param on an `IssuableFinder`, we can run into issues. We have trigram indexes to support these searches. On GitLab.com, we often see Postgres's optimiser prioritise the (global) trigram indexes over the index on `project_id`. For group and project searches, we know that it will be quicker to filter by `project_id` first, as it returns fewer rows in most cases. For group issues search, we ran into this issue previously, and went through the following iterations: 1. Use a CTE on the project IDs as an optimisation fence. This prevents the planner from disregarding the index on `project_id`. Unfortunately it breaks some types of sorting, like priority and popularity, as they sort on a joined table. 2. Use a subquery for listing issues, and a CTE for counts. The subquery - in the case of group lists - didn't help as much as the CTE, but was faster than not including it. We can safely use a CTE for counts as they don't have sorting. Now, however, we're seeing the same issue in a project context. The subquery doesn't help at all there (it would only return one row, after all). In an attempt to keep total code complexity under control, this commit removes the subquery optimisation and applies the CTE optimisation only for sorts we know that are safe. This means that for more complicated sorts (like priority and popularity), the search will continue to be very slow. If this is a high-priority issue, we can consider introducing further optimisations, but this finder is already very complicated and additional complexity has a cost. The group CTE optimisation is controlled by the same feature flag as before, `attempt_group_search_optimizations`, which is enabled by default. The new project CTE optimisation is controlled by a new feature flag, `attempt_project_search_optimizations`, which is disabled by default.
-
Shinya Maeda authored
Legacy artifacts have been correctly migrated to new place - ci_job_artifacts. Now it's time to remove the related code, but before that we should ensure it doesn't break anything by using feature flag.
-
Thong Kuah authored
Otherwise we will get really confusing behavior in development environment (where eager_load is false) where it attempts to load `Prometheus::Queries::EnvironmentQuery` when query_class_name is `Gitlab::Prometheus::Queries::EnvironmentQuery`, the `Prometheus` module is loaded from a gem but not anything in `Gitlab::Prometheus`.
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Jan Provaznik authored
Scoped labels in EE require additional changes in CE code.
-
- 03 Apr, 2019 3 commits
-
-
Bastian Blank authored
The maximum artifact size was moved into runtime config some time ago. Update the instance configuration code to read this value.
-
syasonik authored
Adds support for start and end parameters in the #additional_metrics endpoint of the EnvironmentsController. start and end are meant to be unix timestamps, per the Prometheus API (as the consumer of this endpoint will eventually be transitioned to a prometheus endpoint). This functionality is behind the :metrics_time_window feature flag for development.
-
Heinrich Lee Yu authored
Also removes specs related to the flag
-
- 02 Apr, 2019 6 commits
-
-
Imre Farkas authored
-
Heinrich Lee Yu authored
-
Patrick Bajao authored
Add `GetArchiveRequest` to git-archive params. Modifies `Git::Repository#archive_metadata` to append `path` to `ArchivePrefix` so it'll not hit the cache of repository archive when it already exists.
-
Jacob Vosmaer authored
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/59777. In earlier iterations of our implementation of Git object deduplication we thought we would be making extensive use of Git remotes in pool repositories in the future, and that we should manage these remotes carefully from the start. We now expect we only care about one remote, namely the source project. The other remotes are there only for forensic purposes. Before this MR we tried to also remove pool remotes when member projects got deleted, with the UnlinkRepositoryFromObjectPool RPC. This is fragile when there are race conditions (see https://gitlab.com/gitlab-org/gitaly/issues/1568#note_153955926). We have spent some time making this RPC less fragile in https://gitlab.com/gitlab-org/gitaly/merge_requests/1151 but looking at this problem again, I think we should just stop calling it.
-
Igor authored
Author and committers approvals are split in EE This commit provides backports for those changes This reverts commit 886f00bcba23d67e2c86591c2eb5359ef457a2f9.
-
Shinya Maeda authored
This is for merge request pipelines
-
- 01 Apr, 2019 2 commits
-
-
Francisco Javier López authored
-
João Cunha authored
- Dry create_service.rb and update_service.rb duplicated code - Remove known list of applications responsibility from services - Refactor the complex builders->builder call from base_service.rb
-