- 01 Apr, 2019 1 commit
-
-
Thong Kuah authored
Adds `# frozen_string_literal: true` to spec/models ruby files
-
- 29 Mar, 2019 3 commits
-
-
Mayra Cabrera authored
This will allow to user the term managed? on https://gitlab.com/gitlab-org/gitlab-ce/issues/56557. Managed? will be used to distinct clusters that are automatically managed by GitLab
-
Reuben Pereira authored
- Do not raise error when there are missing non-essential keys in sentry api response. - Add specs for to check for missing keys behavior.
-
Shinya Maeda authored
By using `refs/merge-requests/:iid/head` ok ok Improve naming nicely Add nice tests add nice tests fix some more revert
-
- 28 Mar, 2019 1 commit
-
-
Chris Baumbauer authored
-
- 27 Mar, 2019 3 commits
-
-
Stan Hu authored
For a given merge request, it's quite common to see duplicate FindCommit Gitaly requests because the Gitaly CommitService caches the request by the commit SHA, not by the ref name. However, most of the duplicate requests use the ref name, so the cache is never actually used in practice. This leads to unnecessary requests that slow performance. This commit allows certain callers to bypass the ref name to OID conversion in the cache. We don't do this by default because it's possible the tip of the branch changes during the commit, which would cause the caller to get stale data. This commit also forces the Ci::Pipeline to use the full ref name so that caching can work for merge requests. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
-
Nick Thomas authored
Since external diffs are likely to be a bit slower than in-database ones, add a mode that makes diffs external after they've been obsoleted by events. This should strike a balance between performance and disk space. A background cron drives the majority of migrations, since diffs become outdated through user actions.
-
Stan Hu authored
Previously when a user requested a list of projects, `Project#public_or_visible_to_user` would search all authorized projects and public/internal projects as well. However, when a user requests a specific `visibility_level` (e.g. private), that should reduce the search space, and we shouldn't need to load public/internal projects. Improves https://gitlab.com/gitlab-org/gitlab-ce/issues/59329
-
- 26 Mar, 2019 2 commits
-
-
Bob Van Landuyt authored
This changes the repository type from a binary `wiki?` to a type. So we can have more than 2 repository types. Now everywhere we called `.wiki?` and expected a boolean, we check that type.
-
Tiger Watson authored
A runner installed on a cluster will now use the cluster's `cluster_type` as its `runner_type`.
-
- 25 Mar, 2019 2 commits
-
-
Oswaldo Ferreira authored
This will be further required for supporting multi-assignees MRs
-
Sean McGivern authored
Both of these were related to groups: 1. We need to preload routes (using the `with_route` scope) if we're going to get the group's path. 2. We were counting each group's members separately. They're in the same commit because the spec for N+1 detection wouldn't pass with only one of these fixes.
-
- 22 Mar, 2019 3 commits
-
-
Kamil Trzciński authored
-
Tomasz Maczukin authored
-
Thiago Presa authored
-
- 21 Mar, 2019 5 commits
-
-
Luke Duncalfe authored
Previously the code for excluding merge commits from the commit collection (CommitCollection#without_merge_commits) was not working when the commits had come from a merge request. Now that this has been fixed, these tests fails. They should always have been written to exclude merge commits when comparing.
-
Luke Duncalfe authored
Allow incomplete commit records to load their full data from gitaly. Commits can be based on a Hash of data retrieved from PostgreSQL, and this data can be intentionally incomplete in order to save space. A new method #gitaly? has been added to Gitlab::Git::Commit, which returns true if the underlying data source of the Commit is a Gitaly::GitCommit. CommitCollection now has a method #enrich which replaces non-gitaly commits in place with commits from gitaly. CommitCollection#without_merge_commits has been updated to call this method, as in order to determine a merge commit we need to have parent data. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
-
Nathan Friend authored
This commit updates the pipeline block that appears on the merge request page to include information that will be exposed by the API as part of the post-merge pipeline feature.
-
Sean McGivern authored
Revert "Merge branch '58805-allow-incomplete-commit-data-to-be-fetched-from-collection' into 'master'" This reverts merge request !26144
-
James Fargher authored
Deploy boards now will check for app.gitlab.com/env and app.gitlab.com/app
-
- 20 Mar, 2019 8 commits
-
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Oswaldo Ferreira authored
Implements the filtering logic for `suggestion:-x+y` syntax.
-
Tiger authored
Instead of creating a Kubernetes namespace on every cluster related to a project, only create one on the cluster the project is about to be deployed to.
-
Tiger authored
The flag is on by default, but allows us to revert back to the old behaviour if we encounter any problems.
-
Tiger authored
Introduces the concept of Prerequisites for a CI build. If a build has unmet prerequisites it will go through the :preparing state before being made available to a runner. There are no actual prerequisites yet, so current behaviour is unchanged.
-
Tiger authored
Introduces a new status for builds between :created and :pending that will be used when builds require one or more prerequisite actions to be completed before being picked up by a runner (such as creating Kubernetes resources before deploying). The existing :created > :pending transition is unchanged, so only builds that require preparation will use the :preparing status.
-
- 19 Mar, 2019 2 commits
-
-
Rémy Coutable authored
This reverts merge request !26183
-
Lin Jen-Shin authored
-
- 18 Mar, 2019 3 commits
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Luke Duncalfe authored
Previously the code for excluding merge commits from the commit collection (CommitCollection#without_merge_commits) was not working when the commits had come from a merge request. Now that this has been fixed, these tests fails. They should always have been written to exclude merge commits when comparing.
-
Luke Duncalfe authored
Allow incomplete commit records to load their full data from gitaly. Commits can be based on a Hash of data retrieved from PostgreSQL, and this data can be intentionally incomplete in order to save space. A new method #gitaly? has been added to Gitlab::Git::Commit, which returns true if the underlying data source of the Commit is a Gitaly::GitCommit. CommitCollection now has a method #enrich which replaces non-gitaly commits in place with commits from gitaly. CommitCollection#without_merge_commits has been updated to call this method, as in order to determine a merge commit we need to have parent data. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
-
- 17 Mar, 2019 1 commit
-
-
Stan Hu authored
Previously if a user submitted a blank commit message, Gitaly would error out with `3:WikiWritePage: empty CommitDetails.Message` since Gitaly checks whether any content is present for the message. We now use a default commit message if a user leaves it blank. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59065
-
- 14 Mar, 2019 3 commits
-
-
Tiger authored
-
Stan Hu authored
If a diff happened to include a single null byte anywhere, insertion into the database would fail with an Error 500 since the column is text and not a byte array. To fix this, we mark the diff as binary if we detect a single null byte and Base64-encode it. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57710
-
Heinrich Lee Yu authored
Makes `Note#edited?` return `false` when the note body was not edited
-
- 13 Mar, 2019 3 commits
-
-
Shinya Maeda authored
Add spec Fix Fix Add changelog Drop attached Remove attached Update changelog ok
-
Heinrich Lee Yu authored
We already check max boards in the create service. This is not used.
-
Shinya Maeda authored
Make it sane Include merge ref head Fix union Improve a bit Add spec remove add spec Add changelog fix coding offence Apply suggestion to spec/models/merge_request_spec.rb ok ok Fix Fix spec Fix spec fix Simplify the things Memoize OK a
-