1. 01 Apr, 2019 1 commit
  2. 29 Mar, 2019 3 commits
  3. 28 Mar, 2019 1 commit
  4. 27 Mar, 2019 3 commits
    • Stan Hu's avatar
      Allow ref name caching CommitService#find_commit · a2c8b2ee0d24
      Stan Hu authored
      For a given merge request, it's quite common to see duplicate FindCommit
      Gitaly requests because the Gitaly CommitService caches the request by
      the commit SHA, not by the ref name. However, most of the duplicate
      requests use the ref name, so the cache is never actually used in
      practice. This leads to unnecessary requests that slow performance.
      
      This commit allows certain callers to bypass the ref name to
      OID conversion in the cache. We don't do this by default because it's
      possible the tip of the branch changes during the commit, which
      would cause the caller to get stale data.
      
      This commit also forces the Ci::Pipeline to use the full ref name
      so that caching can work for merge requests.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
      a2c8b2ee0d24
    • Nick Thomas's avatar
      Allow external diffs to be used conditionally · 3be184a5d623
      Nick Thomas authored
      Since external diffs are likely to be a bit slower than in-database
      ones, add a mode that makes diffs external after they've been obsoleted
      by events. This should strike a balance between performance and disk
      space.
      
      A background cron drives the majority of migrations, since diffs become
      outdated through user actions.
      3be184a5d623
    • Stan Hu's avatar
      Optimize /api/v4/projects endpoint for visibility level · 8b3569d11af5
      Stan Hu authored
      Previously when a user requested a list of projects,
      `Project#public_or_visible_to_user` would search all authorized projects
      and public/internal projects as well. However, when a user requests a
      specific `visibility_level` (e.g. private), that should reduce the
      search space, and we shouldn't need to load public/internal projects.
      
      Improves https://gitlab.com/gitlab-org/gitlab-ce/issues/59329
      8b3569d11af5
  5. 26 Mar, 2019 2 commits
  6. 25 Mar, 2019 2 commits
  7. 22 Mar, 2019 3 commits
  8. 21 Mar, 2019 5 commits
    • Luke Duncalfe's avatar
      Scope out merge commits in MergeRequest spec · 2165a3717d1f
      Luke Duncalfe authored
      Previously the code for excluding merge commits from the commit
      collection (CommitCollection#without_merge_commits) was not working
      when the commits had come from a merge request. Now that this has been
      fixed, these tests fails. They should always have been written to
      exclude merge commits when comparing.
      2165a3717d1f
    • Luke Duncalfe's avatar
      Enrich commits with full data in CommitCollection · abd2ee50323c
      Luke Duncalfe authored
      Allow incomplete commit records to load their full data from gitaly.
      
      Commits can be based on a Hash of data retrieved from PostgreSQL, and
      this data can be intentionally incomplete in order to save space.
      
      A new method #gitaly? has been added to Gitlab::Git::Commit, which
      returns true if the underlying data source of the Commit is a
      Gitaly::GitCommit.
      
      CommitCollection now has a method #enrich which replaces non-gitaly
      commits in place with commits from gitaly.
      
      CommitCollection#without_merge_commits has been updated to call this
      method, as in order to determine a merge commit we need to have parent
      data.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
      abd2ee50323c
    • Nathan Friend's avatar
      Update merge request widget pipeline block · 311227fd8124
      Nathan Friend authored
      This commit updates the pipeline block that appears on the merge request
      page to include information that will be exposed by the API as part of
      the post-merge pipeline feature.
      311227fd8124
    • Sean McGivern's avatar
      Revert "Merge branch... · 9ba9fc06dccc
      Sean McGivern authored
      Revert "Merge branch '58805-allow-incomplete-commit-data-to-be-fetched-from-collection' into 'master'"
      
      This reverts merge request !26144
      9ba9fc06dccc
    • James Fargher's avatar
      Update dashboards to additionally use new environment selector · fbf36cc66828
      James Fargher authored
      Deploy boards now will check for app.gitlab.com/env and
      app.gitlab.com/app
      fbf36cc66828
  9. 20 Mar, 2019 8 commits
  10. 19 Mar, 2019 2 commits
  11. 18 Mar, 2019 3 commits
    • Rémy Coutable's avatar
      New Repository#insights_config method · 7c52dc02c080
      Rémy Coutable authored
      
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
      7c52dc02c080
    • Luke Duncalfe's avatar
      Scope out merge commits in MergeRequest spec · afe1fc1b534f
      Luke Duncalfe authored
      Previously the code for excluding merge commits from the commit
      collection (CommitCollection#without_merge_commits) was not working
      when the commits had come from a merge request. Now that this has been
      fixed, these tests fails. They should always have been written to
      exclude merge commits when comparing.
      afe1fc1b534f
    • Luke Duncalfe's avatar
      Enrich commits with full data in CommitCollection · 47d1456440c9
      Luke Duncalfe authored
      Allow incomplete commit records to load their full data from gitaly.
      
      Commits can be based on a Hash of data retrieved from PostgreSQL, and
      this data can be intentionally incomplete in order to save space.
      
      A new method #gitaly? has been added to Gitlab::Git::Commit, which
      returns true if the underlying data source of the Commit is a
      Gitaly::GitCommit.
      
      CommitCollection now has a method #enrich which replaces non-gitaly
      commits in place with commits from gitaly.
      
      CommitCollection#without_merge_commits has been updated to call this
      method, as in order to determine a merge commit we need to have parent
      data.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
      47d1456440c9
  12. 17 Mar, 2019 1 commit
  13. 14 Mar, 2019 3 commits
  14. 13 Mar, 2019 3 commits