Read about our upcoming Code of Conduct on this issue

  1. 10 May, 2017 1 commit
  2. 08 May, 2017 2 commits
    • Toon Claes's avatar
      Devise can assign trackable fields, but only allow writes once/hour · 5e0b940d55de
      Toon Claes authored
      Not assigning the trackable fields seems to cause strange side-effects.
    • Toon Claes's avatar
      Limit `update_tracked_fields` to write to database once/hour · 4e044b8424db
      Toon Claes authored
      Every time a user logs in or out, the Trackable attributes are written to the
      database. This is causing a lot of load on the database, for data that isn't
      really critical.
      So to avoid the database being hammered, add a Gitlab::ExclusiveLease before
      writing trackable attributes to the database. This lease expires after an hour,
      so only when the attributes were written more than an hour ago, they can be
      written again. Otherwise they are ignored.
  3. 05 May, 2017 1 commit
  4. 04 May, 2017 2 commits
  5. 01 May, 2017 1 commit
  6. 26 Apr, 2017 1 commit
  7. 19 Apr, 2017 1 commit
  8. 18 Apr, 2017 1 commit
  9. 11 Apr, 2017 1 commit
  10. 09 Apr, 2017 1 commit
  11. 06 Apr, 2017 5 commits
    • Timothy Andrew's avatar
      Implement review comments from @DouweM for !10467. · 5f3bbe5114ae
      Timothy Andrew authored
      1. Have `MigrateToGhostUser` be a service rather than a mixed-in module, to keep
         things explicit. Specs testing the behavior of this class are moved into a
         separate service spec file.
      2. Add a `user.reported_abuse_reports` association to make the
         `migrate_abuse_reports` method more consistent with the other `migrate_`
    • Timothy Andrew's avatar
      Fix a bug with the User#abuse_report association. · 8b9f2f1e92c4
      Timothy Andrew authored
      1. The foreign key was not explicitly specified on the association.
      2. The `AbuseReport` model contains two references to user - `reporter_id` and
      3. `user.abuse_report` is supposed to return the single abuse report where
         `user_id` refers to the given user.
      Bug Description
      1. `user.abuse_report` would return an abuse report where `reporter_id` referred
         to the current user, if such an abuse report was present.
      2. This implies a slightly more serious bug as well:
         - Assume User A filed an abuse report against User B
         - We have an abuse report where `reporter_id` is User A and `user_id` is User B
         - If User A is updated (`user_a.block`, for example), the abuse report would
           also be updated, such that both `reporter_id` _and_ `user_id` point to User A.
      Explicitly declare the foreign key `user_id` in the `has_one` declaration
    • Alexis Reigel's avatar
      rename cache db column with `_cached` suffix · 2256eb9d048c
      Alexis Reigel authored
    • Alexis Reigel's avatar
      check all groups for 2fa requirement · e6b5fb993710
      Alexis Reigel authored
    • Markus Koller's avatar
      Support 2FA requirement per-group · 8da987130386
      Markus Koller authored
  12. 30 Mar, 2017 1 commit
  13. 27 Mar, 2017 1 commit
  14. 24 Mar, 2017 1 commit
  15. 17 Mar, 2017 1 commit
  16. 13 Mar, 2017 1 commit
  17. 09 Mar, 2017 1 commit
  18. 06 Mar, 2017 1 commit
  19. 05 Mar, 2017 1 commit
  20. 28 Feb, 2017 1 commit
  21. 24 Feb, 2017 4 commits
    • Timothy Andrew's avatar
      Fix specs for the ghost user feature. · 2c79a407fc30
      Timothy Andrew authored
    • Timothy Andrew's avatar
      Use a `ghost` boolean to track ghost users. · 47947705eb3a
      Timothy Andrew authored
      Rather than using a separate `ghost` state. This lets us have the benefits of
      both ghost and blocked users (ghost: true, state: blocked) without having to
      rewrite a number of queries to include cases for `state: ghost`.
    • Timothy Andrew's avatar
      Extract code from `Namespace#clean_path` for ghost user generation. · 2a04efbffa1c
      Timothy Andrew authored
      1. Create a `Uniquify` class, which generalizes the process of generating unique
         strings, by accepting a function that defines what "uniqueness" means in a
         given context.
      2. WIP: Make sure tests for `Namespace` pass, add more if necessary.
      3. WIP: Add tests for `Uniquify`
    • Timothy Andrew's avatar
      Deleting a user shouldn't delete associated issues. · fa29d2385819
      Timothy Andrew authored
      - "Associated" issues are issues the user has created + issues that the
        user is assigned to.
      - Issues that a user owns are transferred to a "Ghost User" (just a
        regular user with `state = 'ghost'` that is created when
        `User.ghost` is called).
      - Issues that a user is assigned to are moved to the "Unassigned" state.
      - Fix a spec failure in `profile_spec` — a spec was asserting that when a user
        is deleted, `User.count` decreases by 1. After this change, deleting a user
        creates (potentially) a ghost user, causing `User.count` not to change. The
        spec has been updated to look for the relevant user in the assertion.
  22. 23 Feb, 2017 5 commits
  23. 15 Feb, 2017 2 commits
  24. 13 Feb, 2017 1 commit
  25. 08 Feb, 2017 1 commit
  26. 06 Feb, 2017 1 commit