- 05 Dec, 2018 6 commits
-
-
Francisco Javier López authored
-
🤖 GitLab Bot 🤖 authored
This reverts commit 22954f220231281360377922b709efb904559949
-
Shinya Maeda authored
-
Ash McKenzie authored
LfsToken::HMACToken#token_valid?() will be examined and if false, look in redis via LfsToken::LegacyRedisDeviseToken#token_valid?().
-
Ash McKenzie authored
-
Nick Thomas authored
AES-256-GCM cipher mode requires a key that is exactly 32 bytes long. We already handle the case when the key is too long, by truncating, but the key can also be too short in some installations. Switching to a key that is always exactly the right length (by virtue of right-padding ASCII 0 characters) allows encryption to proceed, without breaking backward compatibility. When the key is too short, encryption fails with an `ArgumentError`, causing the web hooks functionality to be unusable. As a result, zero rows can exist with values encrypted with the too-short key. When the key is too long, it is silently truncated. In this case, the key is unchanged, so values encrypted with the new too-long key will still be successfully decrypted.
-
- 04 Dec, 2018 7 commits
-
-
Oswaldo Ferreira authored
-
Shinya Maeda authored
Currently, if a job does not have only/except policies, the policy is considered as an unspecified state, and therefore the job is executed regardless of how it's executed and which branch/tags are targetted. Ideally, this should be specified as only: ['branches', 'tags'], as it indicates that unspecified policy jobs are meant to run on any git references.
-
Francisco Javier López authored
-
James Lopez authored
-
Grzegorz Bizon authored
-
Fabio Busatto authored
This reverts merge request !23165
-
Thong Kuah authored
If the service fails mid-point, then we should be able to re-run this service. So, detect presence of any previously created Kubernetes resource and update or create accordingly. Fix specs accordingly. In the case of finalize_creation_service_spec.rb, I decided to stub out the async worker rather than maintaining individual stubs for various kubeclient calls for that worker. Also add test cases for group clusters
-
- 03 Dec, 2018 16 commits
-
-
Michael Kozono authored
These changes make the code more reusable, testable, and most importantly, overrideable.
-
Andreas Brandl authored
The numbers in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22650#note_117645395 are quite promising with that target.
-
Andreas Brandl authored
This improves readability quite a bit.
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Andreas Brandl authored
A tablesample count executes in two phases: * Estimate table sizes based on reltuples. * Based on the estimate: * If the table is considered 'small', execute an exact relation count. * Otherwise, count on a sample of the table using TABLESAMPLE. The size of the sample is chosen in a way that we always roughly scan the same amount of rows (see TABLESAMPLE_ROW_TARGET).
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Andreas Brandl authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 02 Dec, 2018 1 commit
-
-
Thong Kuah authored
This should help debug issues like https://gitlab.com/gitlab-org/gitlab-ce/issues/54760
-
- 30 Nov, 2018 2 commits
-
-
Dylan Griffith authored
Having an invalid KUBECONFIG without a token in it is not helpful. This only became possible recently now that we are creating a separate namespace and service account (and hence token) to send to the runners. This led to somewhat surprising results when troubleshooting https://gitlab.com/gitlab-org/gitlab-ce/issues/53879 as I found that the KUBECONFIG was still being passed but KUBE_TOKEN was not. These things really should have been linked. Furthermore now that we are also using the [presence of KUBECONFIG to decide whether or not to run build steps in Auto DevOps](https://gitlab.com/gitlab-org/gitlab-ce/blob/294d15be3e9497e7b67e1f9131ce9d5c0d68406c/lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml#L164) I think it makes even more sense to ensure that KUBECONFIG is a complete config if passed to a job.
-
Brett Walker authored
-
- 29 Nov, 2018 7 commits
-
-
Kamil Trzciński authored
This decouples Ci::Config to provide a common interface for handling user configuration files.
-
Imre Farkas authored
Adds gitlab.impersonation_enabled config option defaulting to true to keep the current default behaviour. Only the act of impersonation is modified, impersonation token management is not affected.
-
Steve Azzopardi authored
[11.5] Fix SSRF in project integrations See merge request gitlab/gitlabhq!2611
-
Cindy Pallares authored
[master] Fix CRLF issue in UrlValidator See merge request gitlab/gitlabhq!2627
-
Cindy Pallares authored
[master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request" See merge request gitlab/gitlabhq!2583
-
Cindy Pallares authored
[master] XSS in markdown following unrecognized HTML element Closes #2732 See merge request gitlab/gitlabhq!2599
-
Cindy Pallares authored
[master] Stored XSS for Environments Closes #2727 See merge request gitlab/gitlabhq!2594
-
- 28 Nov, 2018 1 commit
-
-
Francisco Javier López authored
-