- 17 Sep, 2018 1 commit
-
-
Marcel Amirault authored
-
- 14 Sep, 2018 18 commits
-
-
Robert Speicher authored
-
Martin Wortschack authored
-
Yorick Peterse authored
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19625 some changes were introduced that do not meet our abstraction reuse rules. This commit cleans up some of these changes so the requirements are met. Most notably, sorting of the runners in Admin::RunnersFinder has been delegated to Ci::Runner.order_by, similar to how we order data in models that include the Sortable module. If we need more sort orders in the future we can include Sortable and have Ci::Runner.order_by call `super` to delegate to Sortable.order_by.
-
Nick Thomas authored
-
Paul Slaughter authored
-
Thong Kuah authored
In our case it's 'default'.
-
Thong Kuah authored
This is similar to the option in the Add Existing cluster form
-
Thong Kuah authored
This also solves the async nature of the automatic creation of default service tokens for service accounts. It also makes explicit which service account token we always use. create cluster role binding only if the provider has legacy_abac disabled.
-
Thong Kuah authored
Drive creation of a rbac platform_kubernetes off provider#legacy_abac so that there is one single source of truth.
-
Thong Kuah authored
Keeps existing behaviour for ABAC cluster
-
Thong Kuah authored
Explicitly persist the legacy_abac value of the cluster_provider_gcp so that we can disable abac if the `:rbac_clusters` feature flag is enabled
-
Thong Kuah authored
Fix spec warning: removing `initialize' may cause serious problems Actually verify that `service.create_cluster` is called with expected request_body and other args
-
Thong Kuah authored
Only create new service account with cluster-admin clusterrolebinding for when we have the rbac cluster FF enabled. This syncs up with `authorization_type`.
-
Thong Kuah authored
Adds "More information" link from the RBAC cluster form element to the documentation from the previous commit
-
Thong Kuah authored
This is the same as with adding an existing cluster
-
Thong Kuah authored
-
Thong Kuah authored
When provisioning a new cluster, create gitlab service account so that GitLab can perform operations in a RBAC-enabled cluster. Correspondingly, use the token of the gitlab service account, vs the default service account token which will have no privs.
-
Thong Kuah authored
This is in preparation to share some common code with another service which will also need a kubeclient utilizing master username and password
-
- 13 Sep, 2018 10 commits
-
-
Dmitriy Zaporozhets authored
This reverts merge request !21341
-
Brett Walker authored
By default, we now strip images in the 'first_line_in_markdown' method. This keeps images from being displayed in the one-liner of both todo and project activity panels. Although not currently used, we allow images to be preserved with the allow_images: true options.
-
Steve Azzopardi authored
closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50461
-
Steve Azzopardi authored
closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50460
-
Chantal Rollison authored
-
Phil Hughes authored
Instead of relying on a global method, we now emit an event on the MR widget that tells it to check the status
-
Alexis Reigel authored
-
Martin Wortschack authored
-
André Luís authored
-
Phil Hughes authored
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51370
-
- 12 Sep, 2018 9 commits
-
-
🙈 jacopo beschi 🙉 authored
-
Stan Hu authored
Adding extra whitespace in the DSN could prevent the server from starting due to InvalidURIErrors in sentry-raven. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49621
-
Matija Čupić authored
-
Alin Ciciu authored
-
Phil Hughes authored
After resolving a discussion on a merge request page the merge request widget state would not get updated meaning users would need to refresh the page to merge (if that option is enabled in the projects settings) https://gitlab.com/gitlab-org/gitlab-ce/issues/42882
-
Alejandro Rodríguez authored
-
Alexis Reigel authored
-
Steve Azzopardi authored
Create new entity called TriggerVariablesEnitity for trigger variables, to aid reuseablity in the future. Update JSON schema to include trigger information in the response. Refactor rspec tests a bit to reduce duplication and for the `context` to make sense. closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50989
-
Adriel Santiago authored
-
- 11 Sep, 2018 2 commits
-
-
Clement Ho authored
-
gfyoung authored
Partially addresses #47424.
-