1. 18 May, 2018 1 commit
  2. 17 May, 2018 31 commits
    • Annabel Gray's avatar
      Merge branch 'fix/assignee-name-wrap' into 'master' · ee0db59c31b5
      Annabel Gray authored
      fix / assigne username wrapping problem has been fixed
      
      See merge request gitlab-org/gitlab-ce!18986
      ee0db59c31b5
    • Murat Dogan's avatar
      a02c18441ae2
    • Annabel Gray's avatar
      Merge branch '39584-nesting-depth-5-pages-pipelines' into 'master' · 6d1c9c40a53e
      Annabel Gray authored
      NestingDepth (level 5) in pages/pipelines.scss
      
      See merge request gitlab-org/gitlab-ce!18830
      6d1c9c40a53e
    • Annabel Gray's avatar
      Merge branch 'dz-fix-list-bottom-margin' into 'master' · 06fc79e550b2
      Annabel Gray authored
      Fix group lists visual
      
      See merge request gitlab-org/gitlab-ce!19010
      06fc79e550b2
    • Mayra Cabrera's avatar
      Merge branch 'sh-remove-deprecation-warnings-from-com' into 'master' · db79f105cb67
      Mayra Cabrera authored
      Conditionally enable deprecation log messages
      
      Closes #46158 and gitlab-com/infrastructure#4228
      
      See merge request gitlab-org/gitlab-ce!18997
      db79f105cb67
    • Stan Hu's avatar
      d8f0d4827da3
    • Rémy Coutable's avatar
      Merge branch '46193-fix-big-estimate' into 'master' · 2425fb3cb828
      Rémy Coutable authored
      Resolve "Estimating a large amount results in a server error 500"
      
      Closes #46193
      
      See merge request gitlab-org/gitlab-ce!18964
      2425fb3cb828
    • Annabel Gray's avatar
      Merge branch '46381-dropdown-mr-widget' into 'master' · 47ce4321d693
      Annabel Gray authored
      Resolve "Dropdown actions in mini pipeline graph in mr widget don't work"
      
      Closes #46381
      
      See merge request gitlab-org/gitlab-ce!18976
      47ce4321d693
    • Jacopo's avatar
      Fixes 500 error on /estimate BIG_VALUE · 065e2f9d5453
      Jacopo authored
      065e2f9d5453
    • Rémy Coutable's avatar
      Merge branch 'order_groups' into 'master' · d3b31c4c1c0a
      Rémy Coutable authored
      Fix: Use case in-sensitive ordering by name for groups
      
      See merge request gitlab-org/gitlab-ce!18553
      d3b31c4c1c0a
    • Harish Ved's avatar
      2342d3c42dc2
    • Robert Speicher's avatar
      Merge branch '6020-extract-ee-specific-controller-lines' into 'master' · 7f346170a9f1
      Robert Speicher authored
      [CE]  Resolve "Extract EE specific files/lines for some controllers"
      
      See merge request gitlab-org/gitlab-ce!18994
      7f346170a9f1
    • Dmitriy Zaporozhets's avatar
      Fix group lists visual · 34507461e352
      Dmitriy Zaporozhets authored
      
      
      * Reset p bottom margin for group lists to fix vertical alignment
      * Remove double border for group lists to be consistent with project
      lists
      Signed-off-by: default avatarDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
      34507461e352
    • Grzegorz Bizon's avatar
      Merge branch 'pipelines-index-performance' into 'master' · b5949c74cdcc
      Grzegorz Bizon authored
      Improve performance of Projects::PipelinesController#index
      
      See merge request gitlab-org/gitlab-ce!18427
      b5949c74cdcc
    • Filipa Lacerda's avatar
      Merge branch 'master' into 46381-dropdown-mr-widget · f4f3201ee129
      Filipa Lacerda authored
      * master: (40 commits)
        Add changelog
        Update quick_start_guide.md
        Resolve "Opening Project with invite but without accepting leads to 404 error page"
        Respect the inheritance chain between Ci::Build and CommitStatus
        Remove unneccessary imports
        fixed copy to cliboard button in embedded snippets
        Fix Error 500 viewing admin page due to statement timeouts
        Grant privileges after database is created
        Only setup db in the first checkout!
        Project Sidebar: Split CI/CD into CI/CD and Operations
        Fix GPM content types for Doorkeeper
        Workhorse to send raw diff and patch for commits
        Refactor out duplication in runner_policy.rb
        Remove unnecessary runner.is_shared? checks in api because they are handled by policy
        Allow admin to assign shared runner to project through API
        Change policy list_runner_jobs -> read_runner
        Rename User#ci_authorized_runners -> ci_owned_runners
        Improve efficiency of authorized_runner policy query
        Use can? policies for lib/api/runners.rb
        Allow group runners to be viewed/edited in API
        ...
      f4f3201ee129
    • Grzegorz Bizon's avatar
      Merge branch '46177-fix-present-on-generic-commit-status' into 'master' · b4bd3ed24833
      Grzegorz Bizon authored
      Resolve "NoMethodError: undefined method `present' for #<GenericCommitStatus:0x00007f6eacf34a40>"
      
      Closes #46177
      
      See merge request gitlab-org/gitlab-ce!18979
      b4bd3ed24833
    • Achilleas Pipinellis's avatar
      Merge branch... · ba0238cd5900
      Achilleas Pipinellis authored
      Merge branch 'docs/46042-document-that-project-templates-can-be-used-with-auto-devops' into 'master'
      
      Resolve "Document that Project Templates can be used with Auto DevOps"
      
      Closes #46042
      
      See merge request gitlab-org/gitlab-ce!19009
      ba0238cd5900
    • Mayra Cabrera's avatar
      Add changelog · a111b4663e42
      Mayra Cabrera authored
      a111b4663e42
    • Fabio Busatto's avatar
      Update quick_start_guide.md · 1e060e6cf6b3
      Fabio Busatto authored
      1e060e6cf6b3
    • Yorick Peterse's avatar
      Added changelog for pipelines page performance · 37524840dd6e
      Yorick Peterse authored
      37524840dd6e
    • Yorick Peterse's avatar
      Exclude coverage data from the pipelines page · ad2321e4d0af
      Yorick Peterse authored
      When displaying a project's pipelines
      (Projects::PipelinesController#index) we now exclude the coverage data.
      This data was not used by the frontend, yet getting it would require one
      SQL query per pipeline. These queries in turn could be quite expensive
      on GitLab.com.
      ad2321e4d0af
    • Yorick Peterse's avatar
      Preload pipeline data for project pipelines · 3c64ad01bc13
      Yorick Peterse authored
      When displaying the pipelines of a project we now preload the following
      data:
      
      1. Authors of the commits that belong to these pipelines
      2. The number of warnings per pipeline, which is used by
         Ci::Pipeline#has_warnings?
      
      == Commit Authors
      
      Previously this data was queried for every Commit separately, leading to
      20 SQL queries being executed in the worst case. With an average of 3 to
      5 milliseconds per SQL query this could result in 100 milliseconds being
      spent in _just_ getting Commit authors.
      
      To preload this data Commit#author now uses BatchLoader (through
      Commit#lazy_author), and a separate module
      Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded
      before they are used.
      
      == Number of warnings
      
      This changes Ci::Pipeline#has_warnings? so it supports preloading of the
      number of warnings per pipeline. This removes the need for executing a
      COUNT(*) query for every pipeline just to see if it has any warnings or
      not.
      3c64ad01bc13
    • Yorick Peterse's avatar
      Limit the number of pipelines to count · 24c1b5d229da
      Yorick Peterse authored
      When displaying the project pipelines dashboard we display a few tabs
      for different pipeline states. For every such tab we count the number of
      pipelines that belong to it. For large projects such as GitLab CE this
      means having to count over 80 000 rows, which can easily take between 70
      and 100 milliseconds per query.
      
      To improve this we apply a technique we already use for search results:
      we limit the number of rows to count. The current limit is 1000, which
      means that if more than 1000 rows are present for a state we will show
      "1000+" instead of the exact number. The SQL queries used for this
      perform much better than a regular COUNT, even when a project has a lot
      of pipelines.
      
      Prior to these changes we would end up running a query like this:
      
          SELECT COUNT(*)
          FROM ci_pipelines
          WHERE project_id = 13083
          AND status IN ('success', 'failed', 'canceled')
      
      This would produce a plan along the lines of the following:
      
          Aggregate  (cost=3147.55..3147.56 rows=1 width=8) (actual time=501.413..501.413 rows=1 loops=1)
            Buffers: shared hit=17116 read=861 dirtied=2
            ->  Index Only Scan using index_ci_pipelines_on_project_id_and_ref_and_status_and_id on ci_pipelines  (cost=0.56..2984.14 rows=65364 width=0) (actual time=0.095..490.263 rows=80388 loops=1)
                  Index Cond: (project_id = 13083)
                  Filter: ((status)::text = ANY ('{success,failed,canceled}'::text[]))
                  Rows Removed by Filter: 2894
                  Heap Fetches: 353
                  Buffers: shared hit=17116 read=861 dirtied=2
          Planning time: 1.409 ms
          Execution time: 501.519 ms
      
      Using the LIMIT count technique we instead run the following query:
      
          SELECT COUNT(*)
          FROM (
              SELECT 1
              FROM ci_pipelines
              WHERE project_id = 13083
              AND status IN ('success', 'failed', 'canceled')
              LIMIT 1001
          ) for_count
      
      This query produces the following plan:
      
          Aggregate  (cost=58.77..58.78 rows=1 width=8) (actual time=1.726..1.727 rows=1 loops=1)
            Buffers: shared hit=169 read=15
            ->  Limit  (cost=0.56..46.25 rows=1001 width=4) (actual time=0.164..1.570 rows=1001 loops=1)
                  Buffers: shared hit=169 read=15
                  ->  Index Only Scan using index_ci_pipelines_on_project_id_and_ref_and_status_and_id on ci_pipelines  (cost=0.56..2984.14 rows=65364 width=4) (actual time=0.162..1.426 rows=1001 loops=1)
                        Index Cond: (project_id = 13083)
                        Filter: ((status)::text = ANY ('{success,failed,canceled}'::text[]))
                        Rows Removed by Filter: 9
                        Heap Fetches: 10
                        Buffers: shared hit=169 read=15
          Planning time: 1.832 ms
          Execution time: 1.821 ms
      
      While this query still uses a Filter for the "status" field the number
      of rows that it may end up filtering (at most 1001) is small enough that
      an additional index does not appear to be necessary at this time.
      
      See https://gitlab.com/gitlab-org/gitlab-ce/issues/43132#note_68659234
      for more information.
      24c1b5d229da
    • Filipa Lacerda's avatar
      Fix eslint · 1285090f6347
      Filipa Lacerda authored
      1285090f6347
    • Filipa Lacerda's avatar
      Moves string to a constant · 2959f57a5e6f
      Filipa Lacerda authored
      2959f57a5e6f
    • Douwe Maan's avatar
      Merge branch '42531-open-invite-404' into 'master' · 713ff3b3514b
      Douwe Maan authored
      Resolve "Opening Project with invite but without accepting leads to 404 error page"
      
      Closes #42531
      
      See merge request gitlab-org/gitlab-ce!17634
      713ff3b3514b
    • 🙈  jacopo beschi 🙉's avatar
    • Douwe Maan's avatar
      Merge branch 'ce-5980-add-ce-upgrade-ee-test' into 'master' · 0fbcb66eb2c4
      Douwe Maan authored
      CE: Add jobs to verify that migrating from CE to EE works
      
      See merge request gitlab-org/gitlab-ce!18909
      0fbcb66eb2c4
    • Grzegorz Bizon's avatar
      Merge branch 'zj-workhorse-commit-patch-diff' into 'master' · 413db39b30ae
      Grzegorz Bizon authored
      Workhorse to send raw diff and patch for commits
      
      Closes gitaly#1196
      
      See merge request gitlab-org/gitlab-ce!18974
      413db39b30ae
    • Phil Hughes's avatar
      Merge branch 'remove-css-imports' into 'master' · 27e585748e66
      Phil Hughes authored
      Remove unneccessary imports
      
      See merge request gitlab-org/gitlab-ce!18993
      27e585748e66
    • Phil Hughes's avatar
      Merge branch 'jivl-add-dot-system-notes' into 'master' · 7331404e20bb
      Phil Hughes authored
      Add dot to separate system notes content
      
      Closes #45676
      
      See merge request gitlab-org/gitlab-ce!18864
      7331404e20bb
  3. 16 May, 2018 8 commits