- 30 Aug, 2019 1 commit
-
-
Ash McKenzie authored
rails_helper.rb's only logic was to require spec_helper.rb.
-
- 28 Aug, 2019 31 commits
-
-
Michael Kozono authored
Instead of sending varied data to Gitaly, and making Gitaly construct various messages, build the messages first and have Gitaly print either basic messages or alert messages, in the order they come. Depends on https://gitlab.com/gitlab-org/gitaly/merge_requests/1410
-
Sean McGivern authored
-
Igor authored
- Extract MR fields for notes into a separate serializer - Check if pipelines are empty via count
-
Felipe Artur authored
Persists if a board list is collapsed for each user.
-
Illya Klymov authored
-
Jacob Vosmaer authored
-
Jacopo authored
-
Sean McGivern authored
This key is useful to reduce the amount of logic needed on the frontend: if `has_warnings` is true, then the frontend knows that the request in question has warnings for some metric.
-
Sean McGivern authored
For each DetailedView subclass, we add a `warnings` array to: 1. The top-level response. 2. Each individual call under the `details` key. We use the `.thresholds` hash on the DetailedView to determine what's a warning. If that hash is empty (the default), then the warnings array will always be empty.
-
Victor Zagorodny authored
A new param with_security_reports was added to GET /groups/:id/projects API and the code to support this logic in GroupProjectsFinder and Project model. Also, a DB index was added to ci_job_artifacts table to speed up the search of security reports artifacts for projects
-
Adam Hegyi authored
This change sets NOT NULL constraint to users.private profile. closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57538
-
jakeburden authored
Only display time if the job has deployed Update JS tests for displaying job deployment time Simplify boolean check in deployedDate
-
Arun Kumar Mohan authored
-
David Wilkins authored
- local tests that assume certain parameters to queries from QueryRecorder fail. These same tests don't fail in the runners, and I can't tell why. This fixes the local failures
-
Payton Burdette authored
Add changelog entry Remove unnecessary test checking for form value Translations updated for gitlab.pot Use proper format on changelog entry
-
Stan Hu authored
When a issue is moved from one project to another, all associated Markdown text is rewritten in the context of the new project. If the note contained a link to a commit URL, `CommitRewriter#rewrite` would fail because `Commit#link_reference_pattern` would match `nil` `commit` values in the HTML generated from the Markdown. These `nil` values were passed along to `Project#commits_by` because `Commit#reference_valid?` was always returning `true`. To prevent this issue from happening, we tighten up the check for `Commit#reference_valid?` to look for valid SHA values. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66666
-
Vitali Tatarintev authored
Improve specs output readability by replacing `it_behaves_like` with `include_examples` in `BeSuccessMatcher`
-
Jeremy Jackson authored
This also restructures how and where the configuration for Snowplow lives.
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
Former shared examples were used only once. Inlining them makes tests more clear.
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
Use Rubocop's Include instead of manually checking the matcher in controllers specs.
-
Vitali Tatarintev authored
BeSuccessMatcher now supports following examples: ``` expect(response).to be_success expect(response).to_not be_success expect(response).not_to be_success is_expected.to be_success is_expected.to_not be_success is_expected.not_to be_success ```
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
Prevent using `be_success` call in controller specs to avoid getting following deprecation warning: ``` DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? as provided by Rack::Response::Helpers. ```
-
Igor Drozdov authored
totalNotes is only used to prerender a number of skeleton containers until real notes are loaded issuable.discussions makes multiple requests, so too expensive for this This commit uses mere notes for this and sends actual totalNotes number if it's less than 10; otherwise it sends 10 - it allows us to avoid bunch of skeleton prerenderings, which are not necessary since they doesn't fit into the whole screen and disappear quite fast
-
Doug Stull authored
-
Arun Kumar Mohan authored
Only displays the todo body if the todo has a note. This is to avoid redundant Issue or Merge Request titles displayed both in the Todo title and body.
-
- 27 Aug, 2019 8 commits
-
-
Stan Hu authored
During a project import, `LfsLinkService` attempts to link `LfsObjects` that have not already been associated with a project. It's possible for a large repo to have thousands of OIDs, which can cause long database query and parsing times. By processing a batch of 1000 at a time, we can reduce that time at the expense of a few more SQL queries. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66274
-
Luke Duncalfe authored
Notes call `#after_note_created` and `#after_note_destroyed` on their noteable in callbacks, so the noteable can perform tasks particular to them, like cache expiry. This is in preparation of the EE-specific class `DesignManagement::Design` clearing its `user_notes_count` cache when its note are created or destroyed. Refactoring Rspec behaviour testing of a counter caching service into a shared example. https://gitlab.com/gitlab-org/gitlab-ee/issues/13353
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
Illya Klymov authored
-
Enrique Alcantara authored
This commit creates a create_cluster directory to collect all Vue applications related to creating kubernetes applications using gitlab. It also moves the gke_cluster_dropdowns collection of apps to the create_cluster directory. gke_cluster_dropdowns contains dropdown components used to select configuration options to create a Kubernetes cluster in Google Cloud.
-
Heinrich Lee Yu authored
Also change test URL sequest to .test TLD
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
dodocat authored
allow_bypass_two_factor configration dose not work with saml provider
-