Read about our upcoming Code of Conduct on this issue

  1. 23 Apr, 2019 1 commit
  2. 12 Apr, 2019 2 commits
  3. 05 Apr, 2019 2 commits
    • Gosia Ksionek's avatar
      Add part of needed code · c1aa0c81f72d
      Gosia Ksionek authored
      Add columns to store project creation settings
      
      Add project creation level column in groups
       and default project creation column in application settings
      
      Remove obsolete line from schema
      
      Update migration with project_creation_level column existence check
      
      Rename migrations to avoid conflicts
      
      Update migration methods
      
      Update migration method
      c1aa0c81f72d
    • Brandon Labuschagne's avatar
      Add limit of 128 characters to users name · 1e9a6650b6ec
      Brandon Labuschagne authored
      Truncate existing users names which exceed 128 characters
      Include test for truncating users names
      1e9a6650b6ec
  4. 28 Mar, 2019 1 commit
  5. 22 Mar, 2019 2 commits
  6. 06 Mar, 2019 1 commit
  7. 05 Mar, 2019 1 commit
    • Horatiu Eugen Vlad's avatar
      Align EmailValidator to validate_email gem implementation. · 123c77a5d0b9
      Horatiu Eugen Vlad authored
      Renamed EmailValidator to DeviseEmailValidator to avoid 'email:' naming collision with ActiveModel::Validations::EmailValidator in 'validates' statement.
      Make use of the options attribute of the parent class ActiveModel::EachValidator.
      Add more options: regex.
      123c77a5d0b9
  8. 19 Feb, 2019 1 commit
    • Stan Hu's avatar
      Make Admin::UsersController work with Ruby 2.6 · 29d7f503a7cd
      Stan Hu authored
      Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
      Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
      will fail with a `wrong number of arguments (given 1, expected 0)`
      message because the `Enumerable#filter` implementation overrides the
      delegated `ActiveRecord::Relation#filter` method.
      
      To make Admin::UsersController compatible with Ruby 2.6, rename
      `User.filter` to `User.filter_items`.
      29d7f503a7cd
  9. 13 Feb, 2019 1 commit
    • Luke Bennett's avatar
      Improve the GitHub and Gitea import feature table interface · 44b10908434c
      Luke Bennett authored
      These are backend changes.
      Use Vue for the import feature UI for "githubish"
      providers (GitHub and Gitea).
      Add "Go to project" button after a successful import.
      Use CI-style status icons and improve spacing of the
      table and its component.
      Adds ETag polling to the github and gitea import
      jobs endpoint.
      44b10908434c
  10. 08 Feb, 2019 1 commit
  11. 06 Feb, 2019 1 commit
  12. 05 Feb, 2019 1 commit
    • Brandon Labuschagne's avatar
      Add last activity to user administration · 795e3d00fd8b
      Brandon Labuschagne authored
      The columns 'Created on' and 'Last activity' have been
      added to the admin -> users view.
      
      Sorting options have also been added for last activity
      and the search bar has been moved to match the issues
      page.
      795e3d00fd8b
  13. 31 Jan, 2019 1 commit
  14. 24 Jan, 2019 1 commit
  15. 21 Jan, 2019 1 commit
  16. 15 Jan, 2019 1 commit
  17. 19 Dec, 2018 2 commits
  18. 13 Dec, 2018 1 commit
    • Alessio Caiazza's avatar
      Add name, author and sha to releases · 1d2319685e1a
      Alessio Caiazza authored
      This commit adds a name to each release, defaulting it to tag name,
      keeps track of the SHA when a new release is created and tracks the
      current user as release author.
      1d2319685e1a
  19. 26 Nov, 2018 1 commit
  20. 19 Nov, 2018 1 commit
  21. 07 Nov, 2018 1 commit
    • Tiago Botelho's avatar
      User can keep their commit email private · 8e351c54d5a2
      Tiago Botelho authored
      The private commit email is automatically generated in the format:
      id-username@noreply.HOSTNAME
      
      GitLab instance admins are able to change the HOSTNAME portion,
      that defaults to Gitlab's hostname, to whatever they prefer.
      8e351c54d5a2
  22. 05 Nov, 2018 1 commit
    • Imre Farkas's avatar
      Remove PersonalAccessTokensFinder#find_by method · ada468b6051b
      Imre Farkas authored
      find_by_token is overriden by TokenAuthenticatable which can be easily
      missed or confused with #find_by(:token) defined by ActiveRecord. First
      step for safer usage is to remove #find_by.
      ada468b6051b
  23. 01 Nov, 2018 2 commits
    • Yorick Peterse's avatar
      Use a method for the has_many :keys in Project · 2203bdd556a2
      Yorick Peterse authored
      This moves the `where` in the `has_many :keys` association in Project to
      the Key model. This allows EE to override this method, instead of
      modifying the source code directly.
      2203bdd556a2
    • Yorick Peterse's avatar
      Move LDAP sync time constant to a method · 7b1cfa110d2f
      Yorick Peterse authored
      This moves the `1.hour` constant used as the LDAP sync time to a
      separate method. This allows EE to override this method using a module,
      instead of directly modifying the source code.
      7b1cfa110d2f
  24. 29 Oct, 2018 2 commits
  25. 26 Oct, 2018 1 commit
  26. 23 Oct, 2018 1 commit
  27. 18 Oct, 2018 1 commit
  28. 12 Oct, 2018 1 commit
  29. 08 Oct, 2018 1 commit
    • Yorick Peterse's avatar
      Clean up ActiveRecord code in TodoService · dca9aa1f20af
      Yorick Peterse authored
      This refactors the TodoService class according to our code reuse
      guidelines. The resulting code is a wee bit more verbose, but it allows
      us to decouple the column names from the input, resulting in fewer
      changes being necessary when we change the schema.
      
      One particular noteworthy line in TodoService is the following:
      
          todos_ids = todos.update_state(state)
      
      Technically this is a violation of the guidelines, because
      `update_state` is a class method, which services are not supposed to use
      (safe for a few allowed ones). I decided to keep this, since there is no
      alternative. `update_state` doesn't produce a relation so it doesn't
      belong in a Finder, and we can't move it to another Service either. As
      such I opted to just use the method directly.
      
      Cases like this may happen more frequently, at which point we should
      update our documentation with some sort of recommendation. For now, I
      want to refrain from doing so until we have a few more examples.
      dca9aa1f20af
  30. 24 Sep, 2018 1 commit
  31. 17 Sep, 2018 2 commits
    • Brett Walker's avatar
      Filter out archived projects from issue/mr count · 67f298daa2da
      Brett Walker authored
      Pass the 'non_archived' flag to finder methods
      67f298daa2da
    • Yorick Peterse's avatar
      Added FromUnion to easily select from a UNION · 84f6b869d148
      Yorick Peterse authored
      This commit adds the module `FromUnion`, which provides the class method
      `from_union`. This simplifies the process of selecting data from the
      result of a UNION, and reduces the likelihood of making mistakes. As a
      result, instead of this:
      
          union = Gitlab::SQL::Union.new([foo, bar])
      
          Foo.from("(#{union.to_sql}) #{Foo.table_name}")
      
      We can now write this instead:
      
          Foo.from_union([foo, bar])
      
      This commit also includes some changes to make this new setup work
      properly. For example, a bug in Rails 4
      (https://github.com/rails/rails/issues/24193) would break the use of
      `from("sub-query-here").includes(:relation)` in certain cases. There was
      also a CI query which appeared to repeat a lot of conditions from an
      outer query on an inner query, which isn't necessary.
      
      Finally, we include a RuboCop cop to ensure developers use this new
      module, instead of using Gitlab::SQL::Union directly.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
      84f6b869d148
  32. 16 Sep, 2018 1 commit
  33. 14 Sep, 2018 1 commit