Read about our upcoming Code of Conduct on this issue

  1. 06 May, 2019 1 commit
    • Ezekiel Kigbo's avatar
      Added blank lines to meet style guide · 5c1437e23f6e
      Ezekiel Kigbo authored
      Un-nest title variable output
      
      Update spec test names
      
      Rename sort_value_most_stars -> sort_value_stars_desc
      
      Rename sorted_by_stars -> sorted_by_stars_desc
      
      Renname sort_value_most_stars_asc -> sort_value_stars_asc
      
      Invert feature check, assign feature condition to a variable
      
      Inline conditional nav bar rendering
      
      Invert conditional label
      
      Added follow up task
      
      Fix filters returning 0 projects show the wrong view
      
      Move click action out of test expectation
      
      Use proper variable name for project in before block
      
      Rename projects_sort_admin_options_hash
      
      Renamed projects_sort_admin_options_has to
      old_projects_sort_options_hash as its not only used
      on the admin screen
      
      Fix extra whitespace errors
      
      Stub project_list_filter_bar in the projects_helper specs
      
      Added follow up task for `show_projects?`
      
      Removed url test expectations
      5c1437e23f6e
  2. 28 Mar, 2019 1 commit
  3. 01 Mar, 2019 1 commit
    • Reuben Pereira's avatar
      Refactor model and spec · 882bd3d06144
      Reuben Pereira authored
      - Move some specs into contexts
      - Let get_slugs method take a parameter and return a specific slug.
      - Add rescues when using Addressable::URI.
      882bd3d06144
  4. 04 Feb, 2019 2 commits
  5. 31 Jan, 2019 2 commits
  6. 28 Jan, 2019 1 commit
  7. 18 Jan, 2019 1 commit
    • Francisco Javier López's avatar
      Fixed bug when external wiki is enabled · b8788296a061
      Francisco Javier López authored
      When the external wiki is enabled, the internal wiki link is replaced
      by the external wiki url. But the internal wiki is still accessible.
      In this change the external wiki will have its own tab in the sidebar
      and only if the services are disabled the tab (and access rights)
      will not be displayed.
      b8788296a061
  8. 04 Jan, 2019 1 commit
  9. 19 Dec, 2018 1 commit
  10. 10 Dec, 2018 1 commit
    • Gabriel Mazetto's avatar
      Reduce N+1 from Activity Dashboard and Banzai · d44d55762550
      Gabriel Mazetto authored
      There is a combination of few strategies implemented here:
      
      1. Few relations were eager loaded
      2. Changed few polymorphic routes to specific ones so we don't have to
         use `#becomes(Namespace)` which doesn't preserve association cache
      d44d55762550
  11. 06 Dec, 2018 1 commit
  12. 05 Sep, 2018 1 commit
  13. 17 Jul, 2018 1 commit
  14. 06 Jul, 2018 1 commit
  15. 15 Jun, 2018 1 commit
  16. 14 Jun, 2018 1 commit
  17. 13 Jun, 2018 1 commit
  18. 06 Jun, 2018 1 commit
  19. 05 Jun, 2018 1 commit
  20. 09 May, 2018 1 commit
  21. 25 Apr, 2018 1 commit
  22. 12 Apr, 2018 1 commit
  23. 23 Feb, 2018 1 commit
  24. 22 Feb, 2018 1 commit
  25. 20 Feb, 2018 1 commit
  26. 13 Feb, 2018 1 commit
  27. 22 Jan, 2018 2 commits
  28. 23 Nov, 2017 1 commit
  29. 07 Oct, 2017 1 commit
    • Jacopo's avatar
      Replaces `tag: true` into `:tag` in the specs · f4ef7328afe4
      Jacopo authored
      Replaces all the explicit include metadata syntax in the specs (tag:
      true) into the implicit one (:tag).
      Added a cop to prevent future errors and handle autocorrection.
      f4ef7328afe4
  30. 28 Sep, 2017 1 commit
  31. 22 Sep, 2017 1 commit
  32. 13 Sep, 2017 1 commit
  33. 07 Sep, 2017 5 commits
    • Yorick Peterse's avatar
      Rework how recent push events are retrieved · 9ec66da20412
      Yorick Peterse authored
      Whenever you push to a branch GitLab will show a button to create a
      merge request (should one not exist already). The underlying code to
      display this data was quite inefficient. For example, it involved
      multiple slow queries just to figure out what the most recent push event
      was.
      
      This commit changes the way this data is retrieved so it's much faster.
      This is achieved by caching the ID of the last push event on every push,
      which is then retrieved when loading certain pages. Database queries are
      only executed if necessary and the cached data is removed automatically
      once a merge request has been created, or 2 hours after being stored.
      
      A trade-off of this approach is that we _only_ track the last event.
      Previously if you were to push to branch A and B then create a merge
      request for branch B we'd still show the widget for branch A. As of this
      commit this is no longer the case, instead we will only show the widget
      for the branch you pushed to most recently. Once a merge request exists
      the widget is no longer displayed. Alternative solutions are either too
      complex and/or too slow, hence the decision was made to settle for this
      trade-off.
      
      Performance Impact
      ------------------
      
      In the best case scenario (= a user didn't push anything for more than 2
      hours) we perform a single Redis GET per page. Should there be cached
      data we will run a single (and lightweight) SQL query to get the
      event data from the database. If a merge request already exists we will
      run an additional DEL to remove the cache key.
      
      The difference in response timings can vary a bit per project. On
      GitLab.com the 99th percentile of time spent in User#recent_push hovers
      between 100 milliseconds and 1 second, while the mean hovers around 50
      milliseconds. With the changes in this MR the expected time spent in
      User#recent_push is expected to be reduced down to just a few
      milliseconds.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
      9ec66da20412
    • Maxim Rydkin's avatar
    • Maxim Rydkin's avatar
      fix project_helper.rb and add couple specs to it · 719d6007dc10
      Maxim Rydkin authored
      719d6007dc10
    • Maxim Rydkin's avatar
      fix CI · 8c6b9faa8ad0
      Maxim Rydkin authored
      8c6b9faa8ad0
    • Maxim Rydkin's avatar
      fix helper and spec · 7a5d0c050e1c
      Maxim Rydkin authored
      7a5d0c050e1c