- 24 Sep, 2018 2 commits
-
-
Michael Kozono authored
Even if it doesn’t save lines of code, since people will tend to use code they’ve seen. And `SafeRequestStore` is safer since you don’t have to remember to check `RequestStore.active?`.
-
Michael Kozono authored
Makes it easier and safer to use RequestStore because you don't need to check `RequestStore.active?` before using it. You just have to use `Gitlab::SafeRequestStore` instead.
-
- 21 Sep, 2018 5 commits
-
-
🙈 jacopo beschi 🙉 authored
-
Sanad Liaquat authored
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Marcel Amirault authored
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 20 Sep, 2018 5 commits
-
-
Toon Claes authored
`delete_all` doesn't support limit, so you'd need to subquery that. And instead of subquerying with `where(id: query)`, it's better to use an `INNER JOIN`. This method also works with MySQL, while subquerying doesn't (without another layer of subquerying) Reference: https://stackoverflow.com/questions/17892762/mysql-this-version-of-mysql-doesnt-yet-support-limit-in-all-any-some-subqu/17892886#17892886
-
Dmitriy Zaporozhets authored
Even if User OAuth applications setting is disabled in admin settings. Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Nick Thomas authored
-
Phil Hughes authored
-
André Luís authored
Resolve "Link to file in Changes tab of MR no longer works for all files after incremental rendering improvement"
-
- 19 Sep, 2018 5 commits
-
-
Stan Hu authored
-
Marcel Amirault authored
-
Oswaldo Ferreira authored
-
Stan Hu authored
When there are many tags in a container repository, deleting them can exceed the default 60 second idle-in-transaction timeout in Sidekiq. We now explicitly delete them in the DestroyService before destroying the model. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51380
-
Dmitriy Zaporozhets authored
Rename btn-new, btn-create and btn-save to btn-success Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 18 Sep, 2018 10 commits
-
-
Mike Greiling authored
-
Mike Greiling authored
-
Dylan Griffith authored
-
Mike Greiling authored
-
Gabriel Mazetto authored
-
Phil Hughes authored
-
Martin Wortschack authored
-
Douglas Barbosa Alexandre authored
This refactors the DashboardGroupMilestone model so that it no longer uses the MilestoneFinder, instead using methods defined on the Milestone model directly.
-
Nick Thomas authored
-
Steve Azzopardi authored
-
- 17 Sep, 2018 13 commits
-
-
Nick Thomas authored
-
Brett Walker authored
Pass the 'non_archived' flag to finder methods
-
Oswaldo Ferreira authored
This adds a basic interface to fetch diff statistics given two SHAs. It's a requirement for #49399 #20282 and #19232.
-
Nick Thomas authored
-
Nick Thomas authored
-
Phil Hughes authored
This makes the file row component re-usable ouside of the Web IDE Pre-request for https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
-
James Lopez authored
-
Yorick Peterse authored
This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
-
Phil Hughes authored
It now tests for the latest diff check
-
Marcel Amirault authored
-
Steve Azzopardi authored
closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51093
-
Phil Hughes authored
-
Phil Hughes authored
Un-commented out expect checks in mutation spec
-