Read about our upcoming Code of Conduct on this issue

  1. 08 Dec, 2016 1 commit
  2. 18 Nov, 2016 1 commit
    • Timothy Andrew's avatar
      Fix a race condition that allowed soft-deleted groups to remain in the database. · f81053962586
      Timothy Andrew authored
      The intended flow is:
        Soft-delete group (sync) -> Delete group projects (async) -> Hard-delete group (async)
      The soft-delete was run in a transaction, which was committed only after
      the async job (for hard-deletion) was kicked off. There was a race
      condition here - the soft-delete transaction could complete _after_ the
      hard delete completed, leaving a soft-deleted record in the database.
      This commit removes this race condition. There is no need to run the
      soft-delete in a transaction. The soft-delete completes before the async
      job is kicked off.
  3. 11 Aug, 2016 1 commit
    • Stan Hu's avatar
      Fix bug where destroying a namespace would not always destroy projects · 4f8fa2dd763b
      Stan Hu authored
      There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
      1. User attempts to delete group
      2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
      3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
      4. Projects::DestroyService runs later but the can?(current_user,
         :remove_project) is `false` because the user no longer has permission to
         destroy projects with no namespace.
      5. This leaves the project in pending_delete state with no namespace/group.
      Projects without a namespace or group also adds another problem: it's not possible to destroy the container
      registry tags, since container_registry_path_with_namespace is the wrong value.
      The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
      Closes #17893
  4. 10 Aug, 2016 1 commit
    • Stan Hu's avatar
      Clean up project destruction · 0fd332960140
      Stan Hu authored
      Instead of redirecting from the project service to the service and back to the model,
      put all destruction code in the service. Also removes a possible source of failure
      where run_after_commit may not destroy the project.
  5. 15 Mar, 2016 1 commit
  6. 29 Jan, 2016 1 commit
  7. 03 Jun, 2015 3 commits