Read about our upcoming Code of Conduct on this issue

  1. 08 Dec, 2016 1 commit
  2. 01 Dec, 2016 1 commit
  3. 29 Nov, 2016 2 commits
  4. 28 Nov, 2016 1 commit
  5. 24 Nov, 2016 3 commits
  6. 18 Nov, 2016 2 commits
  7. 16 Nov, 2016 1 commit
  8. 14 Nov, 2016 1 commit
  9. 01 Nov, 2016 1 commit
  10. 27 Oct, 2016 1 commit
  11. 19 Oct, 2016 1 commit
  12. 06 Oct, 2016 2 commits
  13. 23 Sep, 2016 1 commit
  14. 19 Sep, 2016 1 commit
    • Nick Thomas's avatar
      Enable Warden for the Grape API · a1bced203b52
      Nick Thomas authored
      The practical effect of this commit is to make the API check the Rails session
      cookie for authentication details. If the cookie is present and valid, it will
      be used to authenticate.
      
      The API now has several authentication options for users. They follow in this
      order of precedence:
      
      * Authentication token
      * Personal access token
      * OAuth2 Bearer token (Doorkeeper - application access)
      * Rails session cookie
      a1bced203b52
  15. 13 Sep, 2016 1 commit
  16. 30 Aug, 2016 5 commits
  17. 24 Aug, 2016 1 commit
  18. 18 Aug, 2016 3 commits
  19. 10 Aug, 2016 2 commits
  20. 20 Jul, 2016 1 commit
  21. 19 Jul, 2016 1 commit
  22. 18 Jul, 2016 1 commit
  23. 13 Jul, 2016 2 commits
    • Robert Speicher's avatar
      Revert "Merge branch '18193-developers-can-merge' into 'master' · df7fb9e8d12f
      Robert Speicher authored
      This reverts commit 72baf9a18669, reversing
      changes made to cf491007802b.
      df7fb9e8d12f
    • Timothy Andrew's avatar
      Refactor `Gitlab::GitAccess` · a0fe55c0e0b9
      Timothy Andrew authored
      1. Don't use case statements for dispatch anymore. This leads to a lot
         of duplication, and makes the logic harder to follow.
      
      2. Remove duplicated logic.
      
          - For example, the `can_push_to_branch?` exists, but we also have a
            different way of checking the same condition within `change_access_check`.
      
          - This kind of duplication is removed, and the `can_push_to_branch?`
            method is used in both places.
      
      3. Move checks returning true/false to `UserAccess`.
      
          - All public methods in `GitAccess` now return an instance of
            `GitAccessStatus`. Previously, some methods would return
            true/false as well, which was confusing.
      
          - It makes sense for these kinds of checks to be at the level of a
            user, so the `UserAccess` class was repurposed for this. The prior
            `UserAccess.allowed?` classmethod is converted into an instance
            method.
      
          - All external uses of these checks have been migrated to use the
            `UserAccess` class
      
      4. Move the "change_access_check" into a separate class.
      
          - Create the `GitAccess::ChangeAccessCheck` class to run these
            checks, which are quite substantial.
      
          - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as
            well.
      
      5. Break out the boolean logic in `ChangeAccessCheck` into `if/else`
         chains - this seems more readable.
      
      6. I can understand that this might look like overkill for !4892, but I
         think this is a good opportunity to clean it up.
      
          - http://martinfowler.com/bliki/OpportunisticRefactoring.html
      a0fe55c0e0b9
  24. 12 Jul, 2016 4 commits