This instance will be upgraded to Heptapod 0.31.0rc on 2022-05-19 at 11:00 UTC+2 (a few minutes of down time)

  1. 15 Aug, 2019 1 commit
  2. 09 Aug, 2019 1 commit
  3. 05 Jun, 2019 1 commit
  4. 30 Apr, 2019 1 commit
  5. 15 Apr, 2019 1 commit
  6. 09 Apr, 2019 1 commit
  7. 05 Apr, 2019 2 commits
  8. 22 Jan, 2019 1 commit
    • Gabriel Mazetto's avatar
      Refactored AfterRenameService to reduce coupling · 80c6425fe68e
      Gabriel Mazetto authored
      We still rely on the Dirty API for project rename (before/after) values,
      but we don't access the dirty api from the service class anymore.
      
      The previous value is now part of the initialization, which makes it
      easier to test and the behavior is clearer.
      
      The same was done with the `rename_repo` on the Storage classes, we now
      provide before and after values as part of the method signature.
      80c6425fe68e
  9. 21 Jan, 2019 1 commit
    • Gabriel Mazetto's avatar
      Fixed legacy storage renaming code · 878d6e5ceda0
      Gabriel Mazetto authored
      During a previous refactor on project model, code related to the
      hashed storage was extracted into AfterRenameService, see
      4b9c17f196bab6075563f62d01f9db65c1a0515c.
      
      The "path_before" was changed from using `previous_changes['path']` to
      `path_was`. They are not equivalent. `path_was` exists reliably only
      *before* persisting to the database. After database persistence is
      confirmed, the value is moved to `previous_changes[:attribute_name]`.
      
      Because the repository/attachments rename or storage upgrade happens
      after it was persisted to the database, we were in fact not informing
      the right parameters (and therefore not doing what it was supposed to).
      878d6e5ceda0
  10. 14 Dec, 2018 1 commit
  11. 22 Oct, 2018 1 commit
    • Yorick Peterse's avatar
      Move Project#rename_repo to a service class · a8f8af2f9d3f
      Yorick Peterse authored
      This moves the logic of Project#rename_repo and all methods _only_ used
      by this method into a new service class: Projects::AfterRenameService.
      By moving this code into a separate service class we can more easily
      refactor it, and we also get rid of some RuboCop "disable" statements
      automatically.
      
      During the refactoring of this code, I removed most of the explicit
      logging using Gitlab::AppLogger. The data that was logged would not be
      useful when debugging renaming issues, as it does not add any value on
      top of data provided by users.
      
      I also removed a variety of comments that either mentioned something the
      code does in literal form, or contained various grammatical errors.
      Instead we now resort to more clearly named methods, removing the need
      for code comments.
      
      This method was chosen based on analysis in
      https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue
      we determined this method has seen a total of 293 lines being changed in
      it. We also noticed that RuboCop determined the ABC size
      (https://www.softwarerenovation.com/ABCMetric.pdf) was too great.
      a8f8af2f9d3f
  12. 05 Oct, 2018 1 commit
  13. 11 Sep, 2018 1 commit
  14. 16 Aug, 2018 1 commit
  15. 03 Aug, 2018 1 commit
  16. 31 Jul, 2018 1 commit
  17. 30 Jul, 2018 1 commit
  18. 17 Jul, 2018 1 commit
  19. 09 Jul, 2018 1 commit
  20. 06 Jun, 2018 1 commit
  21. 05 Jun, 2018 1 commit
  22. 04 Jun, 2018 2 commits
  23. 28 May, 2018 1 commit
  24. 22 Mar, 2018 1 commit
  25. 08 Mar, 2018 1 commit
    • Stan Hu's avatar
      Fix Error 500 when updating a project · 38fe3f03a92c
      Stan Hu authored
      If no parameters were specified for project features but Wikis were disabled,
      we would get "NoMethodError: undefined method `[]' for nil:NilClass".
      
      Closes #44019
      38fe3f03a92c
  26. 26 Feb, 2018 1 commit
  27. 02 Feb, 2018 1 commit
  28. 04 Dec, 2017 1 commit
  29. 28 Nov, 2017 1 commit
  30. 12 Sep, 2017 1 commit
  31. 06 Sep, 2017 2 commits
  32. 08 Aug, 2017 1 commit
  33. 24 Jul, 2017 1 commit
  34. 14 Jul, 2017 1 commit
  35. 13 Jul, 2017 1 commit
  36. 26 Jan, 2017 1 commit
    • Tommy Beadle's avatar
      Add a system hook for when a project is updated. · 6741fe740abe
      Tommy Beadle authored
      This sends a project_update hook when a repo is updated.  This does not include
      renaming or transferring a project.  Those are covered by project_rename and
      project_transfer.  This will get called, however, when the visibility is
      changed.
      6741fe740abe
  37. 16 Jan, 2017 1 commit