Read about our upcoming Code of Conduct on this issue

  1. 13 Nov, 2019 1 commit
  2. 26 Sep, 2019 1 commit
  3. 18 Sep, 2019 1 commit
  4. 04 Mar, 2019 1 commit
    • Nick Thomas's avatar
      sidekiq: terminate child processes at shutdown · 9b88c9b29c90
      Nick Thomas authored
      Sidekiq jobs frequently spawn long-lived child processes to do work.
      In some circumstances, these can be reparented to init when sidekiq is
      terminated, leading to duplication of work and strange concurrency
      problems.
      
      This commit changes sidekiq so that, if run as a process group leader,
      it will forward `INT` and `TERM` signals to the whole process group. If
      the memory killer is active, it will also use the process group when
      resorting to `kill -9` to shut down.
      
      These changes mean that a naive `kill <pid-of-sidekiq>` will now do the
      right thing, killing any child processes spawned by sidekiq, as long as
      the process supervisor placed it in its own process group.
      
      If sidekiq isn't a process group leader, this new code is skipped.
      9b88c9b29c90
  5. 02 Nov, 2017 1 commit
  6. 11 Oct, 2016 1 commit
  7. 26 Apr, 2016 1 commit
  8. 07 May, 2015 1 commit
    • Jacob Vosmaer's avatar
      Add SIDEKIQ_MEMORY_KILLER_SHUTDOWN_SIGNAL env var · 527b5d6ea1d6
      Jacob Vosmaer authored
      It looks like SIGTERM may not be enough to shut down a Sidekiq process
      when its RSS has gotten too big. This change will allow us to experiment
      with sending SIGKILL instead of SIGTERM to Sidekiq processes on
      gitlab.com.
      527b5d6ea1d6
  9. 15 Dec, 2014 1 commit