- 15 Nov, 2017 1 commit
-
-
Douwe Maan authored
-
- 07 Nov, 2017 1 commit
-
-
Yorick Peterse authored
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
- 06 Nov, 2017 2 commits
-
-
Douwe Maan authored
-
Markus Koller authored
-
- 04 Nov, 2017 1 commit
-
-
Matija Čupić authored
-
- 03 Nov, 2017 2 commits
-
-
Alejandro Rodríguez authored
-
Bob Van Landuyt authored
-
- 02 Nov, 2017 1 commit
-
-
Kamil Trzcinski authored
-
- 31 Oct, 2017 2 commits
-
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
- 30 Oct, 2017 1 commit
-
-
Jacopo authored
Pipeline hook data now includes the project_id
-
- 27 Oct, 2017 2 commits
-
-
Gabriel Mazetto authored
When project storage_version is `2` means attachments are using hashed storage.
-
Zeger-Jan van de Weg authored
Now, when requesting a commit from the Repository model, the results are not cached. This means we're fetching the same commit by oid multiple times during the same request. To prevent us from doing this, we now cache results. Caching is done only based on object id (aka SHA). Given we cache on the Repository model, results are scoped to the associated project, eventhough the change of two repositories having the same oids for different commits is small.
-
- 23 Oct, 2017 2 commits
-
-
Shinya Maeda authored
-
Kamil Trzcinski authored
-
- 17 Oct, 2017 1 commit
-
-
Bob Van Landuyt authored
The problem would occur when the `ForkedProjectLink` was deleted, but the `ForkNetworkMember` was not. The delete would be rolled back and retried. But the error would not be saved because `Project#forked?` would still be true, because the `ForkNetworkMember` exists. But the `Project#forked_project_link` would be `nil`. So the validation for the visibility level would fail.
-
- 13 Oct, 2017 1 commit
-
-
Matt Coleman authored
-
- 10 Oct, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 07 Oct, 2017 3 commits
-
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
When no fork network exists for the source projects, we create a new one with the correct source
-
- 06 Oct, 2017 1 commit
-
-
Toon Claes authored
In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo secondary node). But in GitLab CE it also might be useful to have the "read-only" idea around. So port it back to GitLab CE. Also having the principle of read-only in GitLab CE would hopefully lead to less errors introduced, doing write operations when there aren't allowed for read-only calls. Closes gitlab-org/gitlab-ce#37534.
-
- 05 Oct, 2017 3 commits
-
-
Alessio Caiazza authored
-
Zeger-Jan van de Weg authored
-
Bob Van Landuyt authored
-
- 04 Oct, 2017 4 commits
-
-
Bob Van Landuyt authored
By preloading the count of members, projects and subgroups of a group, we don't need to query them later. We also preload the entire hierarchy for a search result and include the counts so we don't need to query for them again
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
-
Bob Van Landuyt authored
-
- 02 Oct, 2017 3 commits
-
-
Douglas Barbosa Alexandre authored
-
Stan Hu authored
Because of a change in GitLab 9.5.4 to prevent users from assuming control of a repository already on disk, the import task broke. Imports would fail with the message, "There is already a repository with that name on disk". This change skips the validation when the import is done from the command-line. Closes #37682
-
Shinya Maeda authored
-
- 29 Sep, 2017 3 commits
-
-
Valery Sizov authored
-
Jacob Vosmaer authored
-
Valery Sizov authored
-
- 28 Sep, 2017 1 commit
-
-
Gabriel Mazetto authored
-
- 25 Sep, 2017 1 commit
-
-
Shinya Maeda authored
-
- 20 Sep, 2017 2 commits
-
-
Valery Sizov authored
-
Valery Sizov authored
-
- 15 Sep, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
Updating didn't work, as the project_id was missing to be set for the project_auto_devops model. Fixes gitlab-org/gitlab-ce#37893
-