1. 02 Jan, 2016 1 commit
  2. 31 Dec, 2015 1 commit
  3. 28 Dec, 2015 1 commit
  4. 27 Dec, 2015 1 commit
  5. 23 Dec, 2015 1 commit
  6. 22 Dec, 2015 2 commits
  7. 18 Dec, 2015 2 commits
  8. 17 Dec, 2015 4 commits
    • Yorick Peterse's avatar
      Track object counts using the "allocations" Gem · 487c86620041
      Yorick Peterse authored
      This allows us to track the counts of actual classes instead of "T_XXX"
      nodes. This is only enabled on CRuby as it uses CRuby specific APIs.
      487c86620041
    • Yorick Peterse's avatar
      Instrument all ActiveRecord model methods · 44a4fb3351a5
      Yorick Peterse authored
      This works by searching the raw source code for any references to
      commonly used ActiveRecord methods. While not bulletproof it saves us
      from having to list hundreds of methods by hand. It also ensures that
      (most) newly added methods are instrumented automatically.
      
      This _only_ instruments models defined in app/models, should a model
      reside somewhere else (e.g. somewhere in lib/) it _won't_ be
      instrumented.
      44a4fb3351a5
    • Yorick Peterse's avatar
      Storing of application metrics in InfluxDB · c7f125897daa
      Yorick Peterse authored
      This adds the ability to write application metrics (e.g. SQL timings) to
      InfluxDB. These metrics can in turn be visualized using Grafana, or
      really anything else that can read from InfluxDB. These metrics can be
      used to track application performance over time, between different Ruby
      versions, different GitLab versions, etc.
      
      == Transaction Metrics
      
      Currently the following is tracked on a per transaction basis (a
      transaction is a Rails request or a single Sidekiq job):
      
      * Timings per query along with the raw (obfuscated) SQL and information
        about what file the query originated from.
      * Timings per view along with the path of the view and information about
        what file triggered the rendering process.
      * The duration of a request itself along with the controller/worker
        class and method name.
      * The duration of any instrumented method calls (more below).
      
      == Sampled Metrics
      
      Certain metrics can't be directly associated with a transaction. For
      example, a process' total memory usage is unrelated to any running
      transactions. While a transaction can result in the memory usage going
      up there's no accurate way to determine what transaction is to blame,
      this becomes especially problematic in multi-threaded environments.
      
      To solve this problem there's a separate thread that takes samples at a
      fixed interval. This thread (using the class Gitlab::Metrics::Sampler)
      currently tracks the following:
      
      * The process' total memory usage.
      * The number of file descriptors opened by the process.
      * The amount of Ruby objects (using ObjectSpace.count_objects).
      * GC statistics such as timings, heap slots, etc.
      
      The default/current interval is 15 seconds, any smaller interval might
      put too much pressure on InfluxDB (especially when running dozens of
      processes).
      
      == Method Instrumentation
      
      While currently not yet used methods can be instrumented to track how
      long they take to run. Unlike the likes of New Relic this doesn't
      require modifying the source code (e.g. including modules), it all
      happens from the outside. For example, to track `User.by_login` we'd add
      the following code somewhere in an initializer:
      
          Gitlab::Metrics::Instrumentation.
            instrument_method(User, :by_login)
      
      to instead instrument an instance method:
      
          Gitlab::Metrics::Instrumentation.
            instrument_instance_method(User, :save)
      
      Instrumentation for either all public model methods or a few crucial
      ones will be added in the near future, I simply haven't gotten to doing
      so just yet.
      
      == Configuration
      
      By default metrics are disabled. This means users don't have to bother
      setting anything up if they don't want to. Metrics can be enabled by
      editing one's gitlab.yml configuration file (see
      config/gitlab.yml.example for example settings).
      
      == Writing Data To InfluxDB
      
      Because InfluxDB is still a fairly young product I expect the worse.
      Data loss, unexpected reboots, the database not responding, you name it.
      Because of this data is _not_ written to InfluxDB directly, instead it's
      queued and processed by Sidekiq. This ensures that users won't notice
      anything when InfluxDB is giving trouble.
      
      The metrics worker can be started in a standalone manner as following:
      
          bundle exec sidekiq -q metrics
      
      The corresponding class is called MetricsWorker.
      c7f125897daa
    • Rubén Dávila's avatar
      Upgrade Poltergeist to 1.8.1. #4131 · 32fa4653e829
      Rubén Dávila authored
      32fa4653e829
  9. 15 Dec, 2015 1 commit
  10. 14 Dec, 2015 1 commit
  11. 13 Dec, 2015 1 commit
  12. 11 Dec, 2015 1 commit
  13. 10 Dec, 2015 2 commits
  14. 09 Dec, 2015 1 commit
  15. 08 Dec, 2015 2 commits
  16. 07 Dec, 2015 1 commit
  17. 05 Dec, 2015 2 commits
    • Robert Speicher's avatar
      Bump gitlab_emoji to ~> 0.2.0 · 30c169a8b991
      Robert Speicher authored
      30c169a8b991
    • Stan Hu's avatar
      Fix Error 500 when creating global milestones with Unicode characters · 929a91a331e1
      Stan Hu authored
      Two issues:
      
      1. The constraints in the resources were incorrect. Here's what it was before:
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      In this case, id is actually the title of the milestone, which can be anything at the moment.
      
      After:
      
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
      
      ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
      
      This change uses the babosa library to create a better slug, which surprisingly
      isn't actually used by the global milestone controllers. Instead, they use the
      title passed as a query string for some reason.
      
      Closes https://github.com/gitlabhq/gitlabhq/issues/9881
      
      Fix constraints
      929a91a331e1
  18. 04 Dec, 2015 1 commit
  19. 03 Dec, 2015 1 commit
  20. 30 Nov, 2015 1 commit
  21. 27 Nov, 2015 1 commit
  22. 26 Nov, 2015 2 commits
  23. 25 Nov, 2015 4 commits
  24. 24 Nov, 2015 4 commits
  25. 23 Nov, 2015 1 commit