1. 06 Sep, 2017 1 commit
  2. 14 Aug, 2017 1 commit
    • Yorick Peterse's avatar
      Cache the number of forks of a project · 970143440d40
      Yorick Peterse authored
      The number of forks of a project doesn't change very frequently and
      running a COUNT(*) every time this information is requested can be quite
      expensive. We also end up running such a COUNT(*) query at least twice
      on the homepage of a project.
      By caching this data and refreshing it when necessary we can reduce
      project homepage loading times by around 60 milliseconds (based on the
      timings of https://gitlab.com/gitlab-org/gitlab-ce).
  3. 03 Aug, 2017 1 commit
  4. 02 Aug, 2017 1 commit
  5. 27 Jul, 2017 1 commit
  6. 28 Jun, 2017 3 commits
  7. 21 Jun, 2017 2 commits
  8. 02 Jun, 2017 1 commit
  9. 17 May, 2017 1 commit
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · f63dad32f25f
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      For project authorizations the logic is split up into two classes:
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      == On The Fly Refreshing
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      == Spec Changes
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
  10. 10 May, 2017 1 commit
  11. 21 Apr, 2017 1 commit
  12. 03 Apr, 2017 1 commit
  13. 24 Mar, 2017 1 commit
  14. 01 Mar, 2017 1 commit
    • James Lopez's avatar
      Update occurrences of MWBS to MWPS · 060ee4e63884
      James Lopez authored
       Rename column in the database
       Rename fields related to import/export feature
       Rename API endpoints
       Rename documentation links
       Rename the rest of occurrences in the code
       Replace the images that contain the words "build succeeds" and docs referencing to them
       Make sure pipeline is green and nothing is missing.
      updated doc images
      renamed only_allow_merge_if_build_succeeds in projects and fixed references
      more updates
      fix some spec failures
      fix rubocop offences
      fix v3 api spec
      fix MR  specs
      fixed issues with partials
      fix MR spec
      fix alignment
      add missing v3 to v4 doc
      wip - refactor v3 endpoints
      fix specs
      fix a few typos
      fix project specs
      copy entities fully to V3
      fix  entity error
      more fixes
      fix failing specs
      fixed missing entities in V3 API
      remove comment
      updated code based on feedback
      fix spec
  15. 27 Feb, 2017 1 commit
  16. 23 Feb, 2017 3 commits
  17. 14 Feb, 2017 1 commit
  18. 03 Feb, 2017 1 commit
  19. 30 Jan, 2017 2 commits
  20. 26 Jan, 2017 1 commit
  21. 17 Jan, 2017 1 commit
  22. 15 Jan, 2017 1 commit
  23. 21 Dec, 2016 2 commits
    • Markus Koller's avatar
      Add more storage statistics · 4571941f6307
      Markus Koller authored
      This adds counters for build artifacts and LFS objects, and moves
      the preexisting repository_size and commit_count from the projects
      table into a new project_statistics table.
      The counters are displayed in the administration area for projects
      and groups, and also available through the API for admins (on */all)
      and normal users (on */owned)
      The statistics are updated through ProjectCacheWorker, which can now
      do more granular updates with the new :statistics argument.
    • Markus Koller's avatar
      Don't expose all namespace fields in API · 3dc2d89a55cc
      Markus Koller authored
  24. 16 Dec, 2016 1 commit
  25. 01 Dec, 2016 1 commit
  26. 28 Nov, 2016 2 commits
  27. 23 Nov, 2016 1 commit
  28. 11 Nov, 2016 1 commit
  29. 08 Nov, 2016 1 commit
  30. 04 Nov, 2016 1 commit
  31. 11 Oct, 2016 1 commit
  32. 10 Oct, 2016 1 commit