Read about our upcoming Code of Conduct on this issue

  1. 06 Nov, 2017 1 commit
  2. 10 Oct, 2017 1 commit
  3. 07 Oct, 2017 1 commit
  4. 15 Sep, 2017 1 commit
    • Yorick Peterse's avatar
      Fix setting share_with_group_lock · c5f0e09eb838
      Yorick Peterse authored
      Prior to this commit running
      Namespace#force_share_with_group_lock_on_descendants would result in
      updating _all_ namespaces in the namespaces table, not just the
      descendants. This is the result of ActiveRecord::Relation#update_all not
      taking into account the CTE. To work around this we use the CTE query as
      a sub-query instead of directly calling #update_all.
      
      To prevent this from happening the relations returned by
      Gitlab::GroupHierarchy are now marked as read-only, resulting in an
      error being raised when methods such as #update_all are used.
      
      Fortunately on GitLab.com our statement timeouts appear to have
      prevented this query from actually doing any damage other than causing
      a very large amount of dead tuples.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916
      c5f0e09eb838
  5. 06 Sep, 2017 2 commits
  6. 31 Aug, 2017 1 commit
  7. 14 Aug, 2017 1 commit
  8. 01 Aug, 2017 2 commits
  9. 17 Jul, 2017 1 commit
  10. 06 Jul, 2017 1 commit
    • Yorick Peterse's avatar
      Added Cop to blacklist the use of `dependent:` · ccb23d8870a8
      Yorick Peterse authored
      This is allowed for existing instances so we don't end up 76 offenses
      right away, but for new code one should _only_ use this if they _have_
      to remove non database data. Even then it's usually better to do this in
      a service class as this gives you more control over how to remove the
      data (e.g. in bulk).
      ccb23d8870a8
  11. 29 Jun, 2017 2 commits
  12. 28 Jun, 2017 1 commit
  13. 21 Jun, 2017 1 commit
  14. 02 Jun, 2017 1 commit
  15. 18 May, 2017 1 commit
  16. 17 May, 2017 2 commits
    • Yorick Peterse's avatar
      Hide nested group UI/API support for MySQL · 9af956e6164b
      Yorick Peterse authored
      This hides/disables some UI elements and API parameters related to
      nested groups when MySQL is used, since nested groups are not supported
      for MySQL.
      9af956e6164b
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · f63dad32f25f
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
      f63dad32f25f
  17. 12 May, 2017 2 commits
  18. 10 May, 2017 1 commit
  19. 01 May, 2017 2 commits
  20. 05 Apr, 2017 1 commit
  21. 03 Apr, 2017 2 commits
  22. 30 Mar, 2017 1 commit
  23. 23 Mar, 2017 1 commit
  24. 21 Mar, 2017 1 commit
  25. 24 Feb, 2017 2 commits
    • Timothy Andrew's avatar
      Implement final review comments from @DouweM and @rymai · 3bd3d6c6cc82
      Timothy Andrew authored
      - Have `Uniquify` take a block instead of a Proc/function. This is more
        idiomatic than passing around a function in Ruby.
      
      - Block a user before moving their issues to the ghost user. This avoids a data
        race where an issue is created after the issues are migrated to the ghost user,
        and before the destroy takes place.
      
      - No need to migrate issues (to the ghost user) in a transaction, because
        we're using `update_all`
      
      - Other minor changes
      3bd3d6c6cc82
    • Timothy Andrew's avatar
      Extract code from `Namespace#clean_path` for ghost user generation. · 2a04efbffa1c
      Timothy Andrew authored
      1. Create a `Uniquify` class, which generalizes the process of generating unique
         strings, by accepting a function that defines what "uniqueness" means in a
         given context.
      
      2. WIP: Make sure tests for `Namespace` pass, add more if necessary.
      
      3. WIP: Add tests for `Uniquify`
      2a04efbffa1c
  26. 23 Feb, 2017 5 commits
  27. 22 Feb, 2017 1 commit
  28. 20 Feb, 2017 1 commit
    • Z.J. van de Weg's avatar
      Transactional mattermost team creation · bc0c6ab29318
      Z.J. van de Weg authored
      Before this commit, but still on this feature branch, the creation of
      mattermost teams where a background job. However, it was decided it was
      better that these happened as transaction so feedback could be displayed
      to the user.
      bc0c6ab29318