Read about our upcoming Code of Conduct on this issue

  1. 02 Feb, 2018 1 commit
  2. 31 Aug, 2017 1 commit
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · e1c28a485974
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      e1c28a485974
  3. 25 May, 2017 1 commit
  4. 27 Apr, 2017 1 commit
  5. 02 Apr, 2017 1 commit
  6. 06 Nov, 2016 1 commit
  7. 30 Aug, 2016 1 commit
  8. 26 Nov, 2015 1 commit
  9. 09 Sep, 2015 1 commit
  10. 26 Aug, 2015 1 commit
  11. 19 Aug, 2015 4 commits